Use the new `role` attribute when creating images

Bug #1642914 reported by Łukasz Zemczak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Image
Fix Released
High
Łukasz Zemczak

Bug Description

Since now we have the role keyword supported in the parser, we need to get it used in all existing parts of the code. This means handling the StructureRole.mbr instead of type == 'mbr', as well as StructureRole.system_boot instead of filesystem_label == 'system-boot' etc.

Revision history for this message
Barry Warsaw (barry) wrote :

Your previous branch coerces type=='mbr' to role=mbr so that should be an easy transition. For backward compatibility though, be sure to still handle filesystem_label if role isn't provided.

Changed in ubuntu-image:
importance: Undecided → High
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Yeah, the mbr and system-boot parts were easy-peasy, the fun starts when we had to handle system-data as well. This is now done just not finalized from the tests POV.

Barry Warsaw (barry)
Changed in ubuntu-image:
milestone: 0.12 → 0.13
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Pull request with the changes for this: https://github.com/CanonicalLtd/ubuntu-image/pull/100

Barry Warsaw (barry)
Changed in ubuntu-image:
status: In Progress → Fix Committed
Barry Warsaw (barry)
Changed in ubuntu-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.