Simple Scan uses a headerbar in Cinnamon
Bug #1644813 reported by
Clement Lefebvre
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Simple Scan |
Fix Released
|
Medium
|
Unassigned | ||
| 3.20 |
Fix Committed
|
Medium
|
Unassigned | ||
| 3.22 |
Fix Committed
|
Medium
|
Unassigned | ||
| simple-scan (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Hi,
Please add Cinnamon to the list of DEs where a headerbar shouldn't be used. It doesn't fit that environment.
In src/ui.vala's load() function:
if (is_desktop ("Unity") || is_desktop ("XFCE") || is_desktop ("MATE") || is_desktop ("LXDE"))
should be:
if (is_desktop ("Unity") || is_desktop ("XFCE") || is_desktop ("MATE") || is_desktop ("LXDE") || is_desktop ("X-Cinnamon") || is_desktop ("Cinnamon"))
To reproduce, run:
XDG_CURRENT_
The expected result is a traditional titlebar+menubar, not a headerbar.
Thanks.
Revision history for this message
| Robert Ancell (robert-ancell) wrote | #1 |
| Changed in simple-scan: | |
| status: | New → Fix Committed |
| importance: | Undecided → Medium |
| milestone: | none → 3.23.1 |
| milestone: | 3.23.1 → 3.23.2 |
| Changed in simple-scan: | |
| status: | Fix Committed → Fix Released |
| Changed in simple-scan (Ubuntu): | |
| status: | New → Fix Committed |
| importance: | Undecided → Medium |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in simple-scan (Ubuntu): | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Clement Lefebvre (clementlefebvre) wrote | #3 |
To post a comment you must log in.
I've committed that change to trunk, was there an older series this would be useful on?