[SRU]full-screen switching is broken

Bug #1679573 reported by stsp
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Dosemu2
Fix Released
Unknown
libsdl
Unknown
Unknown
libsdl2 (Ubuntu)
Fix Released
Medium
Unassigned
Xenial
Fix Released
Medium
Gianfranco Costamagna
Zesty
Won't Fix
Medium
Unassigned

Bug Description

[ Bug impact ]
When switching to full-screen, the window
resizes, but the new drawing keeps going to
the small window of the previous size.
Or, otherwise, when switching back from
full-screen, the drawing can still be very
large, not fitting into a reduced window.

This manifests with multiple sdl apps, according
to google and sdl bugzilla. I myself have
this problem with dosemu2.

[ Fix ]
The upstream sdl ticket:
https://bugzilla.libsdl.org/show_bug.cgi?id=1859
The fix:
https://hg.libsdl.org/SDL/rev/f931db466859
Would be very nice if ubuntu can back-port this.

[ Regression potential ]
* this fix is part of artful+ releases
http://launchpadlibrarian.net/339948147/libsdl2_2.0.5+dfsg1-3ubuntu1_2.0.6+dfsg1-2ubuntu1.diff.gz
Applied in 2.0.6 release

Changed in dosemu2:
status: Unknown → New
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

I don't plan to fix zesty, should I?

Changed in libsdl2 (Ubuntu):
status: New → Fix Released
Changed in libsdl2 (Ubuntu Xenial):
status: New → In Progress
summary: - full-screen switching is broken
+ [SRU]full-screen switching is broken
description: updated
description: updated
Changed in libsdl2 (Ubuntu Zesty):
status: New → Incomplete
Changed in libsdl2 (Ubuntu Xenial):
assignee: nobody → LocutusOfBorg (costamagnagianfranco)
Revision history for this message
Brian Murray (brian-murray) wrote :

Yes, this should be fixed in Zesty as an upgrade from Xenial to Zesty is supported.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

uploaded for zesty too

Changed in libsdl2 (Ubuntu Zesty):
status: Incomplete → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello stsp, or anyone else affected,

Accepted libsdl2 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libsdl2/2.0.4+dfsg1-2ubuntu2.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libsdl2 (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello stsp, or anyone else affected,

Accepted libsdl2 into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libsdl2/2.0.5+dfsg1-2ubuntu3.17.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libsdl2 (Ubuntu Zesty):
status: In Progress → Fix Committed
tags: added: verification-needed-zesty
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote : [libsdl2/xenial] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for xenial for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Revision history for this message
stsp (stsp-0) wrote :

Isn't it just a packaging of a more recent SDL?
Should I indeed test it explicitly so that it
not to be removed?
I tested this fix directly from SDL repository
before reporting the problem here.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

@stsp please test the proposed package, thanks

Revision history for this message
stsp (stsp-0) wrote :

So I have 2.0.6+dfsg1-3ubuntu1 already installed,
and there seem to be no bug. But I have not used
the -proposed repo for this.
So is it possible that the fixed packages are
already in the main Artful repo and we don't have
to care?

Revision history for this message
stsp (stsp-0) wrote :

Well its definitely in 2.0.6.
It was released in 17 Sep 2017:
https://discourse.libsdl.org/t/sdl-2-0-6-released/23109
and the fix was committed at 2017-04-03.
So my suggestion is to just mark this as fixed.

Changed in dosemu2:
status: New → Fix Released
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

@stsp can you please test the xenial proposed package on a xenial machine?
thanks!

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

What's the status of the verification here? The libsdl2 xenial SRU has been marked for removal due to the lack of fix verification. Could someone test it by any chance? If not, I'll have to remove the package from -proposed.

Mathew Hodson (mhodson)
Changed in libsdl2 (Ubuntu):
importance: Undecided → Medium
Changed in libsdl2 (Ubuntu Xenial):
importance: Undecided → Medium
Changed in libsdl2 (Ubuntu Zesty):
importance: Undecided → Medium
Revision history for this message
stsp (stsp-0) wrote :

Feel free to remove the patched package.
The fix was applied 2 years ago.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

nobody (including me) reported new bugs in the xenial-proposed package, so I guess it can land safely now.

Changed in libsdl2 (Ubuntu Zesty):
status: Fix Committed → Invalid
tags: added: verification-done verification-done-xenial
removed: removal-candidate verification-needed verification-needed-xenial verification-needed-zesty
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

I used the package for some time when I built it, and then I switched to bionic, but I never encountered regressions.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

We would need someone to perform real testing on this. Can you or someone else actually pick up a xenial machine/kvm, upgrade the package from -proposed and see if the original bug can be reproduced (with e.g. dosemu2)?

tags: added: verification-needed verification-needed-xenial
removed: verification-done verification-done-xenial
Revision history for this message
stsp (stsp-0) wrote :

But why not to have the unpatched new upstream
version that already contains the fix? Or is
xenial in a freeze mode and updated packages
are not accepted?

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

@stsp is it not possible to release new versions in stable Ubuntus. (not usually permitted)

@sil2100, I had troubles in setup a virtual machine, but I think everything went fine in my testing (I tried xmonad/dosemu2)!

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Brian Murray (brian-murray) wrote :

@costamagnagianfranco - "I think everything went fine" does not install a lot of confidence in me so I'm setting it back to verification-needed.

tags: added: verification-needed-xenial
removed: verification-done-xenial
Revision history for this message
Brian Murray (brian-murray) wrote : Reminder of SRU verification policy change

Thank you for taking the time to verify this stable release fix. We have noticed that you have used the verification-done tag for marking the bug as verified and would like to point out that due to a recent change in SRU bug verification policy fixes now have to be marked with per-release tags (i.e. verification-done-$RELEASE). Please remove the verification-done tag and add one for the release you have tested the package in. Thank you!

https://wiki.ubuntu.com/StableReleaseUpdates#Verification

Mathew Hodson (mhodson)
Changed in libsdl2 (Ubuntu Zesty):
status: Invalid → Won't Fix
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

fullscreen dosemu2 running

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libsdl2 - 2.0.4+dfsg1-2ubuntu2.16.04.1

---------------
libsdl2 (2.0.4+dfsg1-2ubuntu2.16.04.1) xenial; urgency=medium

  * Cherry-pick upstream fix for full-screen switching mode
    LP: #1679573

 -- Gianfranco Costamagna <email address hidden> Sat, 11 Nov 2017 10:55:43 +0100

Changed in libsdl2 (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for libsdl2 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.