libzen wasn't compiled with large file support

Bug #1693850 reported by Chow Loong Jin
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
libzen (Ubuntu)
Fix Released
Undecided
Chow Loong Jin
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned
Zesty
Fix Released
Undecided
Unassigned
Artful
Fix Released
Undecided
Chow Loong Jin

Bug Description

[Impact]

The switch to cmake caused two compilation flags to be accidentally dropped:
-D_LARGE_FILES -D_FILE_OFFSET_BITS=64

This causes all file-handling operations in zenlib to fail to work with large files on 32-bit machines. This affects the following reverse-dependencies:

 - libmediainfo
 - mediainfo
 - mediaconch

This has been fixed in https://github.com/MediaArea/ZenLib/commit/dc105b3ed035413577d21c979d1998d889350855.

[Test Case]

Run `mediainfo $filename` where $filename is a file that is larger than 4.2GB. Output will be missing if this bug is present.

[Regression Potential]

Quite low, since the only thing that's changed here are some -D compilation flags that aren't even directly referenced in the codebase.

description: updated
Changed in libzen (Ubuntu):
status: New → Fix Released
status: Fix Released → Triaged
Revision history for this message
Chow Loong Jin (hyperair) wrote :

This bug was fixed in the package libzen - 0.4.35-1

---------------
libzen (0.4.35-1) experimental; urgency=medium

  * [015b0fa] Imported Upstream version 0.4.35

 -- Chow Loong Jin <email address hidden> Tue, 04 Apr 2017 00:39:46 +0800

Changed in libzen (Ubuntu):
status: Triaged → Fix Released
Changed in libzen (Ubuntu Xenial):
status: New → Triaged
Changed in libzen (Ubuntu Yakkety):
status: New → Triaged
Changed in libzen (Ubuntu Zesty):
status: New → Triaged
description: updated
description: updated
Revision history for this message
Jérôme Martinez (j1-jerome) wrote :

> some -D compilation flags that aren't even directly referenced in the codebase

FYI impact is on the 32-bit libc usage, _FILE_OFFSET_BITS=64 enabling the libc file API with "off_t" of 64-bit instead of 32-bit.
No other interaction.

Example of impacted user (+ I got 2 emails with same bug report, no web link):
https://sourceforge.net/p/mediainfo/discussion/297610/thread/8893b38f/

Revision history for this message
Chow Loong Jin (hyperair) wrote :

Whoops, uploaded with a wrong version number (0.4.34-1ubuntu0.16.04.1) to zesty. I've fixed it with another upload (0.4.34-1ubuntu0.17.04.1).

Revision history for this message
Jérôme Martinez (j1-jerome) wrote :

Fix confirmed by end user to work, also on 16.04, see
https://sourceforge.net/p/mediainfo/discussion/297610/thread/8893b38f/#4075

Revision history for this message
Robie Basak (racb) wrote :

Do we know that this change won't be ABI impacting? Is this known, or has anybody looked into this?

Revision history for this message
Jérôme Martinez (j1-jerome) wrote :

There is no ABI impacting, as it is only internal (communication between the lib and libc API). libzen API uses 64-bit integers whatever is the presence of the flag, the flag is only for libc.
And actually, the ABI break would have been seen previously, when the compilation flag was removed (switch from Automake to CMake), as the flag was present in previous versions, and it was not the case.

In https://sourceforge.net/p/mediainfo/discussion/297610/thread/8893b38f/#4075 you can see that a user backported himself the new binary to an old platform of Debian without API break.

Revision history for this message
Chow Loong Jin (hyperair) wrote :

Yeah I tested it using mediainfo on a large file in chroots of the target distributions without rebuilding mediainfo.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
I was looking at the ABI question asked by Robie in #5.
The package fortunately has a symbols file and it would pop up there if the breakage would affect the symbols themselve.
There might be a fix behind stable symbols - like the actually desired fix for huge files. But that should be a no-op or an improvement IMHO.
So I'd expect the ABI impact to be ok.

Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Chow, or anyone else affected,

Accepted libzen into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libzen/0.4.32-1ubuntu0.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libzen (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-xenial
Changed in libzen (Ubuntu Yakkety):
status: Triaged → Fix Committed
tags: added: verification-needed-yakkety
Revision history for this message
Robie Basak (racb) wrote :

Hello Chow, or anyone else affected,

Accepted libzen into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libzen/0.4.33-3ubuntu0.16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-yakkety to verification-done-yakkety. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-yakkety. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libzen (Ubuntu Zesty):
status: Triaged → Fix Committed
tags: added: verification-needed-zesty
Revision history for this message
Robie Basak (racb) wrote :

Hello Chow, or anyone else affected,

Accepted libzen into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libzen/0.4.34-1ubuntu0.17.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Chow Loong Jin (hyperair) wrote :

Tested and verified on xenial, yakkety and zesty.

tags: added: verification-done verification-done-xenial verification-done-yakkety verification-done-zesty
removed: verification-needed verification-needed-xenial verification-needed-yakkety verification-needed-zesty
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libzen - 0.4.32-1ubuntu0.16.04.1

---------------
libzen (0.4.32-1ubuntu0.16.04.1) xenial-proposed; urgency=medium

  * [8601742] Import large files patch (LP: #1693850)

 -- Chow Loong Jin <email address hidden> Tue, 30 May 2017 00:39:22 +0800

Changed in libzen (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for libzen has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libzen - 0.4.34-1ubuntu0.17.04.1

---------------
libzen (0.4.34-1ubuntu0.17.04.1) zesty-proposed; urgency=medium

  * [ed99500] Import large files patch (LP: #1693850)

 -- Chow Loong Jin <email address hidden> Sat, 27 May 2017 01:17:40 +0800

Changed in libzen (Ubuntu Zesty):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libzen - 0.4.33-3ubuntu0.16.10.1

---------------
libzen (0.4.33-3ubuntu0.16.10.1) yakkety-proposed; urgency=medium

  * [57d99f9] Import large files patch (LP: #1693850)

 -- Chow Loong Jin <email address hidden> Tue, 30 May 2017 00:24:00 +0800

Changed in libzen (Ubuntu Yakkety):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.