eni rendering broken for bridge params that require repeated key for values
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cloud-init |
Fix Released
|
Medium
|
Unassigned | ||
cloud-init (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Unassigned | ||
Zesty |
Fix Released
|
Medium
|
Unassigned | ||
Artful |
Fix Released
|
Medium
|
Unassigned |
Bug Description
=== Begin SRU Template ===
[Impact]
ENI rendering of bridge configuration options for bridge_pathcost, bridge_portprio and bridge_waitport would be limited to a single key/val pair. Now support multi-line key values for these configuration options.
[Test Case]
if [ ! -f lxc-proposed-
wget https:/
chmod 755 lxc-proposed-
fi
## get render tool
$ wget https:/
## write the network_data.json
$ cat >network_data.yaml <<EOF
version: 1
config:
- type: physical
name: eth0
mac_address: "c0:d6:9f:2c:e8:80"
- type: physical
name: eth1
mac_address: "aa:d6:9f:2c:e8:80"
- type: bridge
name: br0
bridge_
- eth0
- eth1
params:
bridge_fd: 1
- eth0 50
- eth1 75
- eth0 28
- eth1 14
bridge_stp: 'off'
- 1 eth0
- 2 eth1
EOF
for release in xenial zesty; do
echo "$release START --------------";
lxc start test-$release;
lxc file push net-convert.py test-$release/
lxc file push network_data.yaml test-$release/
for k in eni netplan; do
lxc exec test-$release -- python3 /net-convert.py \
done
lxc exec test-$release -- cat out.d/etc/
lxc exec test-$release -- cat out.d/etc/
done
[Regression Potential]
Fairly low, this feature adds support for multi-line keys for 3 specific bridge configuration options bridge_pathcost, bridge_portprio and bridge_waitport.
Prior releases didn't have this support and would have only allowed for a single configuration value for the key. Now the configuration is properly rendered for multiple-
[Other Info]
Upstream commit at
https:/
This is fixed in cloud-init via commit 00b678c61a.
Fix eni rendering for bridge params that require repeated key for values.
There are a few bridge parameters which require repeating the key with each
value in the list when rendering eni. Extend the network unittests to cover
all of the known bridge parameters and check we render eni and netplan
correctly.
ProblemType: Bug
DistroRelease: Ubuntu 17.04
Package: cloud-init 0.7.9-90-
ProcVersionSign
Uname: Linux 4.10.0-26-generic x86_64
NonfreeKernelMo
ApportVersion: 2.20.4-0ubuntu4.5
Architecture: amd64
Date: Wed Jul 26 19:33:36 2017
PackageArchitec
ProcEnviron:
TERM=xterm-
PATH=(custom, no user)
LANG=C.UTF-8
SourcePackage: cloud-init
UpgradeStatus: No upgrade log present (probably fresh install)
Hello Scott, or anyone else affected,
Accepted cloud-init into xenial-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ cloud-init/ 0.7.9-233- ge586fe35- 0ubuntu1~ 16.04.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification- needed- xenial to verification- done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- xenial. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!