grandr does not exit, if "x" is clicked

Bug #203026 reported by Daniel Hahler
4
Affects Status Importance Assigned to Milestone
grandr (Debian)
Fix Released
Unknown
grandr (Ubuntu)
Fix Released
Undecided
Daniel Hahler

Bug Description

Binary package hint: grandr

Clicking "x" to close the window of grandr does not make grandr exit really.

TO REPRODUCE:
1. start grandr from a console
2. click the "x" icon to close the window

"grandr" is still running.

A related bug had been fixed for crack-attack. See bug 114883, which has a patch attached.

Related branches

Revision history for this message
Stefan Ott (stefan-ott-net) wrote :

This patch fixes that. Would be nice to have it applied.

Changed in grandr:
status: New → Confirmed
Revision history for this message
Kurt Litsch (kurt.litsch) wrote :

Debdiff with Stefan's patch applied. Could someone in u-u-s please look?

Revision history for this message
Daniel Hahler (blueyed) wrote :

Thanks for the patch, I'll sponsor it.

Changed in grandr:
assignee: nobody → blueyed
status: Confirmed → In Progress
Revision history for this message
Daniel Hahler (blueyed) wrote :

I've found that there are config.status.lineno and configure.lineno in the debdiff, which should probably get removed in the "clean" target (but I'm not sure).

Also, it would be nice to fix (at least some of) the following lintian warnings:
W: grandr source: debian-rules-ignores-make-clean-error line 42
W: grandr source: desktop-file-but-no-dh_desktop-call
W: grandr source: out-of-date-standards-version 3.7.2 (current is 3.8.0)
W: grandr source: configure-generated-file-in-source config.status
W: grandr source: configure-generated-file-in-source config.log

If you can do this, this would be nice, otherwise please just subscribe u-u-s again.

Changed in grandr:
assignee: blueyed → kurt.litsch
status: In Progress → Incomplete
Changed in grandr:
status: Unknown → New
Revision history for this message
Kurt Litsch (kurt.litsch) wrote :

Thanks for the feedback. I added the lineno files to the clean target and corrected one of the lintian warnings (dh_desktop-call). The two config.status and config.log lintian warnings seem to be unwarranted, as those files are already removed in the clean target. The updated debdiff is attached; please inform me if there are any more problems.

Changed in grandr:
assignee: kurt.litsch → nobody
Changed in grandr:
status: Incomplete → Confirmed
Revision history for this message
Daniel Hahler (blueyed) wrote :

Thanks, uploaded.
Please note that I've removed debian/changelog.dch (a backup file) from the debdiff.

Changed in grandr:
assignee: nobody → blueyed
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package grandr - 0.1+git20080326-1ubuntu1

---------------
grandr (0.1+git20080326-1ubuntu1) intrepid; urgency=low

  * src/interface.c: applied patch by Stefan Ott to make the program
    exit after clicking on the "close" button (LP: #203026)
  * debian/rules: Updated clean target to correct some lintian warnings.

 -- Kurt Litsch <email address hidden> Thu, 04 Sep 2008 21:35:21 -0500

Changed in grandr:
status: In Progress → Fix Released
Changed in grandr:
status: New → Confirmed
Changed in grandr (Debian):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.