Ubuntu
gtk-qt-engine package

gtk-qt-engine-kde4 doesn't use Oxygen backwards/forwards buttons with Firefox 3

Bug #211839 reported by Jonathan Thomas on 2008-04-04

Affects		Status	Importance	Assigned to	Milestone
	GTK-Qt Theme Engine	Invalid	Undecided	Unassigned
	gtk-qt-engine (Ubuntu)	Fix Released	Wishlist	Jonathan Thomas

Bug Description

Binary package hint: gtk-qt-engine-kde4

Kubuntu-KDE4 8.04 Beta
gtk-qt-engine-kde4 1.1
Firefox 3 Beta 4

The backwards and forwards buttons in Firefox aren't oxygen. They seem to be from the GTK theme.

Related branches

lp:ubuntu/jaunty/gtk-qt-engine

Revision history for this message

Yuriy Kozlov (yuriy-kozlov) wrote on 2008-04-04:

I can confirm this in current Hardy.

Changed in gtk-qt-engine-kde4:
status:	New → Confirmed

Revision history for this message

Jonathan Thomas (echidnaman) wrote on 2008-04-05:

Also, it uses the wrong buttons used for:
New Tab (tab-new.png in Oxygen/freedesktop.org spec)
New Window (window-new.png)
Previous/next buttons used for the crtl + F search feature (go-previous.png/go-next.png)
Show all History in the history menu (view-history.png)

Epiphany uses the correct forwards and backwards buttons, but it doesn't use the correct pictures for the buttons listed in this comment.
Epiphany also uses the wrong "Bookmarks" icon on its toolbar, and the wrong "edit" and "new" bookmark icons in the bookmarks menu.

Revision history for this message

Jonathan Thomas (echidnaman) wrote on 2008-04-06:

Comparing Firefox's forward and backward buttons in /usr/share/icons/gnome, I conclude that the problem is that Firefox 3.0 isn't using the GTK icons for fowards and backwards.

Revision history for this message

Jonathan Thomas (echidnaman) wrote on 2008-04-06:

Or perhaps not, since with the default Gnome theme Epiphany uses the same icons.

Bug Watch Updater (bug-watch-updater) on 2008-04-06

Changed in gtk-qt-engine:
status:	Unknown → New

Revision history for this message

Andrew Min (andrewmin) wrote on 2008-05-15:

Same here.

Jonathan Thomas (echidnaman) on 2008-09-13

Changed in firefox-3.0:
importance:	Undecided → Wishlist

Alexander Sack (asac) on 2008-11-23

Changed in firefox-3.0:
status:	Confirmed → Triaged

Revision history for this message

Victor Bielawski (bielawski1) wrote on 2008-12-28:

Firefox reverts to the default GTK back and forward buttons if the icon theme does not explicitly define LTR and RTL versions of the icons.
The New Tab and New Window icons never use the current theme; they are compiled into Firefox.

Revision history for this message

Victor Bielawski (bielawski1) wrote on 2008-12-29:

^ Referring to xdg icon theme, not Firefox theme.

Revision history for this message

Jonathan Thomas (echidnaman) wrote on 2008-12-29:

Thanks. I know exactly how to fix this. I'm going to bed now but this should be a quick fix for tomorrow.

Changed in firefox-3.0:
assignee:	nobody → echidnaman
status:	Triaged → In Progress

Revision history for this message

Jonathan Thomas (echidnaman) wrote on 2009-01-05:

0ubuntu6.debdiff Edit (7.1 KiB, text/plain)

Upstream seems a bit dead, so we're probably going to just have to patch it in our packages for the time being.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-01-05:

#10

This bug was fixed in the package gtk-qt-engine - 1:1.1+svn20080816-0ubuntu6

---------------
gtk-qt-engine (1:1.1+svn20080816-0ubuntu6) jaunty; urgency=low

  * Map gtk-go-forward/backward-rtl/ltr icons to their corresponding FD.o
    icons (so that Firefox won't use gnome back/forward buttons) with
    kubuntu_04_update_icon_mapping.diff (LP: #211839)
  * Also map gtk-sort-ascending/descending to view/sort-ascending/descending
  * Refresh all patches

-- Jonathan Thomas <email address hidden> Sun, 28 Dec 2008 21:57:29 -0500