usplash_timeout_get_string not exported

Bug #224709 reported by James Westby
2
Affects Status Importance Assigned to Milestone
usplash (Ubuntu)
Fix Released
Undecided
Andrea Gasparini

Bug Description

Binary package hint: usplash

Hi,

usplash 0.5.10 changed usplash_get_string in libusplash.c
to usplash_timeout_get_string, but did not update
the header file, so currently usplash doesn't export the
latter, and exports the former which doesn't exist.

There are three solutions that I see to this problem:

  * Rename the declaration in the header
  * Add back a wrapper function usplash_get_string
     that calls the new function.
  * Do both and have both functions exported.

This is needed to fix bug 114688, which I think may
qualify for an SRU, so I would like it if this could be considered
for an SRU as well.

Thanks,

James

Revision history for this message
Andrea Gasparini (gaspa) wrote :

Yep, i think usplash_get_string was cutted off for some clean. :P

Changed in usplash:
assignee: nobody → gaspa
status: New → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

Merged to main branch r232, and uploaded to intrepid, awaiting RM approval now.

Changed in usplash:
status: Confirmed → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usplash - 0.5.25

---------------
usplash (0.5.25) intrepid; urgency=low

  * libusplash.h: Export usplash_timeout_get_string() definition and provide a
    backward compatibility definition for usplash_get_string(), which got
    more or less accidentally removed in r174. This is a prerequisite for
    fixing bug 114688. Thanks to Andrea Gasparini for the patch!
    (LP: #224709)

 -- Martin Pitt <email address hidden> Thu, 16 Oct 2008 23:39:43 +0200

Changed in usplash:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.