[intrepid alpha1] apt-mirror gives error "closedir() attempted on invalid dirhandle DIR at /usr/bin/apt-mirror line 537."

I confirm this - newest intrepid with all updates same problem

The bug lies in the process_directory - method of the apt-mirror script. It is called recursively for every subdirectory while using a global DIRHANDLE so the DIRHANDLE of the parent directories always gets overwritten and so the closedir() call tries to close a subdirectory which has already been closed :D

I have created a little patch for the apt-mirror 0.4.5-1ubuntu1 package:

528a529,530
> my $dirhandle;
>
530,531c532,533
< opendir(DIR, $dir) or die "apt-mirror: can't opendir $dir: $!";
< foreach (grep { !/^\.$/ && !/^\.\.$/ } readdir(DIR)) {
---
> opendir($dirhandle, $dir) or die "apt-mirror: can't opendir $dir: $!";
> foreach (grep { !/^\.$/ && !/^\.\.$/ } readdir($dirhandle)) {
537c539
< closedir DIR;
---
> closedir $dirhandle;

Maybe that helps to get the bug fixed :D

apt-mirror (0.4.5-1ubuntu2) jaunty; urgency=low

  * Add 02-fix-invalid-dirhandle.dpatch (LP: #244613)
  * debian/Ubuntu-mirror.list:
    - fix typo (privlages -> privileges)
    - update distribution to jaunty
  * debian/rules: Move binary-arch commands to binary-indep
  * debian/control:
    - remove homepage from description
    - bump Debian standards version to 3.8.0, no changes needed

-- Benjamin Drung <email address hidden> Sat, 01 Nov 2008 20:41:20 +0100

And here the debdiff for intrepid-proposed:

apt-mirror (0.4.5-1ubuntu1.1) intrepid-proposed; urgency=low

  * Add 02-fix-invalid-dirhandle.dpatch (LP: #244613)
  * debian/Ubuntu-mirror.list:
    - fix typo (privlages -> privileges)
    - update distribution to intrepid

 -- Benjamin Drung <email address hidden> Sat, 01 Nov 2008 19:40:38 +0100

This bug was fixed in the package apt-mirror - 0.4.5-1ubuntu2

---------------
apt-mirror (0.4.5-1ubuntu2) jaunty; urgency=low

  * Add 02-fix-invalid-dirhandle.dpatch (LP: #244613)
  * debian/Ubuntu-mirror.list:
    - fix typo (privlages -> privileges)
    - update distribution to jaunty
  * debian/rules: Move binary-arch commands to binary-indep
  * debian/control:
    - remove homepage from description
    - bump Debian standards version to 3.8.0, no changes needed

 -- Benjamin Drung <email address hidden> Sat, 01 Nov 2008 20:41:20 +0100

Hi,

Will this new apt-mirror package be in the Intrepid repos anytime soon? Or should I just install it from the jaunty repos to get rid of these annoying messages in my mail.

I hope someone from ubuntu-sru will review my patch for intrepid. Meanwhile you can grab the fixed package from my PPA: https://launchpad.net/~bdrung/+archive

ACK from motu-sru for the patch in comment https://bugs.edge.launchpad.net/ubuntu/+source/apt-mirror/+bug/244613/comments/4

Sorry for double-posting, but in the future it'd be great if the debdiff for -proposed were clearly linked in the original description.

motu-sru ACK.

Sponsored to intrepid-proposed.

Accepted into intrepid-proposed, please test.

Installed package from intrepid-proposed and it works.

This bug was fixed in the package apt-mirror - 0.4.5-1ubuntu1.1

---------------
apt-mirror (0.4.5-1ubuntu1.1) intrepid-proposed; urgency=low

  * Add 02-fix-invalid-dirhandle.dpatch (LP: #244613)
  * debian/Ubuntu-mirror.list:
    - fix typo (privlages -> privileges)
    - update distribution to intrepid

 -- Benjamin Drung <email address hidden> Sat, 01 Nov 2008 19:40:38 +0100

Bug not yet fixed in Hardy