Please sponsor liferea 1.4.18-0ubuntu1

Bug #259578 reported by Fabien Tassin
6
Affects Status Importance Assigned to Milestone
liferea (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: liferea

Here is a debdiff (debian/ dir only)

Related branches

Revision history for this message
Fabien Tassin (fta) wrote :
Revision history for this message
Alexander Sack (asac) wrote :

I see that you fixed the XULRUNNER_HOME failure if XPCOM_GLUE Is used. Did you do anything to the Makefile.am and the code where XULRUNNER_HOME is used? e.g. consider to ifndef XPCOM_GLUE that bit.

Revision history for this message
Fabien Tassin (fta) wrote :

There was no need to modify Makefile.am.
The previous version of debian/patches/xulrunner-1.9 was already doing just that in the code:

 static void xulrunner_init(void) {

+#ifndef XPCOM_GLUE
        /* gtk_moz_embed_set_comp_path() must not be called
           without a component path for XulRunner. Passing
           NULL will crash Liferea. */
        gtk_moz_embed_set_comp_path(XULRUNNER_HOME);
+#endif

        mozembed_init();
 }

Revision history for this message
Alexander Sack (asac) wrote :

ok. thanks for the explanation. Looks good from my side.

Please provide all the pieces I need for sponsoring:

 1. link to orig.tar.gz (from debian?), .diff.gz, .dsc

Also in future, make reviewing easier, by also attaching a filtered debdiff with just the debian/ dir.

Changed in liferea:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Fabien Tassin (fta) wrote :

As I said, it *is* a filtered debdiff:

ix:~/bzr/debdiff$ diffstat -p 0 liferea_1.4.16b-0.1ubuntu1--1.4.18-0ubuntu1.debdiff
 liferea-1.4.18/debian/changelog | 10
 liferea-1.4.18/debian/patches/99_autoconf | 981 ++++++++++++++++++++++++----
 liferea-1.4.18/debian/patches/xulrunner-1.9 | 61 +
 3 files changed, 917 insertions(+), 135 deletions(-)

Source: http://downloads.sourceforge.net/liferea/liferea-1.4.18.tar.gz (or just use the watch file)

Revision history for this message
Fabien Tassin (fta) wrote :

and the dsc

Revision history for this message
Fabien Tassin (fta) wrote :
Revision history for this message
Fabien Tassin (fta) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package liferea - 1.4.18-0ubuntu1

---------------
liferea (1.4.18-0ubuntu1) intrepid; urgency=low

  * New upstream release (LP: #259578)
  * Fixes ugly CPU spikes caused by broken expiring mechanism
  * debian/patches/xulrunner-1.9: don't die on missing XULRUNNER_HOME when
    -DXPCOM_GLUE is found.
  * debian/patches/99_autoconf: updated to reflect changes.

 -- Fabien Tassin <email address hidden> Mon, 18 Aug 2008 22:24:30 +0200

Changed in liferea:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.