nautilus-sendto is build without Gajim support

Bug #261166 reported by Florian Zeitz
14
Affects Status Importance Assigned to Milestone
nautilus-sendto (Ubuntu)
Fix Released
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: nautilus-sendto

nautilus-sendto should build-depend on Gajim like it does in Debian.
This is because the configure script checks whether to build the gajim plugin based on the existence of /usr/share/pixmaps/gajim.png.
I noticed Gajim was removed from the description some time ago, but IMHO it would still be better to support it.
Also it's still mentioned in README.Debian and python-dbus is still recommended (which is completely useless without the gajim plugin AFAIK)

Revision history for this message
Sebastien Bacher (seb128) wrote :

the gajim option is not enabled because that's an universe package and nautilus-sendto can't build-depends on it, marking it low issue due to the recommends not required though

Changed in nautilus-sendto:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Florian Zeitz (florian-zeitz) wrote :

In that case I'd beg you to just remove the check for gajim.png from the configure script in a patch. Which would remove the need to build-depend on gajim, but still enable building the plugin.
The file is not needed during build time and as the plugin will only load when gajim is running (therefore probably installed), it shouldn't cause problems during runtime (after all debian builds the plugin and doesn't have a dependency on gajim so that should work)

Revision history for this message
Sebastien Bacher (seb128) wrote :

the desktop team is overworked and gajim which is in universe is not a priority but you are welcome to work on the change and contribute by sending a patch to fix the issue

Revision history for this message
Florian Zeitz (florian-zeitz) wrote :

Attaching a debdiff that should fix the issue.

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for the change, that seems an acceptable change, could you update the description and the rules option to use the debian version again though

Revision history for this message
Florian Zeitz (florian-zeitz) wrote :

I can, it's not necessarily a good idea though ;)
The new patch I attached gets control(.in) and rules closer to the debian version again, there are still differences though, due to the fact that Debian has Icedove and Ubuntu has Thunderbird. Also adding --with-gajim=/usr back is purely to be closer to Debian. After all the whole point of this patch is to not check for icons in there any longer.

Revision history for this message
Sebastien Bacher (seb128) wrote :

the patch looks good, could you remove the extra changelog blank line you added and list the bug number to close there too though? once those are changed I'll sponsor the upload

Changed in nautilus-sendto:
status: Triaged → Incomplete
Revision history for this message
Florian Zeitz (florian-zeitz) wrote :

Hah, really wonder how that black line slipped in there.
Anyway here is a new version that closes this ticket and has no extra blanks (hopefully).

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for the update, the correct syntax to close launchpad bugs is "lp: bugnumber", the closes syntax is a debian one

Revision history for this message
Florian Zeitz (florian-zeitz) wrote :

So I take it that there is no syntax for referencing a bug without closing it?

Revision history for this message
Sebastien Bacher (seb128) wrote :

you can use any syntax which is not the closing one to reference a bug, don't forgot the reopen bugs once you do changes otherwise they are not listed on the sponsoring lists

Changed in nautilus-sendto:
status: Incomplete → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nautilus-sendto - 1.0.1-0ubuntu2

---------------
nautilus-sendto (1.0.1-0ubuntu2) intrepid; urgency=low

  * Add a patch to build gajim regardless of
    $GAJIM_SHARE_DIR/data/pixmaps/gajim.png's presence (lp: #261166")

 -- Florian Zeitz <florian@Flows> Tue, 26 Aug 2008 15:13:35 +0200

Changed in nautilus-sendto:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.