"Suspend" icon is black rectangle in "Shut Down" dialog

Bug #269504 reported by Matthew Paul Thomas
16
Affects Status Importance Assigned to Milestone
human-icon-theme (Ubuntu)
Fix Released
High
Kenneth Wimer
Intrepid
Fix Released
High
Kenneth Wimer

Bug Description

Binary package hint: gnome-session

Ubuntu Intrepid alpha 5, all updates installed

In the Shut Down dialog, "Suspend" has a black rectangle icon, which doesn't seem to be related to the command. I think this is because the proper icon is missing, so the black rectangle is a placeholder.

It may save time to fix bug 269500 and/or bug 269502 at the same time as this bug.

Related branches

Revision history for this message
Matthew Paul Thomas (mpt) wrote :
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Confirmed on Intrepid alpha 5, all updates installed

Changed in gnome-session:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

The hibernate icon also seems a bit out of place... I wonder why this dialog isn't using the theme icons. For instance, human-icon-theme installs:

/usr/share/icons/Human/22x22/apps/gnome-session-suspend.png
/usr/share/icons/Human/24x24/apps/gnome-session-suspend.png
/usr/share/icons/Human/48x48/apps/gnome-session-suspend.png
/usr/share/icons/Human/scalable/apps/gnome-session-suspend.svg

It also include matching shut-down, restart, and hibernate icons in the same locations...

Changed in gnome-session:
assignee: nobody → desktop-bugs
Revision history for this message
Սահակ (petrosyan) wrote :

"Restart" icon also seems to be a lot smaller than the other icons. This breaks vertical text alignment.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

"Restart" being too small is bug 269502, which I already linked to from this report.

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Matthew,

I'm not sure that this is an issue with the human-icon-theme. While the issues you point out in other bug reports are resolved for me using different themes, this issue persists. The "black rectangle icon" is used with all icon themes included with a default Ubuntu Intrepid.

Changed in human-icon-theme:
assignee: desktop-bugs → kwwii
importance: Low → High
Changed in human-icon-theme:
milestone: none → ubuntu-8.10-beta
Revision history for this message
Kenneth Wimer (kwwii) wrote :

The problem is not with the icon theme but rather the icons that the code refers to. The small arrow is the "refresh" icon, an action. Instead it should be using the icons from the apps icons gnome-session-*.png .

Revision history for this message
Kenneth Wimer (kwwii) wrote :

OK, so the icon naming issue I won't get into. The quick and dirty way around this is to draw the view-refresh icon as well as a system-shutdown icon in the human theme.

Revision history for this message
Santiago Roland (santiago-roland) wrote :

The "suspend" icon on Quit prompt is missing in the Tango icon theme also...

Revision history for this message
Kenneth Wimer (kwwii) wrote :

Ok, I have submitted a new human icon theme package (0.30) with the necessary icons. Should be fixed in Intrepid soon. You can test it from my PPA

Martin Pitt (pitti)
Changed in human-icon-theme:
status: Confirmed → Fix Committed
Revision history for this message
Gert Kulyk (gkulyk) wrote :

I've tested your new human-icon-theme package, but it still does show a black rectangle.
After some investigation I've found out the following:

The icon for the suspend-action at the moment needs to be called "sleep", take e.g. a look at
80_new_upstream_session_dialog.patch from gnome-session sources:

Here is the relevant part (gnome-session-2.24.0/gnome-session/gsm-logout-dialog.c)

+#define GSM_ICON_LOGOUT "system-log-out"
+#define GSM_ICON_SWITCH "system-users"
+#define GSM_ICON_SHUTDOWN "system-shutdown"
+#define GSM_ICON_REBOOT "view-refresh"
+/* TODO: use gpm icons? */
+#define GSM_ICON_HIBERNATE "drive-harddisk"
+#define GSM_ICON_SLEEP "sleep"

As you can see, the naming scheme is far from beeing ideal. Maybe a bug against gnome-session should be filed to use sane icon-names for this kind of actions (and which are included in gnome/tango/human themes).

Revision history for this message
Gert Kulyk (gkulyk) wrote :

gnome-session-bug opened, you'll find it here: Bug #274889

Revision history for this message
Gert Kulyk (gkulyk) wrote :

@Kenneth
I've checked out latest bzr-branch (rev 60) of human-icon-theme. I saw that you've already checked in sleep.svg and the other files, but it seems like you've forgotten to add the new icons to Makefile.am, so if you run autogen.sh/dpkg-buildpacke, a package/an install without the new icons is produced.

Revision history for this message
Kenneth Wimer (kwwii) wrote :

Yes, I realized my error after testing the package. I have added them to the make file and updated the package which I submitted for submisison. Because the version number is the same I cannot host it on my PPA (I'd have to make a different version and it didn't seem worth it). I will update the package on launchpad. A fix should be coming soon.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package human-icon-theme - 0.30

---------------
human-icon-theme (0.30) intrepid; urgency=low

  * Reverting spelling error, it was taken care of in the scripts already and
    the package therefor failed to build.

human-icon-theme (0.29) intrepid; urgency=low

  * Adding icons to fix LP: #269504 as well as LP: #269500 .
  * Found an issue with one icon name
  * Adding a link to folder-move and folder-copy for evolution

 -- Kenneth Wimer <email address hidden> Fri, 26 Sep 2008 15:38:06 +0200

Changed in human-icon-theme:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.