python-smartpm should not conflict with the old smartpm-core package

Bug #269521 reported by Christopher Armstrong
2
Affects Status Importance Assigned to Milestone
smart (Ubuntu)
Fix Released
Undecided
Christopher Armstrong

Bug Description

<niemeyer> cjwatson: I think we found the issue
<niemeyer> cjwatson: The new python-smartpm package has a Conflicts relation with the old smartpm-core package
<cjwatson> ah, heh, that's a bug in the package
<cjwatson> I actually thought about mentioning that when I saw it in NEW
<cjwatson> silly me for not doing so
<cjwatson> Replaces is quite sufficient
<niemeyer> cjwatson: Doesn't that mean that both might be installed at the same time?
<niemeyer> cjwatson: Should we use Breaks perhaps?
<cjwatson> Replaces is good enough.
<cjwatson> it's just a file move
<niemeyer> cjwatson: Ok, cool

The change which introduced the Pre-Depends on smartpm-core -> python-smartpm was incorrect; it should be reverted, and instead the conflict should be removed.

Here's the rationale for reverting the last change:

<radix> cjwatson: ok, so smartpm-core installs a symlink /usr/bin/smart -> /usr/share/smart/smart; python-smartpm installs /usr/share/smart/smart
<radix> cjwatson: smartpm-core invokes 'smart' in its own postinst
<cjwatson> hunger: -fno-stack-protector
<cjwatson> radix: that only requires Depends
<radix> cjwatson: does a Depend guarantee that the depended-upon package will be unpacked before the depending package?
<cjwatson> radix: you would only need Pre-Depends if you were invoking smart in smartpm-core's preinst
<cjwatson> radix: yes, absolutely!
<radix> humm, we actually found an error
<cjwatson> Pre-Depends is usually not the right fix, and policy explicitly says that you must discuss new Pre-Depends
<cjwatson> precisely because they're usually the wrong fix and complicate upgrades
<radix> ah. woops. :-(

Revision history for this message
Christopher Armstrong (radix) wrote :

Patch attached, please review. requesting sponsorship.

Changed in smart:
assignee: nobody → radix
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package smart - 1.1-0ubuntu4

---------------
smart (1.1-0ubuntu4) intrepid; urgency=low

  * Fixes for (LP: #269521)
    - debian/control:
      - Change Pre-Depend of smartpm-core on python-smartpm to a regular
        Depends.
      - Remove the conflict of python-smartpm with
        smartpm-core (<< 1.1-0ubuntu2)

 -- Christopher Armstrong <email address hidden> Fri, 12 Sep 2008 16:54:50 -0400

Changed in smart:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.