Doesn't recognize Ubuntu native packages as Ubuntu packages

Bug #273997 reported by Adrien Cunin
8
Affects Status Importance Assigned to Milestone
lintian (Debian)
Fix Released
Unknown
lintian (Ubuntu)
Fix Released
Low
Adrien Cunin

Bug Description

Binary package hint: lintian

% lintian ubuntu-dev-tools_0.45.dsc
W: ubuntu-dev-tools source: changelog-should-mention-nmu
W: ubuntu-dev-tools source: source-nmu-has-incorrect-version-number 0.45

and when checking .changes (see comment below):
E: ubuntu-dev-tools_0.45_source.changes: bad-distribution-in-changes-file intrepid

Revision history for this message
Scott Kitterman (kitterman) wrote :

Since the package doesn't have Ubuntu specfic versioning, how would Lintian know not to apply the Debian tests?

Changed in lintian:
status: New → Incomplete
Revision history for this message
Adrien Cunin (adri2000) wrote :

Checking distribution instead of version, I guess. I'm currently looking at the code and will try to propose a patch.

By the way, when checking the .changes instead of the .dsc, there is another false positive:
E: ubuntu-dev-tools_0.45_source.changes: bad-distribution-in-changes-file intrepid

So the bug actually is that lintian doesn't recognize Ubuntu native packages as Ubuntu packages.

Changed in lintian:
assignee: nobody → adri2000
importance: Undecided → Low
status: Incomplete → In Progress
Adrien Cunin (adri2000)
description: updated
Revision history for this message
Adrien Cunin (adri2000) wrote :

Here is the patch (debdiff for jaunty even). Please review and, if it's fine, upload. In this case, I will then make sure it is forwarded to Debian.

Subscribing u-m-s, and Colin, given that he's one of the Debian uploaders.

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 273997] Re: Doesn't recognize Ubuntu native packages as Ubuntu packages

There's a pending sync request for lintian 2.1.0. Would you please ensure
your patch is good with 2.1.0 and perhaps update the debdiff (I haven't
actually reviewed the patch - doing bugmail through my phone).

Revision history for this message
Loïc Minier (lool) wrote :

Patch will try to match $distribution on all <CHANGELOG> lines, not just the first.

minor note: noneed for " .*$" after ";" in dist matching regexp

Revision history for this message
Adrien Cunin (adri2000) wrote :

Here is the debdiff against 2.1.0. Scott: I closed your sync request, so that everything (sync + patch) is done in a row.
Loïc: I fixed what you describe in your first remark, but didn't change the regexp: the " .*$" part doesn't seem mandatory indeed, but it doesn't hurt either. I prefer to keep so that it's clear how the line is splitted and which part we are taking. If there is another reason to not keep it that I missed, feel free to remove it when uploading (whoever uploads the package).

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, looks good. I've sponsored the upload.

Changed in lintian:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (6.1 KiB)

This bug was fixed in the package lintian - 2.1.0ubuntu1

---------------
lintian (2.1.0ubuntu1) jaunty; urgency=low

  * Sync from Debian unstable
  * Recognize Ubuntu native packages as Ubuntu packages (LP: #273997)
     - Use distribution (and not only version) to decide whether a package
       is an Ubuntu package

lintian (2.1.0) unstable; urgency=low

  * Summary of tag changes:
    + Added
      - debhelper-but-no-misc-depends
      - missing-build-dependency-for-dh_-command
      - quilt-patch-missing-description
      - shlib-calls-exit

  * checks/common_data.pm:
    + [FL] New variable $known_shells_regex which matches known shell
      names. This removes some synchronisation issues between the
      different regexes in use.
  * checks/debconf{,.desc}:
    + [CW] Update my e-mail address.
    + [ADB] Don't detect the use of "?" as a literal character or wildcard
      as part of a question in an extended template description. Based
      on a patch by Stephen Gran. (Closes: #500661)
  * checks/debhelper:
    + [FL] Use Lintian::Data for list of debhelper commands that modify
      maintainer scripts. Patch by Raphael Geissert.
    + [FL] Add new tag missing-build-dependency-for-dh_-command for
      debhelper commands that are not from the debhelper package.
      Patch by Raphael Geissert.
    + [FL] Add new tag debhelper-but-no-misc-depends which warns
      about missing misc:Depends if you use commands that might
      set it. Patch by Raphael Geissert. (Closes: #499737)
  * checks/fields:
    + [ADB] Ignore non-dependency fields when considering whether a
      versioned dependency is satisfied by the perl core packages.
      Based on a patch by Niko Tyni. (Closes: #500720)
    + [RA] Stop checking for a libmodule-build-perl build dependency since
      Module::Build now comes with Perl. Thanks, Raphael Hertzog.
      (Closes: #506697)
  * checks/files:
    + [ADB] Apply patches from Raphael Geissert to update the list of
      embedded PHP libraries:
      - Add detection for the Snoopy and GeSHi libraries and the use of
        phpmailer.inc (rather than .php).
      - Enable the libmarkdown-php check, as the package is now in unstable.
      - Add support for the (not currently packaged and thus disabled) IXR
        and kses libraries.
  * checks/infofiles:
    + [FL] Use $known_shells_regex from common_data.
  * checks/menus:
    + [FL] Use $known_shells_regex from common_data.
  * checks/patch-systems{,.desc}:
    + [ADB] Don't include dpatch comment lines containing no content
      when determining whether the patch includes a description.
      (Closes: #503695)
    + [ADB] Add missing "diffstat" to the Needs-Info field.
    + [ADB] Check whether quilt patches include a description.
      (Closes: #498892)
  * check/scripts:
    + [FL] Use $known_shells_regex from common_data.
    + [FL] Add icmake as a known interpreter as requested by
      Frank B. Brokken. (Closes: #505868)
  * checks/shared-libs{,.desc}:
    + [ADB] Don't issue both symbols-file-contains-debian-revision and
      symbols-file-contains-current-version-with-debian-revision for any
      given symbol, as the latter implies the former an...

Read more...

Changed in lintian:
status: Fix Committed → Fix Released
Adrien Cunin (adri2000)
Changed in lintian:
importance: Undecided → Unknown
status: New → Unknown
Changed in lintian (Debian):
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.