System Cleaner Has No Icon

Bug #274714 reported by nullack
52
This bug affects 5 people
Affects Status Importance Assigned to Milestone
system-cleaner (Ubuntu)
Fix Released
Low
Unassigned
Intrepid
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: system-cleaner-gtk

Once system cleaner is installed, it has no icon and defaults to the plain window type icon.

Also, why can't the start menu entry be located under / System / Administration? This is where for example the nvidia config app is installed too. By adding it to systems tools in applications it adds a whole new menu sub directory with only this app in the list. It increases the size of the app menu.

SUMMARY FOR SRU: system-cleaner-gtk has no icon in System -> Administration and in the window manager decorations. The icon is included in the source pacakge, but not the binary package. Fix is to include it in the .deb and .desktop.

PATCH: http://bazaar.launchpad.net/~systemcleaner-hackers/systemcleaner/intrepid-sru-1-proposal/changes (revision 109).

TEST CASE: Install fixed system-cleaner. Verify that it has an icon in the GNOME menu (System -> Administration) and in the window manager's window decoration.

Dean Loros (autocrosser)
Changed in system-cleaner:
status: New → Confirmed
Revision history for this message
to be removed (liw) wrote :

No icon: correct. I am awful at making icons, so I'm going to hope someone else makes one.

Menu entry location: I discussed this with one of the Canonical usability experts and was told it's not an acceptable location. In order for the app to be in the menus at all, Application/System is the only choice. It's not the only app there, there's a few other non-mainstream apps that go there as well, but since few people install more than one of them, it always looks like there's only one such app.

Revision history for this message
Colin Watson (cjwatson) wrote :

ubuntu-art@ should be able to help with an icon.

I'd be interested (for my own sake) in the reasoning you were given for System -> Administration being unacceptable; certainly if we install system-cleaner by default then it will look a bit curious.

Revision history for this message
to be removed (liw) wrote :

I was told that System -> Administration is too big already, and that we should strive to reduce its size rather than make it bigger. That's probably true, even if unfortunate for system-cleaner.

I am, of course, happy to move system-cleaner anywhere consensus dictates. It's just one line in .desktop, after all.

Revision history for this message
Tormod Volden (tormodvolden) wrote :

Since it's installed by default, it should absolutely have an icon, so I think the bug needs a higher importance and a milestone. And a fix. But unfortunately I can't help there.

Revision history for this message
Dean Loros (autocrosser) wrote :

Lars--I sent you a modified royalty-free image that I think would work....E me back if you like it or want it changed more.....

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I agree with Tormod that this needs an icon now it is installed by default, so I've milestoned it for 8.10 final.

Changed in system-cleaner:
importance: Undecided → Low
milestone: none → ubuntu-8.10
status: Confirmed → Triaged
Revision history for this message
to be removed (liw) wrote :

Dean, unfortunately "royalty-free" is not good enough. The image needs to have a license that explictly allows certain things. For example, the license must allow modification, and re-distribution of modified versions. Without a license, such things are not allowed.

http://www.ubuntu.com/community/ubuntustory/philosophy has some information on that.

Thus, unless such a license is found, I have to reject the icon.

Revision history for this message
to be removed (liw) wrote :

Tormod, I think I disagree with you: I don't think that an icon is at all necessary. It'd be nice, but that's all.

Revision history for this message
Dean Loros (autocrosser) wrote :

Take a look at the one I sent to Lars---

Revision history for this message
Dean Loros (autocrosser) wrote :

Sorry Lars--I am just trying to make something work--I'll scratch-design something tonight & sent it to you....

Revision history for this message
to be removed (liw) wrote :

Dean, thanks. I appreciate your effort. If it helps, my mental image of system-cleaner is a broom with a screwdriver at the other end. :)

Revision history for this message
Tormod Volden (tormodvolden) wrote :

Lars, it's probably not necessary for the functionality of the program :) But it's in the same league as a having a nice desktop background, usplash and compiz. All other menu entries (with the exception of the new usb-creator, known bug) have an icon.

Dean, nice icon. But it's maybe a little hard to see what it is when the icon is scaled down in the menu.

Revision history for this message
Dean Loros (autocrosser) wrote :

HMMMMM--broom with a screwdriver at the other end? Well, how about a broom with a screwdriver crossed on it?
take a look.....

Revision history for this message
Tormod Volden (tormodvolden) wrote :

Nice, but what about just the broom? Screwdrivers are for tweaking stuff...

Revision history for this message
to be removed (liw) wrote :

Broom for getting rid of dirt (unwanted packages). Screwdriver (or hammer?) for adjusting things (relatime).

Revision history for this message
to be removed (liw) wrote :

Dean, the screwdriver + broom looks good, at least in the default size. Does it scale down to menu icon size (whatever that is)? Would a hammer be more distinctive in the small size? Should it have a shaded background? I know little about icons.

Revision history for this message
Tormod Volden (tormodvolden) wrote :

I think icons are scaled depending on DPI or other settings, but typically the menu icons appear as 24x24. They should have a transparent background.

Revision history for this message
Dean Loros (autocrosser) wrote : Re: [Bug 274714] Re: System Cleaner Has No Icon

Hi Lars--
I'm using it my menu at 24x24 & looks good--Transparent blends with
various menu colours well--I added the gold lens flare to show a "golden
future" :) Do you want me to do a hammer? Also, is the Tango-like icon
style good?

Lars Wirzenius wrote:
> Dean, the screwdriver + broom looks good, at least in the default size.
> Does it scale down to menu icon size (whatever that is)? Would a hammer
> be more distinctive in the small size? Should it have a shaded
> background? I know little about icons.
>

Revision history for this message
Kenneth Wimer (kwwii) wrote :

Here are a few comments from an artist:

1) using the lens flare at the top left is a no-no as you do not know which background color the icon will appear on

2) the style of the icon should match the human icons (our default set). While a dark outline is probably still necessary the style if much different than tango

3) the comic representation is a bit too simplified in my honest opinion

4) you will need to make a separate png version for every small icon size. 24x24 is the typical menu size so that is the most important...but simply scaling an icon down does not work. You will need to watch out for line thickness and the angle at which the outer borders occur as they will not always raster well and will have a funky pixelized effect

Revision history for this message
Dean Loros (autocrosser) wrote :

Thanks for the comments--I have a little bit of time to play with things
like this--guess that I should leave it to the pros----

On 10/20/08, Kenneth Wimer <email address hidden> wrote:
>
> Here are a few comments from an artist:
>
> 1) using the lens flare at the top left is a no-no as you do not know
> which background color the icon will appear on
>
> 2) the style of the icon should match the human icons (our default set).
> While a dark outline is probably still necessary the style if much
> different than tango
>
> 3) the comic representation is a bit too simplified in my honest opinion
>
> 4) you will need to make a separate png version for every small icon
> size. 24x24 is the typical menu size so that is the most important...but
> simply scaling an icon down does not work. You will need to watch out
> for line thickness and the angle at which the outer borders occur as
> they will not always raster well and will have a funky pixelized effect
>
> --
> System Cleaner Has No Icon
> https://bugs.launchpad.net/bugs/274714
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
Ralf Nieuwenhuijsen (ralf-nieuwenhuijsen) wrote :

Please either:
 - just remove the package,
 - add one of the above attached icons, or use a stock one, and move it to the administration menu

If somebody thinks the administration menu is too big, let them create a nice proposal to clean it up. This belongs in the administration menu.

Example stuff that doesn't belong in Administration:
  - system monitor
  - create an usb startup disc
  - network tools

Just because some 'usability' guy says so, doesn't mean you have to listen to it. He/she is not here defending it. Please just change it; it looks out of place all by itself in that menu, and it doesn't belong their either. It's not a day-to-day tool. It's a system configuration tool. Compare with the three tools above.

Also, if that person was in charge over the menu's .. then either that person isn't consistent and isn't in their right mind, much more likely .. the person just doesn't really care, didn't bother to fix it, but still had a general opinion about the administration menu being too big. And now they wasted your and our time.

For the polish, the icon and menu position are release blockers. It's like a clean floor. People will always notice the biggest spot on the floor. This is the new biggest spot. The place that screams 'unfinished'.

That is not your fault. It seems it was added quite late to the release. So my advise, as a nobody:
  - just add an icon: ANY ICON
  - move it to the administration menu

Revision history for this message
Jonathan Ernst (jonathan.ernst) wrote :

Hi Ralf,

This bug is about the icon issue.

The other issues are handled elsewhere :

> move it to the administration menu
Bug #286458

> usb startup disk
Bug #285704 (misses an icon) and Bug #286924 (wrong menu item name) (I haven't reported the fact that it is in administration menu as I'm not so sure about it (as long as it requires a password)

> system monitor don't belong in Administration
Bug #286929

> network tools don't belong in Administration
Bug #286931

Best regards.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

I'll try to do something about that.. create a cool icon for the app.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Please check this icon =)

Revision history for this message
Biji (biji) wrote :

wow nice icon marco...

Revision history for this message
to be removed (liw) wrote :

Marco, that looks pretty nice. It might have too much detail for the default menu icon size of 24x24. Could you see if you can make a version in that size, too?

Revision history for this message
Marco Rodrigues (gothicx) wrote :

It looks very small =) hehe

Revision history for this message
to be removed (liw) wrote :

Marco, it does look very small. It is so small that it becomes hard to see what the icon shows. Perhaps it would work better with just the broom, at least in the small size?

Revision history for this message
Dmytro Korzhevin (korg) wrote :

So can you please link this icon to system-cleaner-gtk program in 8.10?

Revision history for this message
Marco Rodrigues (gothicx) wrote :

I'll do it with only the broom tomorrow at work. I don't have the photoshop version here..

Revision history for this message
Dean Loros (autocrosser) wrote :

I really like the box & broom idea--you could put a .deb on the side of the box :)

Revision history for this message
Marco Rodrigues (gothicx) wrote :
Revision history for this message
Tormod Volden (tormodvolden) wrote :

Marco, you get minus points for apparently uploading this from a Windows machine, and using Photoshop :)

Looks good. Compared to the other icons in the menus, I think it could have a stronger contrast and outline.

Revision history for this message
to be removed (liw) wrote :

Marco, thanks, that looks fine to me. We need a copyright license that makes it free software. Ideally the same license as the software uses: GPL3. Which license would you prefer?

Revision history for this message
Marco Rodrigues (gothicx) wrote :

I agree with GPL3. Go ahead =)

Revision history for this message
Luca Livraghi (luca91) wrote :

I gimped the icon. (I'm poor at that :D) That is how it will might look like.

Changed in system-cleaner:
assignee: nobody → didrocks
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Here is a debdiff taking the icon (and moving to system->administration) into account.

system-cleaner (1.10.3-0ubuntu2) intrepid; urgency=low

  * Add an icon to system-cleaner-gtk (LP: #274714)
    - uuencode this system-cleaner-gtk.png, add a uudecode instruction in
      debian/rules and add sharutils as a buildd in debian/control
    - using debian/system-cleaner-gtk.install
    - link it with data/system-cleaner-gtk.desktop
    - debian/copyright updated
    accordingly (LP: #274714)
  * data/system-cleaner-gtk.desktop: move it to Systems->Administration -
    thanks jernst - and add some French localization (LP: #286458)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Oupsss… a little mistake in the changelog. The right one is here:

system-cleaner (1.10.3-0ubuntu2) intrepid; urgency=low

  * Add an icon to system-cleaner-gtk (LP: #274714)
    - uuencode this system-cleaner-gtk.png, add a uudecode instruction in
      debian/rules and add sharutils as a buildd in debian/control
    - using debian/system-cleaner-gtk.install
    - link it with data/system-cleaner-gtk.desktop
    - debian/copyright updated accordingly
  * data/system-cleaner-gtk.desktop: move it to Systems->Administration -
    thanks jernst - and add some French localization (LP: #286458)

Revision history for this message
Daniel Holbach (dholbach) wrote : Unsubscribing Sponsors.

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

For your information, I asked Daniel to unsubscribe u-s-m as liw (upstream) will integrate the change in the new version that will be shipped in Intrepid.

Changed in system-cleaner:
assignee: didrocks → nobody
Revision history for this message
Said Babayev (phoenix49) wrote :

Cruft remover was removed from ubuntu-desktop package list, and won't be shipped with Ubuntu 8.10 by default.

Revision history for this message
to be removed (liw) wrote :

Said, it will be included in the release, just not installed by default.

The icon is not in the package, however. I'll fix that in an update later.

Revision history for this message
to be removed (liw) wrote :

I've made new packages available at

http://code.liw.fi/ubuntu/pool/main/s/system-cleaner/

that include the icon. I hope to get them uploaded as an SRU in the near future.

Changed in system-cleaner:
status: Triaged → Fix Committed
to be removed (liw)
description: updated
to be removed (liw)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in system-cleaner:
status: New → Fix Committed
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

This also affects Ubuntu 9.04 (Jaunty)

Revision history for this message
Duncan Hawthorne (duncan.hawthorne) wrote :

the system-cleaner package in intrepid-proposed works fine, and has the correct icon

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package system-cleaner - 1.10.4-0ubuntu2

---------------
system-cleaner (1.10.4-0ubuntu2) intrepid-proposed; urgency=low

  * The "viime tingan pakettilisäykset ovat huono idea" release.
  * Added Polish translation from Piotr Makowski. (LP: #290196)
  * The apt Packages list is now checked for sanity. (LP: #290024)
  * Icon is now shown in menu, and by the window manager.
    (LP: #274714)
  * The current kernel will now never be considered cruft.
    (LP: #285657)
  * Now asks user to confirm that they want to remove packages or remove
    other cruft. (LP: #285888)
  * Package short description is now shown in the user interface.
    (LP: #286394)
  * The GTK UI now shows column headers, so that it is clear what the
    tick column means. (No bug reported about this explicitly, but it
    has come up repeatedly.)
  * Support for whitelists in /etc/cruft-remover.d/*.whitelist added.
    See the cruft-remover(8) manual page for details. This can later be
    seeded with the most common third-party packages, until dpkg+apt
    get sufficient meta data to deal with this in a better way.
    (Does not quite close LP: 285746.)

 -- Lars Wirzenius <email address hidden> Fri, 07 Nov 2008 15:58:25 +0200

Changed in system-cleaner:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Copied intrepid-proposed update to jaunty.

Changed in system-cleaner:
status: Fix Committed → Fix Released
tags: added: iso-testing
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.