Consistent terminology

Bug #274845 reported by Wouter Stomp
2
Affects Status Importance Assigned to Milestone
jockey (Ubuntu)
Fix Released
Low
Martin Pitt
ubuntu-docs (Ubuntu)
Fix Released
Low
Matthew East

Bug Description

Several wordings are used throughout jockey and its help file:

Title bar: Hardware Drivers
Dialog: proprietary drivers
Help: Restricted drivers

Please make them consistent, especially jockey <-> help.

Tags: patch
Revision history for this message
Martin Pitt (pitti) wrote :

Help needs to be fixed in ubuntu-docs.

Changed in ubuntu-docs:
status: New → Triaged
Changed in jockey:
importance: Undecided → Low
status: New → Triaged
Connor Imes (ckimes)
Changed in ubuntu-docs:
importance: Undecided → Low
Revision history for this message
Matthew East (mdke) wrote :

Martin,

What approach do you want to take to resolving this bug? The current approach taken by the jockey UI is to name the program "Hardware Drivers" and to describe the drivers themselves as "proprietary drivers".

If that's what you want to preserve, we can certainly update the documentation to match this. I've attached a patch which I can commit to our karmic branch modifying "restricted" to "proprietary" in the documentation.

A further issue that arises is what to call "free" drivers in the document. In the patch, I've left the term "unrestricted", because I think it's clearer than "free", which is rather ambiguous as we all know.

Let me know the approach you want to take so that this can be consistent.

Changed in ubuntu-docs (Ubuntu):
assignee: nobody → mdke
Matthew East (mdke)
tags: added: patch
Revision history for this message
Martin Pitt (pitti) wrote :

Jockey itself only uses "free"/"proprietary" on individual driver descriptions (according to their license), and in the warning at the top if proprietary drivers are in use.

Your patch against ubuntu-docs looks good, thank you! That'll make the GUI and the help consistent.

Revision history for this message
Matthew East (mdke) wrote :

Thanks Martin. On that basis I've changed "unrestricted" to "free" where it appears in the help file as well. I'll attach a patch which I have pushed to the karmic ubuntu-docs branch.

While I was at it, for consistency I've changed some of the internal section ids in the document so that they don't use "restricted" either.

As a result for karmic you'll need to change the target for the help button, from "ghelp:hardware#restricted-manager" to "ghelp:hardware#jockey".

Let me know if that raises any issues and I'll revert it.

Changed in ubuntu-docs (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Matthew East (mdke) wrote :
Changed in jockey (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :
Changed in jockey (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-docs - 9.10.1

---------------
ubuntu-docs (9.10.1) karmic; urgency=low

  * [Matthew East]
    - First release for Karmic
    - Drastically shorten package build time by only building translated xml
      for translations that we are actually going to ship
    - hardware.xml - computer-janitor updates
    - Correction to PhotoEditor instructions - patch from Connor Ines - LP: #355008
    - photos.xml - import window opens automatically on f-spot first use, LP: #209530
    - Add introductory paragraph to seek to explain GNOME desktop - LP: #219972
    - Errors in musicvideophotos, patches from Artur Szymanski and Connor Imes - LP: #359288
    - Typos in desktop-effects.xml, patch from Connor Imes. LP: #357344
    - add missing apt: prefix to xchat-gnome installation link, LP: #356933
    - Update debian/control and debian/copyright - patch from Nathan Handler, LP: #363552
    - Grammar error in virtualization.xml, patch from Connor Imes. LP: #352313
    - Make language in jockey section consistent with language used in UI, LP: #274845
    - Add link to debian section on Ubuntu website, patch from Connor Imes, LP: #257337
  * [Bhuvaneswaran A]
    - serverguide/lamp-applications.xml - improvements to mediawiki instructions
    - serverguide/chat.xml - new section about chat server applications
    - improvements to exim section in serverguide/mail
  * [Dean Sas] - typo fix in serverguide/jeos

 -- Matthew East <email address hidden> Wed, 29 Apr 2009 00:23:20 +0100

Changed in ubuntu-docs (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jockey - 0.5.2-0ubuntu1

---------------
jockey (0.5.2-0ubuntu1) karmic; urgency=low

  * New upstream release 0.5.1:
    - Add yum detection to packaging_system.
    - Implement package installation/removal with PackageKit. (Not used in
      Ubuntu right now).
    - Fully functional on Fedora Core 10.
  * New upstream release 0.5.2:
    - Convert build system to DistUtilsExtra.auto.
    - kde/jockey-kde.desktop.in: Move autostart to phase 2, for smoother
      login. (LP: #369733)
    - ui.py: Make proprietary driver warning less scary. (LP: #381805)
    - jockey-gtk: port from glade to GtkBuilder.
  * debian/control: Bump python-distutils-extra build dependency to ensure
    availability of DistUtilsExtra.auto.
  * debian/control: Drop obsolete python-glade2 dependency.
  * debian/jockey-gtk.install: Install *.ui file instead of *.glade.
  * jockey/oslib.py, ui_help(): Update yelp location for help, thanks Matthew
    East! (LP: #274845)
  * data/handlers/broadcom_wl.py: Require package bcmwl-kernel-source. Drop
    our handling of the module blacklisting, bcmwl-kernel-source now does that
    by itself. (LP: #381678)
  * Move jockey.kdeui Python modules from jockey-common to jockey-kde.
  * debian/control: Drop obsolete restricted-manager-* conflicts/replaces.
  * debian/rules: Drop call to dh_icons, cdbs has done that for us for a long
    time.
  * debian/control: Bump Standards-Version to 3.8.2 (no changes necessary).
  * debian/control: Recommend bcmwl-modaliases, so that the driver is detected
    by default. (LP: #381683)

 -- Martin Pitt <email address hidden> Mon, 29 Jun 2009 16:21:37 +0200

Changed in jockey (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.