debchange --distributor option is nonfunctional (jaunty, intrepid-backports, hardy-backports)

Bug #296417 reported by Max Bowsher
6
Affects Status Importance Assigned to Milestone
Hardy Backports
Fix Released
Undecided
Martin Pitt
Intrepid Ibex Backports
Fix Released
Undecided
Martin Pitt
devscripts (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: devscripts

The debchange --distributor option is broken in devscripts 2.10.39ubuntu1 (which has been backported to both intrepid and hardy).

Here is a diff between 2.10.26ubuntu15 (intrepid) and 2.10.39ubuntu1~intrepid1 (intrepid-backports) showing that the code that sets the actual distributor variable from the command line value has apparently been inadvertently dropped:

@@ -381,9 +381,7 @@

 # See if we're Debian, Ubuntu or someone else, if we can
 my $distributor;
-if (defined $opt_distributor) {
- $distributor = $opt_distributor;
-} elsif (system('command -v lsb_release >/dev/null 2>&1') >> 8 == 0) {
+if (system('command -v lsb_release >/dev/null 2>&1') >> 8 == 0) {
     $distributor = `lsb_release -is 2>/dev/null`;
     chomp $distributor;
 }

Related branches

Revision history for this message
James Westby (james-w) wrote :

Hi Martin,

Could you take a look at this please?

Thanks,

James

Martin Pitt (pitti)
Changed in devscripts:
assignee: nobody → pitti
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Assuming -backporters ACK. I'll backport this as soon as the source got published.

Changed in intrepid-backports:
assignee: nobody → pitti
status: New → In Progress
Changed in hardy-backports:
assignee: nobody → pitti
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package devscripts - 2.10.39ubuntu2

---------------
devscripts (2.10.39ubuntu2) jaunty; urgency=low

  * scripts/debchange.pl: Re-add evaluation of --distributor option, which got
    inadvertently dropped during the merge. (LP: #296417)

 -- Martin Pitt <email address hidden> Tue, 11 Nov 2008 11:52:13 +0100

Changed in devscripts:
status: In Progress → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

 * Trying to backport devscripts...
  - <devscripts_2.10.39ubuntu2.dsc: downloading from librarian>
  - <devscripts_2.10.39ubuntu2.tar.gz: downloading from librarian>
I: Extracting devscripts_2.10.39ubuntu2.dsc ... done.
I: Building backport of devscripts-2.10.39ubuntu2 as 2.10.39ubuntu2~intrepid1 ... done.

Changed in intrepid-backports:
status: In Progress → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

 * Trying to backport devscripts...
  - <devscripts_2.10.39ubuntu2.dsc: downloading from librarian>
  - <devscripts_2.10.39ubuntu2.tar.gz: downloading from librarian>
I: Extracting devscripts_2.10.39ubuntu2.dsc ... done.
I: Building backport of devscripts-2.10.39ubuntu2 as 2.10.39ubuntu2~hardy1 ... done.

Changed in hardy-backports:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.