running overkill crashes (buffer overflow) (running in gnome-terminal)

Bug #297913 reported by Arnaud Soyez
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
overkill (Ubuntu)
Fix Released
Undecided
David Futcher

Bug Description

Binary package hint: overkill

I just installed Overkill, and i ran overkill in a gnome-terminal. And i get a buffer overflow error.
See the attached file for the log. I've put the normal log output from overkill, and a strace. I tried gdb but didn't work as there are no symbols in overkill file.

Note that xoverkill does work.

gnome-terminal:
  Installé : 2.24.1.1-0ubuntu1
  Candidat : 2.24.1.1-0ubuntu1

Release: 8.10
Codename: intrepid

overkill:
  Installé : 0.16-13
  Candidat : 0.16-13

Revision history for this message
Arnaud Soyez (weboide) wrote :
Revision history for this message
Arnaud Soyez (weboide) wrote :
Revision history for this message
Arnaud Soyez (weboide) wrote :

And i get a buffer overflow after a little while running the server and playing. This may be related.

Revision history for this message
Jannich Brendle (jannich-bredsaal) wrote :

The problem was in console.c - the code tried to copy 16 bytes into a 8 byte array.

I attached a patch.

David Futcher (bobbo)
Changed in overkill (Ubuntu):
assignee: nobody → David Futcher (bobbo)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package overkill - 0.16-13ubuntu1

---------------
overkill (0.16-13ubuntu1) karmic; urgency=low

  * Add dpatch patchsys:
    - debian/control: Add build-dependency on dpatch
    - debian/rules: Update for dpatch
    - Add debian/patches directory
  * Apply patches to fix four crashing bugs. All patches thanks to Jannich Brendle:
    - ubuntu_01_server_action_crash.dpatch: Patch to fix overkill-server crashes
      when anything happens in the game (LP: #406046)
    - ubuntu_02_overkill-test-server_segfault.dpatch: Patch to fix segfault in
      overkill-test-server due to invalid memory allocation (LP: #406000)
    - ubuntu_03_chat_buffer_overflow.dpatch: Patch to fix buffer overflow when
      sending chat messages over the specified limit (LP: #408557)
    - ubuntu_04_console.c_segfault.dpatch: Patch to fix overkill crashing on
      startup due to the code trying to copy 16 bytes into a 8 byte array (LP: #297913)

 -- David Futcher <email address hidden> Sun, 09 Aug 2009 13:42:27 +0100

Changed in overkill (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.