pidgin doen't show OS version via XMPP

Bug #306923 reported by -
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Pidgin
Invalid
Undecided
Unassigned
pidgin (Ubuntu)
Confirmed
Undecided
Aditya V

Bug Description

Binary package hint: pidgin

Pidgin doen't show OS version via XMPP

Version request:
<iq to="*****" type="get" id="372">
<query xmlns="jabber:iq:version" />
</iq>

Answer from pidgin user:
<iq from='*****' to='*****' type='result' id='372'>
<query xmlns='jabber:iq:version'>
<name>Pidgin</name>
<version>2.5.2 (libpurple 2.5.2)</version>
</query>
</iq>

It show only client version and doens't show OS version.

Tags: patch
Revision history for this message
goto (gotolaunchpad) wrote :

I can confirm this. Using Intrepid.
This would be a good feature, but if it gets implemented, then make an option so that one can disable it. I think this should be wishlist. Thanks.

Changed in pidgin:
status: New → Confirmed
Revision history for this message
spo1ler (splrdhc) wrote :

It corrects very simple just by adding one #ifndef and uncommenting one-two lines of code.

Revision history for this message
- (lucky+-deactivatedaccount) wrote :

Here is the simple patch.

Revision history for this message
xandry (avm-xandry) wrote :

This bug have on pidgin 2.6.6. Patch does not work correctly:
$ patch -p0 < pidgin-version.patch
patching file libpurple/protocols/jabber/iq.c
Hunk #1 succeeded at 220 with fuzz 1 (offset -34 lines).
Hunk #2 FAILED at 263.
Hunk #3 succeeded at 255 (offset -35 lines).
1 out of 3 hunks FAILED -- saving rejects to file libpurple/protocols/jabber/iq.c.rej

Nigel Babu (nigelbabu)
tags: added: patch-needswork
Changed in pidgin:
status: New → Invalid
Revision history for this message
Aditya V (kroq-gar78) wrote :

OK. I think I fixed the patch (just manually applied it by hand), but can someone check it for me? Thanks in advance! I'll link my branch, too. I'm not sure how to test this, so I'm not going to set this for merging.

Changed in pidgin (Ubuntu):
assignee: nobody → kroq-gar78 (kroq-gar78)
status: Confirmed → In Progress
Aditya V (kroq-gar78)
tags: added: patch
removed: patch-needswork
Aditya V (kroq-gar78)
Changed in pidgin (Ubuntu):
status: In Progress → Confirmed
Revision history for this message
Aditya V (kroq-gar78) wrote :

OK how do I test this?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.