pidgin-libnotify shouldn't use notifications with actions

couldn't we make the show button dependent on whether "actions" are supported by notification system or not?

Yes, of course it should detect. I built the patch to also include the libindicate changes for the messaging indicator, though now I'm thinking that they should perhaps be split into a separate plugin. While there is overlap in the functionality it results is a larger patch, and some autoconf changes as well.

Sebastien, please review.

thanks for your work Ted, that would be nice to split the changes right and to use a patch system rather than directly changing the source. could you also open a bug upstream about not using actions in notification?

extra comments:
- could you summarize the changes in one changelog entry?
- do you need to enable the debug option in jaunty?
- could you describe how to test the change?

Here is and updated patch.

There are two ways to test the change. One, there should be no notifications when using a notification daemon that doesn't support it. An example of that should be the notification daemon that is currently in Jaunty. Also, Pidgin should show up on the messaging indicator if this plugin is enabled.

Woah, there should be "no actions on notifications" a notification daemon that doesn't support notifications... there's a good idea :)

Upstream at: https://sourceforge.net/tracker/index.php?func=detail&aid=2614312&group_id=144907&atid=760301

thank you for your update, could you split the change in code change and autotools update as it's done for other desktopish component? once that done the patch seems good to be uploaded.
would be nice to follow https://wiki.ubuntu.com/UbuntuDevelopment/PatchTaggingGuidelines too to describe the change

Oh, fail. Forgot that Quilt only does patches at -p1. I so dislike that patch system.

This bug was fixed in the package pidgin-libnotify - 0.14-1ubuntu1

---------------
pidgin-libnotify (0.14-1ubuntu1) jaunty; urgency=low

  * Cleanup the changes and upload to jaunty
  [ Ted Gould ]
  * debian/control: Adding in libindicate as a dependency.
  * Adding debian/patches/indicate.patch: (LP: #328600)
    * Adds libindicate as a dependency with all the build
      changes that would be expected from that.
    * Makes pidgin an indicate server of the time messages.im and
      sets up indicators for every IM message that is unread
    * Makes the pidgin notifications check for actions being
      supported by the notification daemon and doesn't use them
      if they are not.
    * Checks for support in the notification daemon for appending
      notifications and adds append hints if they are supported.
    * Checks to see if the conversation is in focus, if so it does
      send notifications about that conversation.
  * Adding debian/patches/indicate-autotools.patch changes to built
    files from above patch.

 -- Sebastien Bacher <email address hidden> Thu, 19 Feb 2009 14:09:23 +0100