weather.py crashed with TypeError in onBarHeightChange()

Thanks for your bug report.
Forwarded upstream.

Interesting, I'll take a look at this tomorrow! Perhaps I (poorly) assumed
that there were cached conditions when resizing. It probably just needs an
"if self.cachedConditions:" before that.

yeah maybe that could be the reason. Anyways my dock just crashed and i cannot used it again. Its like i cant see the current open windows, its like if my dock just got "disconected " from my system.

> Date: Mon, 6 Apr 2009 07:19:33 +0000
> From: <email address hidden>
> To: <email address hidden>
> Subject: Re: [Bug 350383] [NEW] weather.py crashed with TypeError in onBarHeightChange()
>
> Interesting, I'll take a look at this tomorrow! Perhaps I (poorly) assumed
> that there were cached conditions when resizing. It probably just needs an
> "if self.cachedConditions:" before that.
>
> --
> weather.py crashed with TypeError in onBarHeightChange()
> https://bugs.launchpad.net/bugs/350383
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Awn Extras: New
> Status in “awn-extras-applets” source package in Ubuntu: New
>
> Bug description:
> weather.py is crashing when the height of the bar is changed in awn settings
>
> ProblemType: Crash
> Architecture: i386
> DistroRelease: Ubuntu 9.04
> ExecutablePath: /usr/share/avant-window-navigator/applets/weather/weather.py
> InterpreterPath: /usr/bin/python2.6
> NonfreeKernelModules: ath_hal
> Package: awn-applets-python-core 0.3.2.1-0ubuntu2
> PackageArchitecture: all
> ProcCmdline: python /usr/share/avant-window-navigator/applets/weather/weather.py --uid=1229291929 --window=35651642 --orient=0 --height=48
> ProcEnviron:
> LANG=de_DE.UTF-8
> SHELL=/usr/bin/zsh
> PythonArgs: ['/usr/share/avant-window-navigator/applets/weather/weather.py', '--uid=1229291929', '--window=35651642', '--orient=0', '--height=48']
> SourcePackage: awn-extras-applets
> Title: weather.py crashed with TypeError in onBarHeightChange()
> Traceback:
> Traceback (most recent call last):
> File "/usr/share/avant-window-navigator/applets/weather/weather.py", line 151, in onBarHeightChange
> self.setIcon(self.cachedConditions['CODE'])
> TypeError: 'NoneType' object is unsubscriptable
> Uname: Linux 2.6.28-11-generic i686
> UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

_________________________________________________________________
Drag n’ drop—Get easy photo sharing with Windows Live™ Photos.

http://www.microsoft.com/windows/windowslive/products/photos.aspx

Wolf, did you notice whether the weather.py crash happened when you had
weather data or not? Did you see the weather.com logo or actual conditions
in the dock?

I belive i was offline on that moment so i guess that means i had no data. The only data i put in was my current location (Guápiles, Costa Rica). When it was working i saw the conditions logo. When i lost conection i only had the "The Weather Channel" logo, the only way to see the condition was clicking on it. That's all i can remember, sorry.

> Date: Mon, 6 Apr 2009 07:57:54 +0000
> From: <email address hidden>
> To: <email address hidden>
> Subject: Re: [Bug 350383] [NEW] weather.py crashed with TypeError in onBarHeightChange()
>
> Wolf, did you notice whether the weather.py crash happened when you had
> weather data or not? Did you see the weather.com logo or actual conditions
> in the dock?
>
> --
> weather.py crashed with TypeError in onBarHeightChange()
> https://bugs.launchpad.net/bugs/350383
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Awn Extras: New
> Status in “awn-extras-applets” source package in Ubuntu: New
>
> Bug description:
> weather.py is crashing when the height of the bar is changed in awn settings
>
> ProblemType: Crash
> Architecture: i386
> DistroRelease: Ubuntu 9.04
> ExecutablePath: /usr/share/avant-window-navigator/applets/weather/weather.py
> InterpreterPath: /usr/bin/python2.6
> NonfreeKernelModules: ath_hal
> Package: awn-applets-python-core 0.3.2.1-0ubuntu2
> PackageArchitecture: all
> ProcCmdline: python /usr/share/avant-window-navigator/applets/weather/weather.py --uid=1229291929 --window=35651642 --orient=0 --height=48
> ProcEnviron:
> LANG=de_DE.UTF-8
> SHELL=/usr/bin/zsh
> PythonArgs: ['/usr/share/avant-window-navigator/applets/weather/weather.py', '--uid=1229291929', '--window=35651642', '--orient=0', '--height=48']
> SourcePackage: awn-extras-applets
> Title: weather.py crashed with TypeError in onBarHeightChange()
> Traceback:
> Traceback (most recent call last):
> File "/usr/share/avant-window-navigator/applets/weather/weather.py", line 151, in onBarHeightChange
> self.setIcon(self.cachedConditions['CODE'])
> TypeError: 'NoneType' object is unsubscriptable
> Uname: Linux 2.6.28-11-generic i686
> UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

_________________________________________________________________
More than messages–check out the rest of the Windows Live™.
http://www.microsoft.com/windows/windowslive/

Onox fixed it in the rewrite, should that commit be merged into 3.2?

I'll merge this fix into trunk and 0.3.2.2.

On a more thorough examination of the commit in question, I cannot merge the revision due to it being too invasive. (This is a good time to mention that developers should not commit more than one fix per revision unless necessary, for this very reason.)

I'm just going to add "if self.cachedConditions is not None and 'CODE' in self.cachedConditions:" to the method in question.

Yes, that should be a fine fix!

Fix committed in trunk r1165 and 0.3.2.2 r1112. I'm building a trunk PPA package shortly.

Fix released in Awn Extras 0.3.2.2.

This bug was fixed in the package awn-extras-applets - 0.3.2.2-2

---------------
awn-extras-applets (0.3.2.2-2) unstable; urgency=low

  * debian/control:
   - Depends on python-awnlib (>= 0.3.2.2) and python-awn-extras (>= 0.3.2.2),
     first version build with python-support, to avoid breakage on partial
     upgrade.
     Closes: #534665, #534666
   - Bump Standards-Version to 3.8.2 (no change needed).
   - Fix comma in depends field.

awn-extras-applets (0.3.2.2-1) unstable; urgency=low

  * New Upstream Version (LP: #344874, #350383).
  * debian/rules:
   - Rewrite to use python-support and debhelper v7.
   - Add quilt support.
  * debian/compat:
   - Bump to 7.
  * debian/control:
   - Bump debhelper build-depends to (>= 7).
   - Drop build-depends on cdbs.
   - Add missing ${misc:Depends} for python-awnlib.
   - Bump Standards-Version to 3.8.1.
   - Following the split of python-gnome2-desktop, replace the recommends
     by python-rsvg | python-gnome2-desktop.
   - Remove useless "section" field.
   - Add VCS fields.
   - Bump depends for python-awn to >= 0.3.2.1, to force the depends on the
     1st version build with python-support.
   - Add build-depends on quilt.
   - Remove X{B,S}-Python-Version.
  * debian/patches: Convert to use quilt.
  * debian/python-awnlib.preinst:
   - add maintainer scripts to clean after pycentral.
  * Add debian/pyversions and remove debian/pycompat

awn-extras-applets (0.3.2.1-1) unstable; urgency=low

  * New upstream release.
   - Applets added : notification-area, animal farm.
   - Applets removed : cairo-menu classic, switcher, tsclient.
  * debian/control:
   - Update with new applets.
   - Add Recommends on hal instead of acpi because new battery-applet use it
     now (Closes: #510018).
   - Bump valac Build-Depends to (>= 0.5.4)
   - Add python-dateutil and libgweather-common as Recommends for cairo-clock.
   - Add gnome-applets as Recommends for cpufreq applet.
   - Add fortune as Recommends for animal-farm.
   - Bump python-awnlib version to 0.3.2.
   - Remove Recommends for tsclient, the applet was removed.
   - Remove libtrackerclient as Build-Depends, the affinity applet was removed.
   - Replace python2.5 by python (>= 2.5).
   - Drop libawn-extras0 depends, handle by debian/rules.
  * debian/patches
   - 01-hardcode-icon-location.patch: Remove, fixed upstream.
   - 02-shinyswitcher-default-layout : Set the layout to 4x1 workspaces by
     default, and applet's size to 80% of the bar.
   - 10-implicit-pointer-conversion.patch: Removed, the affinity applet was
     removed.
   - 99-gnomeui-CFLAGS.patch: Remove, fixed upstream.
  * debian/rules
   - Add libawn-extras0 as a shlibs.
   - Add exclude=* to dh_makeshlibs to remove useless shlibs file.
  * debian/copyright
   - Update with new applets.
   - Replace (C) by ©
  * debian/*.install:
   - Update with new and removed applets.

 -- Michael Terry <email address hidden> Thu, 02 Jul 2009 06:08:57 +0100