summary/title text passed to notify-osd contains HTML-character-references

Bug #356147 reported by Mirco Müller
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
pidgin-libnotify (Ubuntu)
Fix Released
Undecided
Cody Russell

Bug Description

Binary package hint: pidgin-libnotify

A buddy's user-name like: Joe "User" Doe, gets passed to notify-osd like: Joe "User" Doe. Since notify-osd does not - by design - filter/parse the summary- or title-text this latter string shows up in the notification as is. libnotify-pidgin should process the summary-text itself and pass the correct string to the notification-daemon without any HTML-character-references.

Mirco Müller (macslow)
Changed in pidgin-libnotify (Ubuntu):
assignee: nobody → bratsche
status: New → Confirmed
Revision history for this message
Cody Russell (bratsche) wrote :
Cody Russell (bratsche)
Changed in pidgin-libnotify (Ubuntu):
status: Confirmed → In Progress
tags: added: dxteam notifications
Revision history for this message
Ted Gould (ted) wrote :

Isn't this caused by the call to "g_markup_escape_text"? Shouldn't we either just not call that?

http://library.gnome.org/devel/glib/stable/glib-Simple-XML-Subset-Parser.html#g-markup-escape-text

Revision history for this message
Cody Russell (bratsche) wrote :
Revision history for this message
Ted Gould (ted) wrote :

Debdiff for this and a few other patches. All together to make some pidgin-libnotify goodness.

idgin-libnotify (0.14-1ubuntu8) UNRELEASED; urgency=low

  * /debian/patches/indicate.patch:
    * Putting the notifications for a particular conversation
      into a list and closing the entire list when the
      conversation is focused to clear out possible queued
      notifications (LP: #351670)
    * Making it so that indicators and notifications from chats
      also wait from indicating for notifing when the account
      has just connected.
    * Do not make headers have protected ampersands and other HTML-isms
      in the strings. Patch by Cody Russell. (LP: #356147)
    * Use the libindicate interests interface to determine when there
      is someone looking at pidgin with the ability to control visibility
      of the application. Control it if so. (LP: #353112)
    * Change it so that the buddy information is stored in the callback
      instead of user data. Merging in show_button.patch.
  * /debian/control: libindicate 0.1.5
  * /debian/patches/show_button.patch: Moved into indicate.patch

 -- Ted Gould <email address hidden> Tue, 31 Mar 2009 08:23:33 -0500

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks for the work guys

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pidgin-libnotify - 0.14-1ubuntu8

---------------
pidgin-libnotify (0.14-1ubuntu8) jaunty; urgency=low

  * /debian/patches/indicate.patch:
    * Putting the notifications for a particular conversation
      into a list and closing the entire list when the
      conversation is focused to clear out possible queued
      notifications (LP: #351670)
    * Making it so that indicators and notifications from chats
      also wait from indicating for notifing when the account
      has just connected.
    * Do not make headers have protected ampersands and other HTML-isms
      in the strings. Patch by Cody Russell. (LP: #356147)
    * Use the libindicate interests interface to determine when there
      is someone looking at pidgin with the ability to control visibility
      of the application. Control it if so. (LP: #353112)
    * Change it so that the buddy information is stored in the callback
      instead of user data. Merging in show_button.patch.
  * /debian/control: libindicate 0.1.5
  * /debian/patches/show_button.patch: Moved into indicate.patch

 -- Ted Gould <email address hidden> Tue, 31 Mar 2009 08:23:33 -0500

Changed in pidgin-libnotify (Ubuntu):
status: In Progress → Fix Released
Cody Russell (bratsche)
Changed in pidgin-libnotify (Ubuntu):
status: Fix Released → New
Cody Russell (bratsche)
Changed in pidgin-libnotify (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.