Please merge min12xxw 0.0.9-2 (universe) from Debian unstable (main)

min12xxw (0.0.9-2ubuntu1) karmic; urgency=low

  * Merge from debian unstable, remaining changes (LP: #384653):
    - debian/local/apport-hook.py, debian/rules:
      + add apport hook

 -- Nick Ellery <email address hidden> Sun, 07 Jun 2009 17:12:06 -0700

Hi Nick,

Am Monday 08 June 2009 02:17:12 schrieb Nick Ellery:
> min12xxw (0.0.9-2ubuntu1) karmic; urgency=low
>
> * Merge from debian unstable, remaining changes (LP: #384653):
> - debian/local/apport-hook.py, debian/rules:
> + add apport hook

just took a glimpse at the debdiff:
* we don't have foomatic-filters-ppds in Ubuntu, that recommends needs to get
adjusted
* please either drop the apport hook (min12xxw didn't recieve any bug reports
where it would matter since its existence, so it's not of too much help for
*this* package) or add it to debian/copyright.

Thanks,
      Stefan.

Here's the updated debdiff. I dropped the recommends on foomatic-filters-ppds, and chose to remove the apport hook as there doesn't seem to be much of a reason to keep it.

Hi Nick,

Am Tuesday 09 June 2009 01:22:57 schrieb Nick Ellery:
> Here's the updated debdiff. I dropped the recommends on foomatic-
> filters-ppds, and chose to remove the apport hook as there doesn't seem
> to be much of a reason to keep it.

thanks, that looks good!
I'll upload it once the alpha is out.

Cheers,
    Stefan.

Please leave the Apport hook in, I have added it to all printer driver packages, also to the less frequently used ones. We should not drop a feature only because it needs a line in the debian/copyright file.

The Apport hook is part of the packaging, so it should be enough if the copyright file tells about the license of the packaging (which is GPL). The Apport hook file has also a clear copyright notice:

(c) 2009 Canonical Ltd.
Author: Brian Murray <email address hidden>

So leave the Apport hook in.

Stefan, note also that I have dropped the upstream package foomatic-filters-ppds with the release of Foomatic 4.0.x. So it should be removed from Debian and not be recommended or even required by any other package. The packages which replace foomatic-filters-ppds are foomatic-db, foomatic-db-engine, and foomatic-filters. With the first two installed CUPS auto-generates the PPDs needed for this driver, the third provides the foomatic-rip filter.

If you want to continue to have a foomatic-filters-ppds package in Debian, especially for users of non-CUPS printing systems, do the following:

- Let foomatic-filters-ppds build-depend on foomatic-db and foomatic-db-engine
- Let foomatic-filters-ppds pre-build all PPDs at build time using the foomatic-compiledb command.
- Let the foomatic-filters-ppds binary package depend on foomatic-filters

Do not let any package exclusively suggest, recommend, or even require foomatic-filters-ppds, as many users want to have the PPD auto-generation concept of CUPS as it saves a lot of disk space. Let it suggest, recommend, or require

(foomatic-db AND foomatic-db-engine AND foomatic-filters) OR foomatic-filters-ppds

Hi Till,

Am Wednesday 10 June 2009 10:30:46 schrieb Till Kamppeter:
> Stefan, note also that I have dropped the upstream package foomatic-
> filters-ppds with the release of Foomatic 4.0.x. So it should be removed
> from Debian and not be recommended or even required by any other
> package. The packages which replace foomatic-filters-ppds are foomatic-
> db, foomatic-db-engine, and foomatic-filters. With the first two
> installed CUPS auto-generates the PPDs needed for this driver, the third
> provides the foomatic-rip filter.

Thanks for the info!

Sadly, for lenny the autogenerated PPDs didn't autodetect min12xxw supported
printers, that's the reason for the recommends on foomatic-filters-ppds.
However I didn't dig further why this wasn't working back then.

If it turns out that this problem is gone nowadays, we could go back in sync,
what do you think?

Cheers,
   Stefan.

On up-to-date Karmic I get

till@till-laptop:~/ghostscript/gpl/testfiles$ lpinfo -m | grep min12xxw | grep foomatic:
foomatic:Minolta-PagePro_1200W-min12xxw.ppd Minolta PagePro 1200W Foomatic/min12xxw (recommended)
foomatic:Minolta-PagePro_1250W-min12xxw.ppd Minolta PagePro 1250W Foomatic/min12xxw (recommended)
foomatic:Minolta-PagePro_1300W-min12xxw.ppd Minolta PagePro 1300W Foomatic/min12xxw (recommended)
foomatic:Minolta-PagePro_1350W-min12xxw.ppd Minolta PagePro 1350W Foomatic/min12xxw (recommended)
foomatic:Minolta-PagePro_1400W-min12xxw.ppd Minolta PagePro 1400W Foomatic/min12xxw (recommended)
till@till-laptop:~/ghostscript/gpl/testfiles$

So Foomatic is able to autogenerate the PPD files for the "min12xxw" driver. If you do not get the same result under Debian, there is something broken in Debian's packaging of Foomatic. The Foomatic data for this driver exists already for a long time, so even older versions of Foomatic should generate these PPDs.

Hi,

I'll re-add the apport hook, however I am not aware of what needs to be added to debian/copyright. Could you clarify this for me?

Thanks,
Nick

Hi Nick,

a line like this will do:
debian/local/apport-hook.py: Coypright (c) 2009 Canonical Ltd. / Brian Murray.

either to the "Except:" section or you add an "Except: " below "Packaging".

Cheers,
    Stefan.

Thanks. Here's the updated debdiff. Two things I noticed, though.
- I added Brian Murray for the new copyright line as you showed for an example, however in debian/local/apport-hook.py, the name is listed as an author rather than a Copyright. Is it still right to list the name in debian/copyright?
- You are currently listed as the Ubuntu maintainer. Should it be updated to core-dev, or kept under your name?

Hi Nick,

Am Saturday 13 June 2009 19:30:02 schrieb Nick Ellery:
> Thanks. Here's the updated debdiff. Two things I noticed, though.
> - I added Brian Murray for the new copyright line as you showed for an
> example, however in debian/local/apport-hook.py, the name is listed as an
> author rather than a Copyright. Is it still right to list the name in
> debian/copyright?

It's certainly not wrong to list the author as well - or other information -
in the copyright file. If you think it's not clear enough, who's the
copyright holder / who's the author, you can of course always be more
verbose, or alternately you can only list the copyright holder.

> - You are currently listed as the Ubuntu maintainer.
> Should it be updated to core-dev, or kept under your name?

Please keep it as is ;).

I'll do a test-build now and a print a test page, if everything's good, I'll
upload it.

Cheers,
    Stefan.

This bug was fixed in the package min12xxw - 0.0.9-2ubuntu1

---------------
min12xxw (0.0.9-2ubuntu1) karmic; urgency=low

  * Merge from debian unstable, remaining changes (LP: #384653):
    - debian/local/apport-hook.py, debian/rules: Added apport hook
    - debian/control: Don't recommend foomatic-filters-ppds as it is not in
      Ubuntu
  * debian/copyright: Add copyright for apport hook

min12xxw (0.0.9-2) unstable; urgency=low

  * debian/control:
    - update Recommends for renamed cups packages (patch from Ubuntu, thanks
      Till Kamppeter).
    - still recommend on foomatic-filters-ppds (the ppds for the supported
      printers are in there)
    - add Homepage field
    - add VCS-fields
    - bump standards version to 3.8.0
    - add automake to build-depends
  * debian/rules:
    - reformat a little to not exceed 80 chars for readability
    - don't ignore errors on make distclean
    - bootstrap from autotools
  * debian/esc-m.1: add a space before the intial dash
  * debian/copyright:
    - mention getopt.c, getopt1.c getopt.h as well
    - add information, that the packaging is licensed as GPL-2+ as well
  * Makefile.am: don't compile getopt.c, getopt1.c (already provided by libc)

 -- Nick Ellery <email address hidden> Sat, 13 Jun 2009 10:08:07 -0700