Ubuntu
osm-gps-map package

osmgpsmap python bindings placed in site-packages rather than dist-packages

Bug #387043 reported by Andrew Gee
28
This bug affects 2 people
Affects Status Importance Assigned to Milestone
osm-gps-map (Ubuntu)
Fix Released
Undecided
Unassigned
Jaunty
Fix Released
Undecided
Unassigned

Bug Description

During the jaunty development cycle, the transition was made from site-packages in python, to dist-packages. The configure script in the python-osmgpsmap didn't pick up the right location, until I just fixed this in a patch. However this is not available in jaunty. So when a user tries to use the module, they are told it cannot be found.

==Solution==
The bug was addressed in the development version by modifying the python/configure and python/aclocal.m4 files in the package, using a patch. The script now picks up the correct location for the python modules.

==Test Case==
TEST CASE: Using a python prompt, typing "import osmgpsmap" doesn't produce any errors.

TEST CASE: Alternatively, use this script, execute it, and observe the map loading. http://andrewgee.org/stuff/osmgpsmaptest.sh

See original description
Revision history for this message
Andrew Gee (andrewgee) wrote :

Creating a debdiff with a new changelog entry...

Changed in osm-gps-map (Ubuntu):
assignee: nobody → Andrew Gee (andrewgee)
status: New → In Progress
Revision history for this message
Andrew Gee (andrewgee) wrote :

Attaching debdiff of new changelog entry, ready to rebuild

Changed in osm-gps-map (Ubuntu):
assignee: Andrew Gee (andrewgee) → nobody
status: In Progress → Fix Committed
Revision history for this message
Andrew Gee (andrewgee) wrote :

Found that a rebuild doesn't actually solve the problem. Will look into it further, soon.

Changed in osm-gps-map (Ubuntu):
assignee: nobody → Andrew Gee (andrewgee)
status: Fix Committed → Confirmed
Revision history for this message
Nick Ellery (nick.ellery) wrote :

Unsubscribing sponsors for now, please re-subscribe when ready.

Andrew Gee (andrewgee)
summary: - [jaunty] Python bindings are still built against 2.5 rather than 2.6
+ [jaunty] Python bindings placed in wrong directory
Revision history for this message
Andrew Gee (andrewgee) wrote :

After investigation, it was found the the configure script was locating the directory for the python modules incorrectly. A quick fix solved this issue.

Attached debdiff.

Andrew Gee (andrewgee)
Changed in osm-gps-map (Ubuntu):
assignee: Andrew Gee (andrewgee) → nobody
status: Confirmed → Fix Committed
Revision history for this message
Andrew Gee (andrewgee) wrote : Re: [jaunty] Python bindings placed in wrong directory

Quick fix to the patch

Changed in osm-gps-map (Ubuntu):
status: Fix Committed → Confirmed
Revision history for this message
Daniel Holbach (dholbach) wrote :

A few things:
 - can you target 'karmic' in debian/changelog instead of 'jaunty'?
 - can you add (LP: #387043) to the changelog entry?
 - do you think it'd make sense to fix python/aclocal.m4 in one patch (that you could send upstream) and configure in a second patch? that would have the advantage that in a new release, when some bits change in configure (almost inevitable), you don't need to fix configure manually :-)

Revision history for this message
Andrew Gee (andrewgee) wrote :

Working on the feedback

Changed in osm-gps-map (Ubuntu):
assignee: nobody → Andrew Gee (andrewgee)
status: Confirmed → In Progress
Revision history for this message
Andrew Gee (andrewgee) wrote :

Problems with the patch have been fixed.

Patch attached.

Thanks Daniel Holbach!

Changed in osm-gps-map (Ubuntu):
assignee: Andrew Gee (andrewgee) → nobody
status: In Progress → Confirmed
Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package osm-gps-map - 0.2-0ubuntu2

---------------
osm-gps-map (0.2-0ubuntu2) karmic; urgency=low

  * Two patches to fix python module locations (LP: #387043)
    * 01_correct-python-package-location-configure.dpatch
      This patch fixes the configure script that was distributed from upstream
      so that the python directories are detected correctly
    * 02_correct-python-package-location-aclocal.dpatch
      This patch fixes the aclocal file, for the same reason as the configure
      script.

 -- Andrew Gee <email address hidden> Wed, 01 Jul 2009 02:17:30 +0100

Changed in osm-gps-map (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Andrew Gee (andrewgee) wrote :

A minimal patch for the stable jaunty release of osm-gps-map is attached

description: updated
summary: - [jaunty] Python bindings placed in wrong directory
+ osmgpsmap python bindings placed in site-packages rather than dist-
+ packages
Revision history for this message
Julien Lavergne (gilir) wrote :

Thanks for your work. Some comments :
- the release should be jaunty-proposed because it should be uploaded to jaunty-proposed for testing before.
- the version should be 0.2-0ubuntu1.1 because it's a SRU.
- also, you need motu-sru ACK before uploading (see https://wiki.ubuntu.com/StableReleaseUpdates#Procedure). I unsubscribe ubuntu-universe-sponsors for now, please re-subscribe when motu-sru is OK.

Revision history for this message
Andrew Gee (andrewgee) wrote :

New patch with corrections

Revision history for this message
John Dong (jdong) wrote :

ACK from MOTU-SRU -- proceed to get your debdiff uploaded to jaunty-proposed.

Thanks!

P.S. For future reference, it's generally not encouraged to add a patchsys as a part of a SRU.

Revision history for this message
Benjamin Drung (bdrung) wrote :

This bug report dropped from the sponsor's radar. It's uploaded now.

Revision history for this message
Scott Kitterman (kitterman) wrote : Please test proposed package

Accepted into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Changed in osm-gps-map (Ubuntu Jaunty):
status: New → Fix Committed
Revision history for this message
Scott Kitterman (kitterman) wrote :

Accepted into jaunty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Martin Pitt (pitti) wrote :

Anyone who can test the proposed package? If not, the proposed update will be removed again. Thanks!

Revision history for this message
Andreas Wenning (andreas-wenning) wrote :

Fix confirmed. After installing the package from jaunty proposed, the test-script shows a map (instead of simply giving a "module not found" error).

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package osm-gps-map - 0.2-0ubuntu1.1

---------------
osm-gps-map (0.2-0ubuntu1.1) jaunty-proposed; urgency=low

  * Two patches to fix python module locations (LP: #387043)
    * 01_correct-python-package-location-configure.dpatch
      This patch fixes the configure script that was distributed from upstream
      so that the python directories are detected correctly
    * 02_correct-python-package-location-aclocal.dpatch
      This patch fixes the aclocal file, for the same reason as the configure
      script.
 -- Andrew Gee <email address hidden> Wed, 01 Jul 2009 02:17:30 +0100

Changed in osm-gps-map (Ubuntu Jaunty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.