Reporting CGIs incorrectly calculate start or end time for periods spanning changes to daylight time

Bug #394211 reported by Mark Goldfinch
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nagios
Fix Released
Unknown
nagios3 (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: nagios3

I've discovered a Daylight Savings Time bug within the avail, histogram, summary and trends CGIs.

To reproduce, run a custom report timeperiod for a duration which spans migration into or out of DST. As an example using NZST either 1st Apr to 30th Apr or 1st Sep to 30th Sep. Note the start and end time, either the start or end time will be an hour out from what one would expect.

Please see the attached patch to fix. The problem arises from using the generated tm_isdst flag from calling localtime(&current_time) within compute_report_times(). It should be noted setting tm_isdst=-1 is used elsewhere within these CGIs already.

This bug is present in intrepid, jaunty and will be present in karmic too. It is also present the latest stable upstream (3.1.2). I've seperately raised this issue on the nagios-devel mailing list.

Related branches

Revision history for this message
Mark Goldfinch (4-launchpad-g-org-nz) wrote :
Revision history for this message
Chuck Short (zulcss) wrote :

Thanks for the bug report I have reported the issue in the nagios bug tracker. We will see what they have to say.

Regards
chuck

Changed in nagios3 (Ubuntu):
status: New → Triaged
Revision history for this message
Chuck Short (zulcss) wrote :
Changed in nagios:
status: Unknown → New
Changed in nagios:
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nagios3 - 3.0.6-5ubuntu2

---------------
nagios3 (3.0.6-5ubuntu2) karmic; urgency=low

  * debian/patches/96_fix_daylight-saving.dpatch: Fix daylight savings bug.
    (LP: #394211)
  * Update maintainer according to spec.

 -- Chuck Short <email address hidden> Wed, 05 Aug 2009 16:21:35 +0100

Changed in nagios3 (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.