Carriage returns in bubble title should be converted to a single space

Bug #402247 reported by Ara Pulido
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
Fix Released
Low
Mirco Müller
Karmic
Fix Released
Low
Mirco Müller

Bug Description

Binary package hint: notify-osd

Sending a notification like:

notify-send "New Line
This is another line"

should make a bubble appear as "New Line this is another line"

https://wiki.ubuntu.com/NotifyOSD#Title%20text

ProblemType: Bug
Architecture: i386
Date: Tue Jul 21 16:30:56 2009
DistroRelease: Ubuntu 9.10
GtkTheme: Human
IconTheme: Human
MachineType: LENOVO 7664R5G
NonfreeKernelModules: nvidia
Package: notify-osd 0.9.15-0ubuntu1
ProcCmdLine: root=UUID=9ddb8687-1248-406f-b1fa-3812a368d945 ro quiet splash
ProcEnviron:
 LANGUAGE=en_NZ.UTF-8
 PATH=(custom, user)
 LANG=en_NZ.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-3.19-generic
RelatedPackageVersions:
 xserver-xorg 1:7.4+3ubuntu5
 libgl1-mesa-glx 7.5-1ubuntu1
 libdrm2 2.4.11-1ubuntu1
 xserver-xorg-video-intel 2:2.8.0-0ubuntu1
 xserver-xorg-video-ati 1:6.12.99+git20090629.f39cafc5-0ubuntu1
SourcePackage: notify-osd
Uname: Linux 2.6.31-3-generic i686
WindowManager: compiz
dmi.bios.date: 08/15/2008
dmi.bios.vendor: LENOVO
dmi.bios.version: 7LETC4WW (2.24 )
dmi.board.name: 7664R5G
dmi.board.vendor: LENOVO
dmi.board.version: Not Available
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: Not Available
dmi.modalias: dmi:bvnLENOVO:bvr7LETC4WW(2.24):bd08/15/2008:svnLENOVO:pn7664R5G:pvrThinkPadT61:rvnLENOVO:rn7664R5G:rvrNotAvailable:cvnLENOVO:ct10:cvrNotAvailable:
dmi.product.name: 7664R5G
dmi.product.version: ThinkPad T61
dmi.sys.vendor: LENOVO

Related branches

Revision history for this message
Ara Pulido (ara) wrote :
Changed in notify-osd (Ubuntu Karmic):
importance: Undecided → Low
David Barth (dbarth)
Changed in notify-osd (Ubuntu Karmic):
assignee: nobody → Mirco Müller (macslow)
milestone: none → ubuntu-9.10-beta
David Barth (dbarth)
Changed in notify-osd:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Mirco Müller (macslow)
milestone: none → ubuntu-9.10-beta-freeze
Changed in notify-osd (Ubuntu Karmic):
status: New → Triaged
David Barth (dbarth)
Changed in notify-osd:
milestone: ubuntu-9.10-beta-freeze → ubuntu-9.10
Changed in notify-osd (Ubuntu Karmic):
milestone: ubuntu-9.10-beta → ubuntu-9.10
Mirco Müller (macslow)
Changed in notify-osd:
status: Triaged → Fix Committed
Changed in notify-osd (Ubuntu Karmic):
status: Triaged → Fix Committed
Mirco Müller (macslow)
Changed in notify-osd:
status: Fix Committed → Fix Released
Changed in notify-osd (Ubuntu Karmic):
status: Fix Committed → Fix Released
Revision history for this message
Chow Loong Jin (hyperair) wrote :

Fixing this bug causes a regression in Banshee, Exaile, and possibly some other media players I'm not aware about. At least in the case of Banshee, the "Now Playing" notifications are formatted as such:

"${title}
<i>${artist}</i>"

And it has worked pretty nicely for quite some time already. The whole newline-to-space change has caused it to become "${title} ${artist}" (note that formatting is also removed) so that my title and artist has been squashed together into one line and look like a single string.

If you're going to be making changes like this, do change the wikipage accordingly beforehand, please, and announce it somewhere somehow. Here's a snippet of the wikipage:
============================================================================================================
Body text

The body should be 0.9 × the standard application font size, of color #eaeaea, standard weight, and should not contain any extra formatting.

In the body text, any string of one or more consecutive whitespace characters that contains at least one newline (U+000D CARRIAGE RETURN (CR), U+000A LINE FEED (LF), or U+000D CARRIAGE RETURN (CR) immediately followed by U+000A LINE FEED (LF)), even if a mixture of those, should be treated as a single newline. Then for each line in the text, any string of one or more consecutive (non-newline) whitespace characters, even if a mixture of them, should be treated as a single space, and leading and trailing whitespace should not be presented.
============================================================================================================

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Chow Loong Jin, that text you quoted is about the body text, not the title text. The title text should be only one line, as described at <https://wiki.ubuntu.com/NotifyOSD#Title%20text>.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Actually, I see the problem you were talking about and I've discussed it with Mirco. Notify OSD was accidentally eating line breaks from both title and body text, instead of just title text. This is now fixed in trunk.

no longer affects: notify-osd
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.