various modemmanager files lack license header

Bug #403009 reported by Alexander Sack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ModemManager
Fix Released
Medium
Alexander Sack

Bug Description

there is a COPYING in top level directory of the source tree, so this is not a blocking issue, but to make it even more explicit all modemmanager files should have a proper license header.

output of licensecheck below:

$ licensecheck -r .
./test/mm-test.py: *No copyright* UNKNOWN
./test/mm-send-sms.py: *No copyright* UNKNOWN
./autogen.sh: *No copyright* UNKNOWN
./plugins/mm-modem-mbm.h: GPL (v2 or later) (with incorrect FSF address)
./plugins/mm-modem-nokia.c: GPL (v2 or later)
./plugins/mm-modem-huawei.h: GPL (v2 or later)
./plugins/mm-plugin-novatel.c: GPL (v2 or later)
./plugins/mm-plugin-sierra.h: GPL (v2 or later)
./plugins/mm-modem-huawei.c: GPL (v2 or later)
./plugins/mm-plugin-huawei.c: GPL (v2 or later)
./plugins/mm-modem-mbm.c: GPL (v2 or later) (with incorrect FSF address)
./plugins/mm-modem-novatel-gsm.h: GPL (v2 or later)
./plugins/mm-plugin-novatel.h: GPL (v2 or later)
./plugins/mm-modem-sierra.c: GPL (v2 or later)
./plugins/mm-modem-zte.h: GPL (v2 or later)
./plugins/mm-plugin-generic.h: *No copyright* UNKNOWN
./plugins/mm-plugin-huawei.h: GPL (v2 or later)
./plugins/mm-plugin-option.h: GPL (v2 or later)
./plugins/mm-plugin-nokia.c: GPL (v2 or later)
./plugins/mm-plugin-gobi.h: GPL (v2 or later)
./plugins/mm-modem-moto-c-gsm.c: GPL (v2 or later)
./plugins/mm-modem-moto-c-gsm.h: GPL (v2 or later)
./plugins/mm-plugin-nokia.h: GPL (v2 or later)
./plugins/mm-plugin-mbm.c: GPL (v2 or later) (with incorrect FSF address)
./plugins/mm-plugin-hso.c: GPL (v2 or later)
./plugins/mm-plugin-zte.c: GPL (v2 or later)
./plugins/mm-modem-gobi-gsm.h: GPL (v2 or later)
./plugins/mm-plugin-hso.h: GPL (v2 or later)
./plugins/mm-modem-gobi-gsm.c: GPL (v2 or later)
./plugins/mm-plugin-zte.h: GPL (v2 or later)
./plugins/mm-modem-hso.h: GPL (v2 or later)
./plugins/mm-plugin-mbm.h: GPL (v2 or later) (with incorrect FSF address)
./plugins/mm-modem-hso.c: GPL (v2 or later)
./plugins/mm-modem-option.c: GPL (v2 or later)
./plugins/mm-plugin-sierra.c: GPL (v2 or later)
./plugins/mm-plugin-gobi.c: GPL (v2 or later)
./plugins/mm-plugin-option.c: GPL (v2 or later)
./plugins/mm-modem-novatel-gsm.c: GPL (v2 or later)
./plugins/mm-modem-option.h: GPL (v2 or later)
./plugins/mm-modem-sierra.h: GPL (v2 or later)
./plugins/mm-modem-zte.c: GPL (v2 or later)
./plugins/mm-modem-nokia.h: GPL (v2 or later)
./plugins/mm-plugin-moto-c.c: GPL (v2 or later)
./plugins/mm-plugin-moto-c.h: GPL (v2 or later)
./plugins/mm-plugin-generic.c: GPL (v2 or later)
./src/mm-serial-port.c: GPL (v2 or later)
./src/main.c: GPL (v2 or later)
./src/mm-errors.h: *No copyright* UNKNOWN
./src/mm-options.c: *No copyright* UNKNOWN
./src/mm-modem-cdma.c: *No copyright* UNKNOWN
./src/mm-modem.h: *No copyright* UNKNOWN
./src/mm-port.c: GPL (v2 or later)
./src/mm-errors.c: *No copyright* UNKNOWN
./src/mm-modem-base.c: GPL (v2 or later)
./src/mm-modem-gsm-network.h: *No copyright* UNKNOWN
./src/mm-callback-info.c: *No copyright* UNKNOWN
./src/mm-modem-simple.h: *No copyright* UNKNOWN
./src/mm-generic-gsm.c: *No copyright* UNKNOWN
./src/mm-serial-parsers.c: *No copyright* UNKNOWN
./src/mm-generic-cdma.h: *No copyright* UNKNOWN
./src/mm-modem-gsm-card.h: *No copyright* UNKNOWN
./src/mm-plugin-base.h: GPL (v2 or later)
./src/mm-plugin.c: *No copyright* UNKNOWN
./src/mm-modem-gsm-card.c: *No copyright* UNKNOWN
./src/mm-modem-simple.c: *No copyright* UNKNOWN
./src/mm-manager.h: *No copyright* UNKNOWN
./src/mm-modem-gsm-network.c: *No copyright* UNKNOWN
./src/mm-serial-parsers.h: *No copyright* UNKNOWN
./src/mm-plugin.h: *No copyright* UNKNOWN
./src/mm-port.h: GPL (v2 or later)
./src/mm-modem-gsm-sms.c: *No copyright* UNKNOWN
./src/mm-callback-info.h: *No copyright* UNKNOWN
./src/mm-manager.c: *No copyright* UNKNOWN
./src/mm-modem-base.h: GPL (v2 or later)
./src/mm-generic-gsm.h: *No copyright* UNKNOWN
./src/mm-modem.c: *No copyright* UNKNOWN
./src/mm-plugin-base.c: GPL (v2 or later)
./src/mm-serial-port.h: GPL (v2 or later)
./src/mm-generic-cdma.c: *No copyright* UNKNOWN
./src/mm-modem-gsm-sms.h: *No copyright* UNKNOWN
./src/mm-modem-cdma.h: *No copyright* UNKNOWN
./src/mm-options.h: *No copyright* UNKNOWN
./marshallers/mm-marshal-main.c: *No copyright* UNKNOWN

Revision history for this message
Alexander Sack (asac) wrote :
Changed in modemmanager:
assignee: nobody → Alexander Sack (asac)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Alexander Sack (asac) wrote :

attaching the patch for real.

Revision history for this message
Alexander Sack (asac) wrote :

note ... it has a COPYING file in top level dir and its GPL everywhere - so its not really a big deal and shouldnt block the NEWing.

Alexander Sack (asac)
Changed in modemmanager:
status: In Progress → Fix Committed
Revision history for this message
Alexander Sack (asac) wrote :

fixed in latest upload (forgot to close iirc):

Changed in modemmanager:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.