[MIR] modemmanager

Bug #410259 reported by Tony Espy
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
modemmanager (Ubuntu)
Fix Released
Undecided
Alexander Sack

Bug Description

1. Availability:

http://archive.ubuntu.com/ubuntu/pool/universe/m/modemmanager/

modemmanager is available for all supported architectures.

2. Rationale:

modemmanager is a runtime 'Recommends:' dependency of network-manager 0.8.
It's purpose is to provide an extensible 3G framework used by network-manager.

3. Security:

 * The code was factored out of network-manager 0.7 in order to create a
   separate extensible framework for handling modems.
 * There are no current CVE entries for modemmanager.
 * There are no search results retunred by Secunia for modemmanager.
 * modemmanager provides a system daemon binary, modem-manager, which runs as root.
 * modemmanager opens one or more serial/modem ports in order to configure the modem. It
   also processes control status information from the modem. It doesn't handle any incoming
   network data.
 * modemmanager doesn't process any binary (video, audio, etc ) data.
 * Any source code review performed? No, but as mentioned above, this
   code was factored out of network-manager 0.7.

4. Quality assurance:

 * In what situations does the package not work out of the box
   without configuration? NONE

 * Does the package ask any debconf questions higher than priority 'medium'? NO

 * Debian bugs: (mention any that are particularly relevant, and any showstoppers) NONE

 * Maintenance in Debian is frenetic/vigorous/calm/dead ? The Ubuntu Network Manager
   team will maintain it in Debian.
 * Upstream is frenetic/vigorous/calm/dead? Upstream development is vigorous, with
   ongoing development work.

 * Upstream bug tracker: (mention any particularly relevant or critical)

   http://bugzilla.gnome.org/browse.cgi?product=NetworkManager

 * Hardware: Does this package deal with hardware and if so how exotic is it ?
    Yes, please see above description.

 * Is there a test suite in the upstream source or packaging ? Is it enabled to
   run in the build ? NO

5. UI standards:

Not applicable, modemmanager is a system-daemon with no user-visible strings UI.

6. Standards compliance:

 * FHS, Debian Policy compliance ? YES
 * Packaging system (debhelper/cdbs/dbs) ? debhelper
 * Patch system ? quilt
 * Any packaging oddities ? NO

7. Dependencies:

 * Build-Depends: debhelper (>= 5.0.0), automake, cdbs, quilt, libtool,
   libdbus-glib-1-dev (>= 0.75), libgudev-1.0-dev
 * Runtime: none
 * Are these all in main ? YES

8. Maintenance:

 * How much maintenance is this package likely to need ?
   This package will need ongoing maintenance to add support for
   new hardware, and fix bugs as appropriate.
 * Who is responsible for monitoring the quality of this
   package and fixing its bugs ?
   Dedicated Canonical Network Manager team.
   * Are they Ubuntu or Debian developers ? Debian & Ubuntu developers.
 * Who is the package bug contact in Ubuntu? Launchpad Network Manager team.

9. Background information:

    * The general purpose and context of the package should be clear from the
      package's debian/control file. If it isn't then please explain.
      The control file explanation is sufficient.
    * What do upstream call this software ? modemmanager
    * Has it had different names in the past ? NO

10. Internationalization:

N/A - see "5. UI standards"

Revision history for this message
Alexander Sack (asac) wrote :

assigning to lool as i cannot rubber stamp my own MIRs. its basically network manager code factored out, so i dont think it needs a full review.

Changed in modemmanager (Ubuntu):
assignee: nobody → Loïc Minier (lool)
Revision history for this message
Loïc Minier (lool) wrote :

- is this correct?
Maintainer: Ubuntu Modem Manager Team <email address hidden>
- copyright file says "II. PACKAGING" but there's no "I. "
- debian/patches/ftbfs_hardy_glib_include_signal_h.patch can be dropped, as src/main.c includes signal.h unconditionally now; besides it wasn't applied because there is no series, an empty series should be added at the same time
- debian/compat file is missing, debhelper compat level isn't set apparently
- packages uses CDBS but computes plenty of things which CDBS already provides:
DEB_SOURCE := $(shell dpkg-parsechangelog | grep Source: | sed -e 's/Source: //')
DEB_VERSION := $(shell dpkg-parsechangelog | grep Version: | sed -e 's/Version: //')
DEB_UPSTREAM_VERSION := $(shell echo $(DEB_VERSION) | sed -e 's/-[^-]*$$//')
DEB_MAJOR_VERSION := $(shell echo $(DEB_UPSTREAM_VERSION) | sed -e 's/git.*//')
- build-dep on automake should be automake >= 1.10 (and it would be nice to encode < 1.12~ too since the build only supports 1.10 and 1.11)
- DEB_CONFIGURE_EXTRA_FLAGS += $(NULL) is a bit useless ;-)
- the pre-build touch aclocal.m4 looks a bit suspicious to me, I'm not sure why there should be any timestamp issue here
- nobody is subscribed to bugmail

I'd like to see some of the packaging issues addressed, but otherwise it's good to go

Revision history for this message
Martin Pitt (pitti) wrote :

Alex, can you please incorporate Loic's feedback? Thanks!

Changed in modemmanager (Ubuntu):
assignee: Loïc Minier (lool) → Alexander Sack (asac)
status: New → Triaged
Revision history for this message
Alexander Sack (asac) wrote :

fixed most comments in bzr; next upload will close this bug

  * address MIR comments (LP: #410259)
    + cleanup debian/copyright
    + set debhelper compat level to 5, matching debian/control
      - add debian/compat
    + remove not used patches
      - delete debian/patches/ftbfs_hardy_glib_include_signal_h.patch
    + use proper automake lower and upper version bounds matching the
      versions referred to in debian/rules
      - update debian/control
    + don't redefine cdbs variables DEB_SOURCE, DEB_VERSION and
      DEB_UPSTREAM_VERSION; in turn move DEB_MAJOR_VERSION definition
      below the cdbs includes and use DEB_SOURCE_PACKAGE in GET_SOURCE
      function
      - update debian/rules
    + document why we touch aclocal.m4 in pre-build::
      - update debian/rules
    + use Ubuntu Network Manager Team as Maintainer and add <email address hidden>
      to Uploaders
      - update debian/control

Changed in modemmanager (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Loïc Minier (lool) wrote :

Looks all good thanks! (dont forget to sub to bugmail)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package modemmanager - 0.2.git.20090909t142854.64b7be7-0ubuntu1

---------------
modemmanager (0.2.git.20090909t142854.64b7be7-0ubuntu1) karmic; urgency=low

  New upstream snapshot 2009-09-09 14:28:54 (GMT)
  + commit: 64b7be7460c3a9dbb3c9981de5754b330a8d2cdd
  + fix LP: #414604 - Modem Manager setting bad baud rate, breaking pppd
    connections.
  + fix LP: #416418 - First connection attempt via F3507g fails
  + fix LP: #424603 - Not closing modems when disconnected

  [ Alexander Sack <email address hidden> ]
  * address MIR comments (LP: #410259)
    + cleanup debian/copyright
    + set debhelper compat level to 5, matching debian/control
      - add debian/compat
    + remove not used patches
      - delete debian/patches/ftbfs_hardy_glib_include_signal_h.patch
    + use proper automake lower and upper version bounds matching the
      versions referred to in debian/rules
      - update debian/control
    + don't redefine cdbs variables DEB_SOURCE, DEB_VERSION and
      DEB_UPSTREAM_VERSION; in turn move DEB_MAJOR_VERSION definition
      below the cdbs includes and use DEB_SOURCE_PACKAGE in GET_SOURCE
      function
      - update debian/rules
    + document why we touch aclocal.m4 in pre-build::
      - update debian/rules
    + use Ubuntu Network Manager Team as Maintainer and add <email address hidden>
      to Uploaders
      - update debian/control

 -- Alexander Sack <email address hidden> Mon, 14 Sep 2009 11:38:05 +0200

Changed in modemmanager (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.