webfav lp-locale-export.mk yields en-US.xpi with .manifest files only

Bug #411191 reported by Alexander Sack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mozilla-devscripts (Ubuntu)
Fix Released
High
Alexander Sack

Bug Description

Binary package hint: mozilla-devscripts

webfav uses chrome.manifest with jar: protocol lines that use multi-whitespace delimiters for the rows in manifest files. This breaks lp-local-export.mk, which will not include any .jar file in en-US.xpi template produced.

Revision history for this message
Alexander Sack (asac) wrote :

bzr commit -m ' * lp-locale-export.mk:
   - fix LP: #411191 - webfav lp-locale-export.mk yields en-US.xpi with
     .manifest files only - fix parsing bug for jar: protocol lines' --fixes 'lp:411191' 'debian/changelog' 'src/lp-locale-export.mk'
Committing to: bzr+ssh://bazaar.launchpad.net/~mozillateam/mozilla-devscripts/mozilla-devscripts/
modified debian/changelog
modified src/lp-locale-export.mk
Committed revision 219.

Changed in mozilla-devscripts (Ubuntu):
assignee: nobody → Alexander Sack (asac)
importance: Undecided → High
milestone: none → ubuntu-9.10-beta
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.5 KiB)

This bug was fixed in the package mozilla-devscripts - 0.14

---------------
mozilla-devscripts (0.14) unstable; urgency=low

  [ Alexander Sack <email address hidden> ]
  * xpi.mk:
    - add target application id magic (|XPI_TARGET_EMIDs|); parse install.rdf
      and create extension links for all targetapplications like:
      |/usr/lib/mozilla/extensions/$targetappid/$extid|; in same turn we
      deprecate |MOZ_XPI_MOZILLA_DIRS| and unset its default accordingly
      - update src/xpi.mk
    - improve rule dependencies; avoid duplicate/circular depends
      - update src/xpi.mk
    - first pitch on automagic max/min version detection implemented; add a
      generic |TARGET_VERSION| call taking parameters a) appid,
      b) maxVersion|minVersion and c) extension-dir; this call is then used to
      parse the right max/minVersion for a given targetApplication on demand in
      |CHECK_VERSION|. In this way we now filter out unsuitable packages from
      xpi:Depends based on the install.rdf version bounds
      - update src/xpi.mk
    - add <email address hidden> 1.0 to list of auto detected target
      application packages
      - update src/xpi.mk
    - use moz-version --compare in ${xpi:Depends} |CHECK_VERSION| call
      instead of the rather flawed dpkg --compare-versions approach.
      - update src/xpi.mk
    - add thunderbird-3.0 to list of auto detected target application packages
      - update src/xpi.mk
   * build-system:
    - add bindir_files feature and use that to install med-xpi-*pack as well as
      moz-version-compare to BINDIR; in turn adjust dh_install helper
      accordingly.
      - update src/Makefile
      - update debian/mozilla-devscripts.install
   * lp-locale-export.mk:
     - fix LP: #411191 - webfav lp-locale-export.mk yields en-US.xpi with
       .manifest files only - fix parsing bug for jar: protocol lines
  * packaging:
    - fix Vcs-Bzr: to point to a proper R/W location and use Vcs-Bzr-Browser for the
      browsable read-only location
      - update debian/control
    - add Benjamin Drung <email address hidden> to Uploaders and also add my @ubuntu.com
      address work-time uploads won't count as NMU
      - update debian/control

  [ Benjamin Drung <email address hidden> ]
  * xpi.mk:
    - add automatic xpi depends .substvars feature based on smart parsing
      of install.rdf and checking min/maxVersion for each target application;
      extensions can now use ${xpi:Depends} to get the right dependencies added;
      the version/package/targetAppId mapping information is currently
      maintained in src/xpi.mk itself
      - update src/xpi.mk
    - add moz-version helper script and ship it in extra_files; this script
      implements compare operations for mozilla versions as in
      https://developer.mozilla.org/en/Toolkit_version_format
      - add src/moz-version
      - update src/Makefile
    - implement start/end of life for comparing possible alternate binary
      dependency
      - update src/xpi.mk
    - make MOZ_EXTENSION_PKG optional; if this variable is unset, the first
      binary package listed in debian/control will be used
      - update src/xpi.mk

mozilla-devscripts (0.13) unsta...

Read more...

Changed in mozilla-devscripts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.