[MIR] indicator-session

Vcs-Bzr: http://bazaar.launchpad.net/~ubuntu-core-dev/indicator-sus/ubuntu
is incorrect (404)

Description is broken as I reported earlier to the uploaders.

Why dont you just depend on gdm >> some version instead of depends + conflicts << version, since this package is a new one?

The autogen.sh script is in the .diff.gz.

FYI with configure.ac constructs like:
PKG_CHECK_MODULES(STATUSSERVICE, dbusmenu-glib >= $DBUSMENUGLIB_REQUIRED_VERSION)
AC_SUBST(STATUSERVICE_CFLAGS)
AC_SUBST(STATUSERVICE_LIBS)

you actually dont need the AC_SUBSTs (the pkg-config macro does them already)

Please build-dep on libdbus-1-dev for /usr/lib/pkgconfig/dbus-1.pc which you use in:
$PKG_CONFIG --variable=session_bus_services_dir dbus-1

You mention gettext support but I dont see any .po or .pot files?

Sorry forgot to check source package in LP:

Please subscribe to bugmail.

References to scrollkeeper in bdep and configure flags seem bogus:
configure: WARNING: unrecognized options: --disable-scrollkeeper

Please fix this:
status-service.c: In function 'build_user_item':
status-service.c:127: warning: implicit declaration of function 'getuid'

There are other build time warnings.

indicator-sus was renamed to indicator-session (just about to upload), but -sus wasn't yet in main either.

Oops, sorry, confused project/packages tasks.

Note that I more or less accidentally put that into main already, but it still needs MIR review.

Ken, can you please check Loic's review feedback against the current indicator-session?

Another issue is that indicator-session uses the old policykit API. It needs to be ported to polkit-1.

If this is just a PK client for services provided by gdm, then the only thing to do is to rip out all the PK code entirely. If i-s itself provides PK-protected services, it needs to be ported.

Please see https://wiki.ubuntu.com/DesktopTeam/PolicyKitOneMigration for details.

On Tue, 2009-08-25 at 10:00 +0000, Martin Pitt wrote:
> Another issue is that indicator-session uses the old policykit API. It
> needs to be ported to polkit-1.

Reported as bug 418643 to ensure it doesn't get lost.

I pushed a couple of fixes and filed a couple of bugs; please do subscribe you or your team to the bug mail.

I didn't file a bug about the AC_SUBST constructs.

The question on gettext support in the MIR stands.

Moving milestone, since it's not blocking alpha-5 release (package is already in main). The outstanding issues still need to be settled, though.

Setting to triaged. THe package is in main, and the only remaining issue is to drop the old policykit client-side code and dependency.

Ken, can you please see to this soon?

Reopening upstream task, it still has the old policykit code.

It actually queries PK, so it's not just about dropping the code entirely. I look into porting this now.

I did the porting and uploaded to Karmic.

Patch: http://bazaar.launchpad.net/%7Eubuntu-desktop/indicator-session/ubuntu/annotate/head%3A/debian/patches/01_polkit-1.patch

Please apply upstream.

In case you are interested for a package branch of your's, this is the complete changeset, with build-dependency change:

http://bazaar.launchpad.net/%7Eubuntu-desktop/indicator-session/ubuntu/revision/45

I unsubscribe ubuntu-mir now, since the Karmic package is fine now, and there's nothing left for MIR to do/approve.

This bug was fixed in the package indicator-session - 0.1.4-0ubuntu2

---------------
indicator-session (0.1.4-0ubuntu2) karmic; urgency=low

  * Add 01_polkit-1.patch: Port to polkit-1. (LP: #412601)
  * Add 99_autoreconf.patch: Autoconf changes for above patch.
  * debian/control: libpolkit-gnome-dev → libpolkit-gobject-1-dev

 -- Martin Pitt <email address hidden> Tue, 22 Sep 2009 09:17:43 +0200

I did a proper branch now and submitted for merge:

  https://code.launchpad.net/~pitti/indicator-session/polkit-1/+merge/12221