Having no EMAIL environment variable set makes quickly release fail

Bug #418369 reported by Rick Spencer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Quickly
Fix Released
Medium
Unassigned

Bug Description

if you do not have an EMAIL set in your .baschrc file, then even if you have pgp keys set, quickly release fails. This is because dpkg-buildpackage falls back to the users local machine user name, which does not match the email set for the pgp key, and thus the whole thing bombs.

I suppose release.py could check if the EMAIL variable is set, and if not go ahead and use the users email as an environment variable when making the dpkg-buildpackage call.

Related branches

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I agree. I'll do this evening.

So, if EMAIL is empty, I'll try to take the preferred email of LP account (as release command has this info).
Just for the information, did it crashed gracefully?

Changed in quickly:
status: New → Triaged
milestone: none → 0.2
importance: Undecided → Medium
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Fixed in commit 266 and 267 :)

Changed in quickly:
status: Triaged → Fix Committed
Changed in quickly:
status: Fix Committed → Fix Released
Revision history for this message
Umang Varma (umang) wrote :

This needs to be fixed for quickly share also.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

quickly share and quickly release are sharing the same code there. It tried again and it's not failing here. That's weird…

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.