FTBFS with gcc 4.4

Bug #429099 reported by Felix Geyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
abiword (Debian)
Fix Released
Unknown
abiword (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: abiword

abiword 2.6.8-5ubuntu1 FTBFS with gcc 4.4 in the latest archive rebuild test:
https://edge.launchpad.net/ubuntu/+archive/test-rebuild-20090909/+build/1210059

Tags: patch
Revision history for this message
Felix Geyer (debfx) wrote :

Proposed fix:

abiword (2.6.8-5ubuntu2) karmic; urgency=low

  * Fix FTBFS with gcc 4.4 (LP: #429099)
    - Add debian/patches/05_ftbfs_gcc44.diff

Revision history for this message
Daniel Holbach (dholbach) wrote :

Can you forward the patch to Debian and Upstream?

Revision history for this message
Daniel Holbach (dholbach) wrote :

Also... does this patch come from somewhere? It'd be nice to document it with https://wiki.ubuntu.com/UbuntuDevelopment/PatchTaggingGuidelines

Revision history for this message
Daniel Holbach (dholbach) wrote :

This is the diff between our version and the current upstream version.

Maybe use this instead?
- if (val[0]) {
+ if (val && val[0]) {

Also: can you make use of https://wiki.ubuntu.com/UbuntuDevelopment/PatchTaggingGuidelines or at least document that the bug is fixed upstream and the patch dropped when we move to the new upstream version?

Revision history for this message
Daniel Holbach (dholbach) wrote :

Argh... forget comment #4. Sorry.

Revision history for this message
Felix Geyer (debfx) wrote :

Tagged the patch and forwarded it to Debian.
Upstream already has the fix in svn.

Changed in abiword (Debian):
status: Unknown → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package abiword - 2.6.8-5ubuntu2

---------------
abiword (2.6.8-5ubuntu2) karmic; urgency=low

  * Fix FTBFS with gcc 4.4 (LP: #429099)
    - Add debian/patches/05_ftbfs_gcc44.diff

 -- Felix Geyer <email address hidden> Mon, 14 Sep 2009 00:08:54 +0200

Changed in abiword (Ubuntu):
status: New → Fix Released
Artur Rona (ari-tczew)
tags: added: patch
Changed in abiword (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.