Ubuntu
bzr-builddeb package

mark-uploaded fails with "Unknown target distribution: lucid"

Bug #476530 reported by Thierry Carrez
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr-builddeb
Fix Released
High
James Westby
bzr-builddeb (Ubuntu)
Fix Released
High
Unassigned
Karmic
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: bzr-builddeb

Trying to follow DistributedDevelopment instructions when doing a lucid merge :)

After uploading the resulting package with dput, I'm trying to run "bzr mark-uploaded" to mark the change as being the same as the source package that was uploaded. This fails with the following error:

bzr: ERROR: Unknown target distribution: lucid

I /think/ we need to add "lucid" to the list in util.py.

For the time being, I'm not sure what's the best option once you uploaded the merged version:
- do not bzr push since we couldn't mark-uploaded, and let the importer figure it out
- do bzr push even if we didn't mark-uploaded
- something else

ANSWER: use "debcommit -r" and then push.

ProblemType: Bug
Architecture: amd64
Date: Fri Nov 6 15:24:32 2009
DistroRelease: Ubuntu 9.10
NonfreeKernelModules: nvidia
Package: bzr-builddeb 2.2~ubuntu3
PackageArchitecture: all
ProcEnviron:
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-14.48-generic
SourcePackage: bzr-builddeb
Uname: Linux 2.6.31-14-generic x86_64
XsessionErrors:
 (gnome-settings-daemon:2107): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
 (gnome-settings-daemon:2107): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
 (polkit-gnome-authentication-agent-1:2230): GLib-CRITICAL **: g_once_init_leave: assertion `initialization_value != 0' failed
 (nautilus:2199): Eel-CRITICAL **: eel_preferences_get_boolean: assertion `preferences_is_initialized ()' failed
 (gnome-panel:2198): Gdk-WARNING **: /build/buildd/gtk+2.0-2.18.3/gdk/x11/gdkdrawable-x11.c:952 drawable is not a pixmap or window

See original description
Revision history for this message
Thierry Carrez (ttx) wrote :
Andrew Starr-Bochicchio (andrewsomething)
Changed in bzr-builddeb (Ubuntu):
status: New → Confirmed
James Westby (james-w)
Changed in bzr-builddeb (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → High
James Westby (james-w)
Changed in bzr-builddeb:
importance: Undecided → High
status: New → Fix Committed
assignee: nobody → James Westby (james-w)
Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

Remember to put it in a PPA for the karmic users ;-)

Revision history for this message
Robert Collins (lifeless) wrote :

James, we need a backport of this to karmic for folk not yet dogfooding lucid.

Revision history for this message
Benjamin Drung (bdrung) wrote :

This bug fix should be in karmic.

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Here's a minimal debdiff targeting karmic-proposed. Subscribing ubuntu-sru for an ACK.

I pushed it to lp:~andrewsomething/ubuntu/karmic/bzr-builddeb/fix-476530 as well. I'm not sure how to go about SRUs using UDD methods. I couldn't push to karmic-proposed. And as there is no karmic-proposed series, I have no idea where to propose a merge. Is there something I'm missing?

$ bzr push lp:~andrewsomething/ubuntu/karmic-proposed/bzr-builddeb/fix-476530
bzr: ERROR: Invalid url supplied to transport: "lp:~andrewsomething/ubuntu/karmic-proposed/bzr-builddeb/fix-476530": No such distribution series karmic-proposed.

James Westby (james-w)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

SRU ack, please upload. I guess you should just push to the "karmic" branch?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr-builddeb - 2.2~ubuntu4

---------------
bzr-builddeb (2.2~ubuntu4) lucid; urgency=low

  * util.py: Add "lucid" to ubuntu_releases (LP: #476530).
 -- Andrew Starr-Bochicchio <email address hidden> Sun, 10 Jan 2010 11:35:27 -0500

Changed in bzr-builddeb (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

2.2~ubuntu3.1 uploaded to karmic-proposed, waiting for approval.

Changed in bzr-builddeb (Ubuntu Karmic):
status: New → Confirmed
tags: added: udd
Revision history for this message
Cody A.W. Somerville (cody-somerville) wrote :

This type of change doesn't qualify for an SRU. It should instead be backported.

Revision history for this message
Martin Pitt (pitti) wrote :

Cody,

arguably it falls under point 4 in https://wiki.ubuntu.com/StableReleaseUpdates#When (obvious patch and affecting a leaf package (application) instead of a system component), so I deemed it okay for an SRU. If you have a strong opinion about not accepting it, a backport would work, too (especially since you really should test a package on lucid before you upload it to lucid). WDYT?

Revision history for this message
Cody A.W. Somerville (cody-somerville) wrote :

I'm fine with this SRU going through as the patch is clearly benign and I can certainly imagine how annoying it is. However, I think we should re-evaluate point 4 as it leaves the door wide open for all sorts of changes. These sort of SRU adds load to both the SRU and QA team which could probably be better invested on testing and reviewing changes to fix regressions and more serious bugs.

In fact, with this specific SRU, we're not even fixing a bug but updating it to add support for a newer target distribution - something that will need to happen again in the future. I question if SRUs should be used to performed regularly required updates.

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 476530] Re: mark-uploaded fails with "Unknown target distribution: lucid"

On Wed, 13 Jan 2010 15:53:50 -0000, "Cody A.W. Somerville" <email address hidden> wrote:
> I'm fine with this SRU going through as the patch is clearly benign and
> I can certainly imagine how annoying it is. However, I think we should
> re-evaluate point 4 as it leaves the door wide open for all sorts of
> changes. These sort of SRU adds load to both the SRU and QA team which
> could probably be better invested on testing and reviewing changes to
> fix regressions and more serious bugs.
>
> In fact, with this specific SRU, we're not even fixing a bug but
> updating it to add support for a newer target distribution - something
> that will need to happen again in the future. I question if SRUs should
> be used to performed regularly required updates.

I don't intend for this to happen again. I forgot that the list was
hardcoded, and so didn't add it when the new name was announced, I aim
to do that this time.

I think the discussion is worthwhile to have though, just maybe not on
this bug report :-)

Thanks,

James

Revision history for this message
Scott Kitterman (kitterman) wrote : Please test proposed package

Accepted into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in bzr-builddeb (Ubuntu Karmic):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Scott Kitterman (kitterman) wrote :

Ironically, I just hit this bug for the first time and I can verify that it's fixed in this upload.

description: updated
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr-builddeb - 2.2~ubuntu3.1

---------------
bzr-builddeb (2.2~ubuntu3.1) karmic-proposed; urgency=low

  * util.py: Add "lucid" to ubuntu_releases (LP: #476530).
 -- Andrew Starr-Bochicchio <email address hidden> Sat, 02 Jan 2010 17:07:21 -0500

Changed in bzr-builddeb (Ubuntu Karmic):
status: Fix Committed → Fix Released
James Westby (james-w)
Changed in bzr-builddeb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.