--bwlimit option uses KiB/s, but is documented as (what amounts to) kB/s
Bug #479405 reported by
Richard Laager
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| rsync |
Fix Released
|
Low
|
|||
| rsync (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
Binary package hint: rsync
The --bwlimit option seems to use KiB/s, as io.c's sleep_for_bwlimit() function
divides by 1024. It's documented as "KBPS", "KBytes per second", and "kilobytes
per second".
I'm going to attach a patch which standardizes all of this as KiB/s and
"kibibytes per second", to match the actual usage.
Given that this is a network transfer rate, it'd be more proper (and consistent
with other applications) to change the function to work in SI kilobytes per
second (i.e. use 1000 instead of 1024), but that's backwards-
you'd like to go this route, I can prepare a patch to that effect.
Revision history for this message
| Richard Laager (rlaager) wrote | #1 |
| Changed in rsync: | |
| status: | Unknown → Confirmed |
| Changed in rsync: | |
| status: | Confirmed → Fix Released |
Revision history for this message
| Andrew McCarthy (andrewmccarthy) wrote | #2 |
| Changed in rsync (Ubuntu): | |
| status: | New → Confirmed |
| Changed in rsync (Ubuntu): | |
| importance: | Undecided → Low |
| status: | Confirmed → Triaged |
| tags: | added: patch-accepted-upstream |
Revision history for this message
| Richard Laager (rlaager) wrote | #3 |
| Changed in rsync: | |
| importance: | Unknown → Low |
| tags: | added: units-policy |
Revision history for this message
| Richard Laager (rlaager) wrote | #4 |
| Changed in rsync (Ubuntu): | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Marking as confirmed as it's acknowledged and fixed in upstream source.