Byobu-launcher attempts to connect to dead screen; should run screen -wipe first

Bug #508609 reported by Ryan Thompson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
Fix Released
Medium
Dustin Kirkland 

Bug Description

Binary package hint: byobu

I configured byobu-launcher to run in .profile (using the configuration utility). At one point, this feature started working wrong. It would start a brand new non-byobu screen session. I looked into the problem, and my previous byobu session was crashed, leaving a stale socket. byobu-launcher failed to detect that this session was dead, and tried to reconnect to it using screen -xRR, which created a new session.

To fix this, perhaps byobu-launcher should run screen -wipe before attempting to detect a running session.

ProblemType: Bug
Architecture: amd64
Date: Sat Jan 16 18:54:05 2010
DistroRelease: Ubuntu 9.10
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027)
NonfreeKernelModules: wl nvidia
Package: byobu 2.38-0ubuntu3
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-18.55-generic
ScreenRC:

SourcePackage: byobu
Uname: Linux 2.6.31-18-generic x86_64

Related branches

Revision history for this message
Ryan Thompson (rct86) wrote :
Revision history for this message
Ryan Thompson (rct86) wrote :

In fact, if you *replace* the call to screen -ls with a call to screen -wipe, it seems to work fine, since screen -wipe also lists the open sockets.

Revision history for this message
Ryan Thompson (rct86) wrote :

I have attached a patch that implements my suggestion. It works for me.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks, this looks good!

Changed in byobu (Ubuntu):
assignee: nobody → Dustin Kirkland (kirkland)
importance: Undecided → Medium
status: New → In Progress
status: In Progress → Fix Committed
Revision history for this message
Ryan Thompson (rct86) wrote :

You may also want to throw a comment in there explaining to future readers of the code why you're using -wipe instead of -ls.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 2.48-0ubuntu1

---------------
byobu (2.48-0ubuntu1) lucid; urgency=low

  [ launchpad.net/~rct86 ]
  * usr/bin/byobu-launcher: use screen -wipe, instead of screen -ls, to
    clean up destroyed sessions, LP: #508609

  [ launchpad.net/~dperson ]
  * usr/bin/byobu-export: correct paths to their new locations, LP: #507461
 -- Dustin Kirkland <email address hidden> Mon, 18 Jan 2010 09:47:47 +1300

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Dustin Kirkland  (kirkland) wrote : Re: [Bug 508609] Re: Byobu-launcher attempts to connect to dead screen; should run screen -wipe first

Thanks, will do.

Would you like your real name in the changelog? Currently, I just
have a pointer to your LP id.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.