pybootchartgui crashed with ValueError in get_proc_state()

Hi,

If you upload your

/var/log/bootchart/$your_most_recent.tgz

then I'll have a look.

Best
Anders

my tgz, give the same traceback

Hi Olivier,

Thanks for the tgz. It is pretty strange. There are three lines in th proc_ps.log

3191 (dbus-daemon) t 1 3191 3191 0 -1 4194304 40 0 1 0 0 0 0 0 20 0 1 0 2131 561152 4 18446744073709551615 140617929830400 140617930149676 140736722716720 140736722716720 140617927596784 0 0 0 0 18446744071579303630 0 0 17 0 0 0 0 0 0
3376 (atd) t 1 3376 3376 0 -1 4194304 40 0 1 0 0 0 0 0 20 0 1 0 2356 262144 4 18446744073709551615 4194304 4210820 140734938830000 140734938830000 140254854798064 0 0 0 0 18446744071579303630 0 0 17 0 0 0 0 0 0
3381 (cron) t 1 3381 3381 0 -1 4194304 40 0 1 0 0 0 0 0 20 0 1 0 2359 282624 4 18446744073709551615 4194304 4228540 140737203960560 140737203960560 140009658469104 0 0 0 0 18446744071579303630 0 0 17 0 0 0 0 0 0

that have 't' as the state. This is not allowed according to the man-page

http://linux.die.net/man/5/proc

nor according to the source (as far as I can tell, from a quick look)

http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob_plain;f=fs/proc/array.c;hb=HEAD

Can you see if there are 't's present in all your .tgz's or if it is a random occurrence?

Best
Anders

I get the same crash in Lucid, and the latest proc_ps.log has quite a few processes in the 't' state, eg:

385 (sh) t 1 385 385 0 -1 4194304 32 0 1 0 0 0 0 0 20 0 1 0 266 352256 3 18446744073709551615 4194304 4289292 140735028552224 140735028552224 140024311642864 0 0 0 0 18446744071579292185 0 0 17 1 0 0 0 0 0

I'm also using kernel 2.6.33.

Hi Rocko,

Thanks for the report. I just checked again. And in Linus's latest git more states have been added - also a 't' state.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=fs/proc/array.c;hb=HEAD

-Anders

http://code.google.com/p/pybootchartgui/source/detail?r=140

has a simple fix to prevent the crash and use the default value intended for unknow process states. I'll forward it to

http://github.com/mmeeks/bootchart/

also.

Best
Anders

Also applied here.

http://github.com/mmeeks/bootchart/commit/3fb47d068ffee161e1d42fabedbf446c2535dea5

Ah, I just kind of independently fixed this, but I'll take upstreams' fix instead.

This bug was fixed in the package pybootchartgui - 0+r139-3

---------------
pybootchartgui (0+r139-3) maverick; urgency=low

  * pybootchartgui/draw.py, get_proc_state(): Don't crash on an undefined
    state. Patch taken from upstream svn r140. (LP: #512172)
 -- Martin Pitt <email address hidden> Tue, 22 Jun 2010 23:24:54 +0200

Is the 0+r139-3 change eligible to be a lucid-LTS update as an SRU?