Ubuntu
gtk2-engines-qtcurve package

equal rgb values when calling common/common.h:rgbToHsv causes segfault

Bug #528872 reported by Niall Creech
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gtk2-engines-qtcurve (Ubuntu)
Fix Released
Undecided
Jonathan Thomas

Bug Description

Binary package hint: gtk2-engines-qtcurve

when calling common/common.h:rgbToHsv with rgb equal and so max == min means delta is 0 causing a divide by zero segfault. attached is a possible fix although there may be a better one it should be fairly reasonable

Program received signal SIGFPE, Arithmetic exception.
0x00007fffef83c596 in rgbToHsv (r=1, g=<value optimised out>, b=1,
    h=0x7fffffffbd80, s=0x7fffffffbd78, v=0x7fffffffbd70)
    at /build/buildd/gtk2-engines-qtcurve-1.0.2/common/common.h:1160
1160 /build/buildd/gtk2-engines-qtcurve-1.0.2/common/common.h: No such file or directory.
 in /build/buildd/gtk2-engines-qtcurve-1.0.2/common/common.h
(gdb) bt
#0 0x00007fffef83c596 in rgbToHsv (r=1, g=<value optimised out>, b=1,
    h=0x7fffffffbd80, s=0x7fffffffbd78, v=0x7fffffffbd70)
    at /build/buildd/gtk2-engines-qtcurve-1.0.2/common/common.h:1160
#1 0x00007fffef856f55 in getCellCol (style=0xd5db00,
    window=<value optimised out>, state=<va

ProblemType: Bug
Architecture: amd64
CheckboxSubmission: 716d1b0e0549c96a138b059317db58fe
CheckboxSystem: d7486a0cf4dbe4bfdbdc5f2407943d41
Date: Sat Feb 27 07:04:01 2010
DistroRelease: Ubuntu 10.04
NonfreeKernelModules: nvidia
Package: gtk2-engines-qtcurve 1.0.2-1ubuntu1
ProcEnviron:
 PATH=(custom, user)
 LANG=en_GB.utf8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-14.20-generic
SourcePackage: gtk2-engines-qtcurve
Uname: Linux 2.6.32-14-generic x86_64

Revision history for this message
Niall Creech (sevenmachines-deactivatedaccount) wrote :
summary: - equal rgb values when calling common/common.h:rgbToHsv cause segfault
+ equal rgb values when calling common/common.h:rgbToHsv causes segfault
Revision history for this message
Niall Creech (sevenmachines-deactivatedaccount) wrote :

debdiff with bug number and dep3 header

gtk2-engines-qtcurve (1.0.2-1ubuntu2) lucid; urgency=low

  * debian/patches/zero-delta-fix.patch:
    - Deal with case in common/common.h where rgbToHsv is called with
    r,g,b all equal, giving max equal to min and so a zero delta
    (LP: #528872)

Revision history for this message
Niall Creech (sevenmachines-deactivatedaccount) wrote :

also affects the version in debian/testing 1.0.2-1 and the debian/unstable 1.1.1-1 version so i'll forward it if it proves an acceptable patch

Revision history for this message
Chow Loong Jin (hyperair) wrote :

Uploaded, thanks. Please forward the patch upstream as well. It looks like something that upstream would benefit from.

Changed in gtk2-engines-qtcurve (Ubuntu):
status: New → Fix Committed
Revision history for this message
Chow Loong Jin (hyperair) wrote :

Er sorry, looks like it was a package in main. I should really examine where these packages go before sponsoring them.

Changed in gtk2-engines-qtcurve (Ubuntu):
status: Fix Committed → Triaged
Revision history for this message
Chow Loong Jin (hyperair) wrote :

I am unsubscribing u-u-s and subscribing ubuntu-main-sponsors instead.

Revision history for this message
Jonathan Thomas (echidnaman) wrote :

I can sponsor this. I'll get it in with my merge of gtk2-engines-qtcurve from Debian.

Changed in gtk2-engines-qtcurve (Ubuntu):
assignee: nobody → Jonathan Thomas (echidnaman)
Revision history for this message
Niall Creech (sevenmachines-deactivatedaccount) wrote :

thanks to you both, apologies for subscribing universe, mistake on my part, rmadison was a little unclear and i didnt pay enough attention :) thank again

Revision history for this message
Jonathan Thomas (echidnaman) wrote :

You can track the progress of the merge at bug 529125. If I can't get the FFe approved I'll just upload your debdiff wholesale. Thanks for the patch.

Revision history for this message
Felix Geyer (debfx) wrote :

Should this patch still be applied (to version 1.5.1)?
Has it been submitted upstream?

Revision history for this message
Niall Creech (sevenmachines-deactivatedaccount) wrote :

still a problem in 1.5.1, i'll try and contact the author

Revision history for this message
Niall Creech (sevenmachines-deactivatedaccount) wrote :

i've contacted the author craig drummond and he's got a fix for this he'll be adding in future versions

Revision history for this message
Sebastien Bacher (seb128) wrote :

does the change there still needs sponsoring or should the sponsors be unsubscribed?

Revision history for this message
Niall Creech (sevenmachines-deactivatedaccount) wrote :

The coming fix upstream is the better one so i'm guessing the sponsors can be unsubscribed.

Revision history for this message
Jonathan Riddell (jr) wrote :

I see upstream has a new version out, 1.5.2. Don't know if this fix is in it though

Revision history for this message
Felix Geyer (debfx) wrote :

1.5.2 has been released before the bug was reported upstream.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk2-engines-qtcurve - 1.5.2-1ubuntu1

---------------
gtk2-engines-qtcurve (1.5.2-1ubuntu1) maverick; urgency=low

  * debian/patches/zero-delta-fix.patch:
    Deal with case in common/common.h where rgbToHsv is called with
    r,g,b all equal, giving max equal to min and so a zero delta (LP: #528872)
 -- Niall Creech <email address hidden> Sun, 15 Aug 2010 00:56:04 +0200

Changed in gtk2-engines-qtcurve (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.