FFE for nut 2.4.3

Ugh, seems we haven't updated this since Jaunty. This is a year worth of changes, and most look okay, but due to the sheer quantity of changes: How much has this version been tested in a lucid context? In particular, how does it work with our current udev/upower?

Unfortunately it hasnt been tested by me. I rather get Arnaud's thoughts on this.

chuck

guys,

2010/3/9 Chuck Short:
> Unfortunately it hasnt been tested by me. I rather get Arnaud's thoughts
> on this.

I've not been able to do much testing on DK-p and none UPower.

what I can say for the DK-p side (which theoretically should be
applicable to UPower) is:
- if a USB UPS is plugged, DK-p will take the hand on it.
- if NUT is then started, it will kick off DK-p (by detaching the
hiddev kernel driver, and so cutting the link used by DK-p), and will
take the hand on the device.
- if NUT is then stopped, you will have to unplug / replug your UPS'
USB cord to generate a new udev event so that DK-p probes the new
devices and restore the link to it.

So, I'm confident that this upload won't break DK-p or UPower, and
will fixe many things.

as a side note, I have a 2.4.3-2 underway which solves the bull**it
introduced by Scott James for refreshing the USB bus on postinst...
The result is that any USB user has to unplug / plug back his UPS' USB
cord to get udev apply the right rules.
ie, in nut.postint:
    udevadm trigger --action=change
should be replaced by
    udevadm trigger --subsystem-match=usb

though I've not finished investigation / work on this, and won't
commit on an upload date.
this is limited to new installation where the UPS is already plugged in.

I hope this helps...
Arnaud
--
Linux / Unix Expert R&D - Eaton - http://www.eaton.com/mgeops
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/

Arnaud Quette [2010-03-10 10:51 -0000]:
> as a side note, I have a 2.4.3-2 underway which solves the bull**it
> introduced by Scott James for refreshing the USB bus on postinst...
> The result is that any USB user has to unplug / plug back his UPS' USB
> cord to get udev apply the right rules.
> ie, in nut.postint:
> udevadm trigger --action=change
> should be replaced by
> udevadm trigger --subsystem-match=usb

Please replace it with

  udevadm trigger --subsystem-match=usb --action=change

Please do not *ever* add an udevadm trigger to a postinst with an
action other than "change". This will break a lot of boxes really
really hard.

Thanks!

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

OK, thanks for following up. Approved, but Chuck, please do not upload the dropping of "--action=change" into Ubuntu. Instead, nut's udev rules should be fixed to do their work on ACTION=="change" as well.

This bug was fixed in the package nut - 2.4.3-1ubuntu1

---------------
nut (2.4.3-1ubuntu1) lucid; urgency=low

  * Merge from debian testing. Remaining changes (LP: #535152):
    + debian/control:
      - Update maintainer as per spec.
      - Add Breaks on nut-hal-drivers to ensure we have correct udev version.
      - Drop libpowerman0-dev from the Build-Depends (currently in universe)
    + debian/{nut-cgi,nut}.postinst: add nut to the dialout and nut groups
      unconditonally to hanle the upgrade from hardy release.
    + debian/nut-powerman-pdu.install, debian/nut-powerman-pdu.manpages: dropped for now.
    + debian/nut.links: must create the init script link, used if the upse needs to be powered down
      (LP: #357583)
    + debian/nut.postinst: Update udevadm trigger.
    + Dropped:
      - debian/patches/02-fix-trust-pw4130m.dpatch: No longer needed.

nut (2.4.3-1) unstable; urgency=low

  * New upstream release (Closes: #544390, #528222, #539747, #526811,
    #562064)
  * debian/nut.install, debian/nut.manpages:
    - remove cyberpower driver and manpage
    - add bestfortress, clone and ivtscd drivers and manpages
  * debian/rules:
    - change udev dir to /lib/udev (Closes: #522327)
    - replace deprecated calls to 'dh_clean -k' by dh_prep (Closes: #536599)
  * debian/rules, debian/nut.install, debian/nut.install,
    debian/nut.README.Debian: install configuration files, without the
    sample suffix (Closes: #528641)
  * debian/nut.links: restored (Closes: #522506)
  * debian/nut.init:
    - source nut.conf instead of default/nut for POWEROFF_WAIT(Closes:
      #538173)
    - fix status checking (Closes: #538785)
    - improve detection of non configured system and beautify related
      output (Closes: #563112)
    - use 'invoke-rc.d' instead of calling the reboot script directly
    - add $remote_fs to Required-Start and Required-Stop
  * debian/nut.postrm: remove udev files and simplify cleanup (Closes:
    #541629)
  * debian/control:
    - remove Luca Filipozzi from the Uploaders list (Closes: #568987)
    - update Standards-Version to 3.8.4
    - remove the debconf dependency
    - bump debhelper version to (>= 7) in Build-Depends, for dh_prep
    - add Breaks on nut-hal-drivers to ensure we have correct udev version
  * Remove debconf support since it was related to really old nut
    version (Closes: #518056):
    - remove nut-cgi.config, nut.config, nut-cgi.templates, nut.templates,
      and po/ directory
    - update nut-cgi.postinst
  * debian/nut.dirs: remove /var/run/nut to conform to Debian Policy
  * debian/nut.postint:
    - create /var/run/nut if needed
    - improve security checks
  * debian/nut.README.Debian: add a security note for ups.conf
  * debian/watch: URL update
 -- Chuck Short <email address hidden> Tue, 16 Mar 2010 06:22:26 +0000

> please do not upload the dropping of "--action=change" into Ubuntu. Instead, nut's udev rules should be fixed to do their work on ACTION=="change" as well.

This wasn't done after all, so I uploaded another version to fix this:

nut (2.4.3-1ubuntu3) lucid; urgency=low

  * debian/nut.postinst: Revert dropping of --action=change. "add" events must
    not ever be triggered automatically.
  * Add 03_udev_rules_change.dpatch: Run udev rules on change events, too.

 -- Martin Pitt <email address hidden> Tue, 23 Mar 2010 08:00:53 +0100