Ubuntu
vim package

vim-gnome "swap already exists" dialog erroneously triggers hot corners

Bug #535341 reported by Joel Bradshaw on 2010-03-09

This bug affects 1 person

Affects		Status	Importance	Assigned to
	vim (Ubuntu)	Fix Released	Undecided	Unassigned
Nominated for Karmic by Mackenzie Morgan
Nominated for Lucid by Joel Bradshaw

Bug Description

Binary package hint: vim-gnome

This bug is described (and has been fixed) in Suse: https://bugzilla.novell.com/show_bug.cgi?id=392061

Ubuntu 9.10
Package: vim-gnome
Installed: 2:7.2.245-2ubuntu2

Expected: Swap dialog would just go away and let me continue working
Happened: Expo was triggered, requiring me to double-click back into my working desktop

Vim contains a workaround (called a "Terrible hack" in the source comments) for a KDE 3.1 bug that warps the mouse pointer off-screen and back. Unfortunately, this activates the upper-left hotcorner if the user has it configured. In Ubuntu, this is very often the case with Compiz. Personally, I have the Expo action mapped to it, so every time I close the "swap already exists" dialog, it zooms out and I have to click back into it.

The bug is in gui_gtk.c of the Vim source, and just needs a few lines commented out. I've attached a patch for that file that does just that.

I've send a bug report to the Vim team as well, but this is an easy-to-fix, low-risk bug that is highly perplexing and fairly disruptive to end-users, and affects anyone who:
1) Uses gVim/vim-gnome
2) Has an action mapped to the upper-left hotcorner.

As such, it would be nice to get fixed in Ubuntu's build of Vim, until Vim themselves take care of it.

Steps to reproduce:
1) Configure Compiz to map an action to the upper-left corner (such as Expo)
2) Open up gVim
3) Type ":e test<Return>" to start editing a test file and generate a swap file
4) Open another instance of gVim
5) Type ":e test<Return>" to attempt to edit the test file
6) Click "Edit Anyway" to dismiss the dialog
7) The action will be triggered.

It should be noted that opening two instances of Vim are not necessary to trigger the bug (it happens whenever a swap file is present), but it is the easiest way to reliably generate a swap file. Any files created can, of course, be deleted after the test.

Tags:

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-09:

patch file for gui_gtk.c in the Vim source Edit (607 bytes, text/plain)

Jeremy Foshee (jeremyfoshee) on 2010-03-10

tags:

added: kernel-series-unknown

Brian Murray (brian-murray) on 2010-03-10

tags:

added: patch

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-10: apport-collect data

Architecture: i386
CheckboxSubmission: 51409d673ef5a15bbb28f4473c48692f
CheckboxSystem: d00f84de8a555815fa1c4660280da308
DistroRelease: Ubuntu 9.10
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
NonfreeKernelModules: wl
Package: gnome-vim (not installed)
ProcEnviron:
SHELL=/bin/bash
PATH=(custom, user)
LANG=en_US.UTF-8
ProcVersionSignature: Ubuntu 2.6.31-19.56-generic
Uname: Linux 2.6.31-19-generic i686
UserGroups: adm admin cdrom dialout lpadmin mythtv plugdev sambashare

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-10: XsessionErrors.txt

XsessionErrors.txt Edit (7.1 KiB, text/plain)

tags:

added: apport-collected

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-10: apport-collect data

Architecture: i386
CheckboxSubmission: 51409d673ef5a15bbb28f4473c48692f
CheckboxSystem: d00f84de8a555815fa1c4660280da308
DistroRelease: Ubuntu 9.10
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
NonfreeKernelModules: wl
Package: vim-gnome 2:7.2.245-2ubuntu2
PackageArchitecture: i386
ProcEnviron:
SHELL=/bin/bash
PATH=(custom, user)
LANG=en_US.UTF-8
ProcVersionSignature: Ubuntu 2.6.31-19.56-generic
Uname: Linux 2.6.31-19-generic i686
UserGroups: adm admin cdrom dialout lpadmin mythtv plugdev sambashare

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-10: Dependencies.txt

Dependencies.txt Edit (5.1 KiB, text/plain)

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-10: XsessionErrors.txt

XsessionErrors.txt Edit (7.7 KiB, text/plain)

tags:

added: karmic
removed: kernel-series-unknown

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-10:

Sorry for the double-post, I ran apport the first time with the wrong package name, and can't seem to delete the first run. This bug also occurs on my work computer, which is also Karmic but is amd64. This bug should be platform-independent though, as long as it's GNOME and Vim. I updated the kernel series to be Karmic, sorry if that's not my place.

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-03-11:

I contacted the Vim bugs person simultaneously to filing this bug, and didn't expect such a quick response. But the fix went into Vim SVN yesterday:
http://vim.svn.sourceforge.net/viewvc/vim/vim7/src/gui_gtk.c?revision=1793&view=markup
So as long as Ubuntu uses a Vim from past that revision, no special patches are necessary. I'm not sure how Ubuntu compiles its Vim, but it's grabbed from a recent version of SVN, this bug can probably be closed.

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-04-26:

I checked the latest release over at Vim, and the package (and diffs) in Ubuntu's repos, and this hasn't been fixed in either place. It's in Vim's SVN, but I'm not sure what Vim's release cycle is, or what the process is to update a package in Ubuntu's repos.
This is a pretty straightforward, easy-to-fix issue that could be rolled into the diff file for Ubuntu in the meantime. Is there a possibility of this being done in the near future? It's not a frequent issue - an edge case to be sure - but with Compiz being installed by default in Ubuntu, it's something that should be fixed, especially when it's as small and certain as removing code that is clearly labelled a terrible hack, and only a terrible hack.

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-04-26:

#10

I did a little more investigating, and the source version on Vim's site is 7.2.269, the one in Ubuntu repos for Karmic is 7.2.245, Lucid is 7.2.330, and this fix was instituted in 7.2.386. Will it just have to wait for the next release to be bumped up beyond 386, or can the package be updated between releases?

Changelog at Vim w/ fix and version number:
http://vim.svn.sourceforge.net/viewvc/vim?view=rev&revision=1793

Revision history for this message

Chow Loong Jin (hyperair) wrote on 2010-05-05:

#11

As per the last comment (#10), I'm changing the patch tag to patch-accepted-upstream to reflect its status.

tags:	added: patch-accepted-upstream removed: patch
Changed in vim (Ubuntu):
status:	New → Fix Committed
tags:	added: patch

Revision history for this message

Joel Bradshaw (cincodenada) wrote on 2010-11-06:

#12

I just upgraded to Maverick, and vim-gnome is still at 7.2.330. When will the gnome-vim package be upgraded to a more recent version of Vim? The current version of vim-gnome in Maverick still has this bug.

Revision history for this message

Michael Bienia (geser) wrote on 2010-11-06:

#13

vim 7.3.035 is awaiting sponsoring to "natty" (bug 662276). Once it's in natty you can try to request a backport of it to "maverick" to get a newer version of vim. https://help.ubuntu.com/community/UbuntuBackports describes the process for it.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-11-24:

#14

Download full text (8.7 KiB)

This bug was fixed in the package vim - 2:7.3.035+hg~8fdc12103333-1ubuntu1

---------------
vim (2:7.3.035+hg~8fdc12103333-1ubuntu1) natty; urgency=low

  * Merge with Debian unstable (lp: #662276):
    - Use case-insensitive matching for month and day of week names in
      crontab's syntax file (lp: #517019 aka Debian bug #568378).
    - Fix sqlcomplete's <Left>/<Right> maps so they don't interfere with
      normal usage (lp: #584797 aka Debian bug #560083).
    - [7.2.386] KDE 3.1 focus hack causes problems for other window managers
      (lp: #535341).
  * Remaining changes:
    - debian/control:
      + Drop vim-lesstif package and lesstif2-dev build-dependency.
      + Rename Vcs-* to XS-Debian-Vcs-*.
    - debian/rules:
      + Don't build the vim-lesstif variant in Ubuntu.
    - debian/runtime/debian.vim.in:
      + Add Launchpad integration to the Help menu if launchpad-integration is
        installed.
    - debian/runtime/vimrc:
      + "syntax on" is a sane default for non-tiny vim
    - debian/patches/debian/ubuntu-grub-syntax.patch:
      + Add Ubuntu-specific "quiet" keyword.

vim (2:7.3.035+hg~8fdc12103333-1) unstable; urgency=low

  * Pull patches 001 - 035.
    + More robust YAML highlighting. (Closes: #535682)
  * debian/rules:
    + Stop overriding CFLAGS on the command-line when invoking make. Upstream
      enforces an upper-limit of 1 for _FORTIFY_SOURCE due to the use of
      flexible arrays in nested structs, which improperly cause Vim to crash
      with _FORTIFY_SOURCE=2.
    + Use DEB_HOST_ARCH_OS instead of DEB_HOST_GNU_SYSTEM to determine whether
      Linux-specific functionality is enabled.
    + Use dpkg-vendor to change build configuration when building on Ubuntu.
      Thanks to Michael Bienia for the patch.
  * Make helpztags capable of generating tags files for non-English help
    files. (Closes: #600248)
  * Debian runtime:
    + Add natty as a recognized distribution. (Closes: #600560)
    + Add metapackages as a recognized section. (Closes: #600562)
    + Remove etch as a recognized distribution.
  * debian/control: Add dpkg-dev (>= 1.15.1) Build-Depends for dpkg-vendor.

vim (2:7.3.000+hg~ee53a39d5896-1) unstable; urgency=low

  * New upstream release.
  * debian/rules:
    + Explicitly use the dynamic loading Python interfaces.
    + Remove cleanup from clean target which are now properly handled by
      upstream's Makefile.
  * Update version information in documentation.

vim (2:7.3f.20100812+hg~20e83abf88b1-1) experimental; urgency=low

  * Merge latest 7.3f pre-release.
    + Correctly restore multi-byte terminal titles when exiting Vim. (Closes:
      #558153)
    + Highlight text inside math zones correctly for tex files. (Closes:
      #509908)
    + Recognize nested cite regions in tex files. (Closes: #444288)
    + Support syntax highlighting of bash's $"". (Closes: #473736)
  * Patches merged upstream:
    + perl-indent-block.patch
    + logcheck-ftplugin.patch
    + tex-syntax-verbatim-spell.patch
  * Enable Lua scripting.
    + Add liblua5.1-0-dev and lua5.1 to Build-Depends.
    + Enable lua interface via dynamic loading.
  * Switch Perl interface to dynamic loading.
  * debi...

This bug was fixed in the package vim - 2:7.3.035+hg~8fdc12103333-1ubuntu1

---------------
vim (2:7.3.035+hg~8fdc12103333-1ubuntu1) natty; urgency=low

vim (2:7.3.035+hg~8fdc12103333-1) unstable; urgency=low

* Pull patches 001 - 035.
    + More robust YAML highlighting.  (Closes: #535682)
  * debian/rules:
    + Stop overriding CFLAGS on the command-line when invoking make.  Upstream
      enforces an upper-limit of 1 for _FORTIFY_SOURCE due to the use of
      flexible arrays in nested structs, which improperly cause Vim to crash
      with _FORTIFY_SOURCE=2.
    + Use DEB_HOST_ARCH_OS instead of DEB_HOST_GNU_SYSTEM to determine whether
      Linux-specific functionality is enabled.
    + Use dpkg-vendor to change build configuration when building on Ubuntu.
      Thanks to Michael Bienia for the patch.
  * Make helpztags capable of generating tags files for non-English help
    files.  (Closes: #600248)
  * Debian runtime:
    + Add natty as a recognized distribution.  (Closes: #600560)
    + Add metapackages as a recognized section.  (Closes: #600562)
    + Remove etch as a recognized distribution.
  * debian/control: Add dpkg-dev (>= 1.15.1) Build-Depends for dpkg-vendor.

vim (2:7.3.000+hg~ee53a39d5896-1) unstable; urgency=low

vim (2:7.3f.20100812+hg~20e83abf88b1-1) experimental; urgency=low

* Merge latest 7.3f pre-release.
    + Correctly restore multi-byte terminal titles when exiting Vim.  (Closes:
      #558153)
    + Highlight text inside math zones correctly for tex files.  (Closes:
      #509908)
    + Recognize nested cite regions in tex files.  (Closes: #444288)
    + Support syntax highlighting of bash's $"".  (Closes: #473736)
  * Patches merged upstream:
    + perl-indent-block.patch
    + logcheck-ftplugin.patch
    + tex-syntax-verbatim-spell.patch
  * Enable Lua scripting.
    + Add liblua5.1-0-dev and lua5.1 to Build-Depends.
    + Enable lua interface via dynamic loading.
  * Switch Perl interface to dynamic loading.
  * debian/rules: Prefer running tests with the vim-nox binary if it's
    available.
  * Bump Standards-Version to 3.9.1.0 -- no changes needed.

vim (2:7.3b.20100720+hg~7b7508ee56f1-1) experimental; urgency=low

* Merge 7.3b pre-release.
    + Don't run autocommands when being killed to avoid overrunning the stack.
      (Closes: #580961)
    + Detect when the recovered buffer matches the on-disk file and notify the
      user.  (Closes: #89359)
    + Update CMake runtime files.  (Closes: #463715)
    + Correctly set timestamp for X selection transfers.  (Closes: #577035)
    + Improve 'cindent's handling of javascript.  (Closes: #588875)
    + Correctly displays characters inserted via digraph sequences which wrap
      to a new line.  (Closes: #442184)
  * Patches merged upstream:
    + it-manpage-fixes.patch
    + lang-breaks-floating-point.patch
    + python-modlibs.patch:
      - Remove autoconf Build-Depends as configure.in isn't being patched
        anymore.
      - Remove autoconf-stamp pre-requisite for configure-stamp-% target.
  * Update debian/rules to handle the snapshot versioning.
  * Enable Python3 language interface.
    + Add python3-dev to Build-Depends.
    + Pass --enable-python3interp to configure when building variants with
      language interfaces enabled.

vim (2:7.2.445+hg~cb94c42c0e1a-1) unstable; urgency=low

* debian/control:
    + Use Breaks instead of Conflicts for the gvimtutor move.
    + Use linux-any wildcards for linux-specific Build-Depends.  (Closes:
      #587866)
    + Bump Standards-Version to 3.9.0.0.
  * Pull patches 439 - 445.
  * runtime/ftplugin/debchangelog.vim: Use “silent!” to avoid errors when
    disabling the menu.  Thanks to Jan Christoph Ebersbach for the patch.

vim (2:7.2.438+hg~d44112feb815-5) unstable; urgency=low

* Rework the diversion handling again.
    + vim-runtime.preinst: Add diversion on major version upgrades.
    + vim-runtime.postrm: Remove old diversion on major version upgrades.
    + vim-runtime Breaks vim-tiny less than the current source version.

vim (2:7.2.438+hg~d44112feb815-4) unstable; urgency=low

* vim-runtime.preinst: Use the right function name for removing diversions
    when upgrading across major versions.

vim (2:7.2.438+hg~d44112feb815-3) unstable; urgency=low

* vim-runtime.preinst:
    + Remove code handling the Etch->Lenny diversion fixup.
    + Add handling of diversions when upgrading across major versions.
  * vim-runtime.postrm: Remove diversions on abort-install and disappear.
  * Move gvimtutor to vim-gui-common from vim-runtime. (LP: #484851)
  * debian/control: Remove versioned relationships which are satisified in
    Lenny.

vim (2:7.2.438+hg~d44112feb815-2) unstable; urgency=low

* Fix FTBFS with parallel builds and using the autoconf target to update the
    configure script.

vim (2:7.2.438+hg~d44112feb815-1) unstable; urgency=low

* Pull patches 437 - 438.
    + 7.2.438: Fix crash when running “vim -r”.  (Closes: #583122)
  * Cherry-pick upstream/lang-breaks-floating-point.patch from upstream to
    prevent floating point functionality from breaking when the :lang command
    is issued.  (Closes: #582421)
  * Fix building against Debian's Python 2.6 package.  (Closes: #566842)
    + Cherry-pick upstream/python-modlibs.patch from upstream.
    + debian/control: Add autoconf to Build-Depends.
    + debian/rules: Re-generate configure at build time and remove on clean.

vim (2:7.2.436+hg~e12b9d992389-1) unstable; urgency=low

* Pull patches 331 - 436.
    + 7.2.367: Make xxd follow documented behavior when using “-r -p”.
      (Closes: #567041)
    + 7.2.405: Re-enable default value for IncSearch to allow highlighting of
      matched text when using :substitute's c flag.  (Closes: #572994)
    + 7.2.413: Largefile support for all Vim packages.  (LP: #128494)
    + 7.2.426: Require literal commas be escaped in 'langmap'.  (Fixes
      #233008, obviating upstream/langmap-comma-parsing.patch)
    + 7.2.429: Specifically check for ENOENT to decide a file doesn't exist.
      Also fixes the check for EFBIG/EOVERFLOW.  (Closes: #430205, #139510)
    + Updated runtime files:
      - Fix sqlcomplete's <Left>/<Right> maps so they don't interfere with
        normal usage.  (Closes: #560083)
      - Recognize Perl 5.10's “state” keyword.  (Closes: #499644)
      - Handle a wider variety of quoting operators in Perl.  (Closes:
        #561080)
  * debian/control:
    + Update Vcs-* to point to the Mercurial repository.
    + Bump Standards-Version to 3.8.4, no changes needed.
  * vim-policy: Update links to package descriptions and repository.
  * Reword presubj to provide a few methods for narrowing down the bug's
    cause.
  * debian/rules:
    + Specify STRIP=: when running upstream's install targets to prevent
      upstream's automatic stripping.
    + Pass the --with-modified-by to the Debian Vim maintainers list.
    + Remove git helper targets.
    + Remove get-orig-source target and related variables, since we're just
      using the upstream Mercurial repository.
  * debian/source/format: Switch to “3.0 (quilt)”.
  * debian/README.source: Update description according to the change to
    Mercurial and use of “3.0 (quilt)” source format.
  * runtime/ftplugin/debchangelog.vim: Update completion of Ubuntu bugs based
    on a patch from Michael Bienia.  (Closes: #566841)
  * runtime/syntax/{debchangelog,debsources}.vim: Remove intrepid and add
    maverick to the set of Ubuntu releases.
  * Use case-insensitive matching for month and day of week names in crontab's
    syntax file.  Thanks to Chris Butler for the patch.  (Closes: #568378)
 -- Michael Bienia <geser@ubuntu.com>   Mon, 25 Oct 2010 10:55:05 +0200