trunk: install button does not become sensitive, when valid source image is selected

Bug #582531 reported by Alexander Clausen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
usb-creator (Ubuntu)
Fix Released
Low
Dimitri John Ledkov

Bug Description

Binary package hint: usb-creator

in revision 303, the following change was made:

=== modified file 'usbcreator/frontends/gtk/frontend.py'
--- usbcreator/frontends/gtk/frontend.py 2010-04-06 14:05:41 +0000
+++ usbcreator/frontends/gtk/frontend.py 2010-04-19 13:05:23 +0000
@@ -443,10 +443,15 @@
         # Update install button state.
         status = target['status']
         source = self.backend.get_current_source()
+ if status == CAN_USE:
+ self.button_install.set_sensitive(True)
+ else:
+ self.button_install.set_sensitive(False)
         if not source:
             return
         stype = self.backend.sources[source]['type']
- if status == CAN_USE or stype == SOURCE_IMG:
+ if (self.button_install.get_property('sensitive')
+ and stype == SOURCE_IMG):
             self.button_install.set_sensitive(True)
         else:
             self.button_install.set_sensitive(False)
------------------------------------------------------------

the second part disables the "Make Startup Disk" button if the source is an ISO file. Shouldn't that be an 'or', like in the previous revision?

Tags: patch

Related branches

Revision history for this message
Alexander Clausen (alex-gc-web) wrote :
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

=)))

Confirm the issue & Agree with the patch.

Changed in usb-creator (Ubuntu):
status: New → Confirmed
Revision history for this message
Roderick B. Greening (roderick-greening) wrote :

Please show your test cases for demonstrating this patch works as desired. The logic may not cover all bases as you may think.

This commit was submitted to fix a specific issue, which altering the 'and' to 'or' may re-introduce. It needs to be tested with at least the following:

1) No usb/sd card inserted prior to startup and insertion of the usb/sd card both before and after selecting the ISO image.
2) Insert usb/sd card prior to startup and then selecting the ISO image.

Repeating the above two tests and performing a format on the usb/sd card should also be tested. In all cases, the startup button should be disabled if you do not have a valid target and source selected at the same time. The 'and' in the above commit says if I have a valid target (CAN_USE) AND it's a valid source. The 'or' used to break things differently.

I think the issue is bigger than what you see here.

Revision history for this message
Dimitri John Ledkov (xnox) wrote : Re: [Bug 582531] Re: trunk: startup disk creation from .ISO files fails

On 19 May 2010 19:43, Roderick B. Greening <email address hidden> wrote:
> I think the issue is bigger than what you see here.
>

Fair enough I will do all of them with and without the patch. But with
current trunk I can't get the make startup-disk to be activatable at
all with any combinations I've tried.

Will report of test results.

Revision history for this message
Dimitri John Ledkov (xnox) wrote : Re: trunk: startup disk creation from .ISO files fails

Alexander Clausen, exactly which source ISO or IMG have you been using to reproduce this problem?

Roderick B. Greening, the test checks that source is SOURCE_ISO but doesn't check for SOURCE_IMG at least on my machine it seems that ubuntu-8.10-desktop-x86 and debian-6.0-squeeze alpha dvd don't work with current trunk, but work with the branch linked to this bug where I'm checking if source is of type ISO or IMG.

lp:~dmitrij.ledkov/usb-creator/really

summary: - trunk: startup disk creation from .ISO files fails
+ trunk: install button does not become sensitive, when valid source image
+ is selected
Revision history for this message
Alexander Clausen (alex-gc-web) wrote :

Ubuntu Netbook edition, ubuntu-10.04-netbook-i386.iso

Changed in usb-creator (Ubuntu):
assignee: nobody → Dmitrijs Ledkovs (dmitrij.ledkov)
Revision history for this message
Dimitri John Ledkov (xnox) wrote : Re: [Bug 582531] Re: trunk: install button does not become sensitive, when valid source image is selected

Here are some of the screenshot tests.
r311* are the lp:usb-creator r311 examples of showing the problem
lp-really are some of my tests I did with preliminary patch.
Pushing final fix branch & doing merge proposal now.

This bug has caused me banging my head against the desk when trying to
get CLI frontend going & doing stress testing usb-creator against
various ubuntu & debian images.

See merge-proposal for more details =)

tags: added: patch
Victor Vargas (kamus)
Changed in usb-creator (Ubuntu):
importance: Undecided → Low
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-creator - 0.2.23

---------------
usb-creator (0.2.23) maverick; urgency=low

  [ Evan Dandrea ]
  * Continue evaluting whether or not a partition can be used even if
    there is no source present (LP: #566390).
  * Change the team from the Installer Team to usb-creator Hackers to
    match the bzr ACL.

  [ Colin Watson ]
  * Make usb-creator-common depend on parted (LP: #529366).

  [ Roderick B. Greening ]
  * Fix cannot resize usb-creator-kde main window (LP: #580551).
  * Update branding on KDE Icon (LP: #580558).
  * Switch from exists to isfile detection in backend (LP: #608741)
  * Bump version strings to 0.2.23

  [ Dmitrijs Ledkovs ]
  * desktop:
    + removed obsolete encoding keys from desktop files
  * man:
    + fixed hyphens, minus signs & undefined macros
    + removed non-working "-v" flag from usb-creator-gtk.8 (LP: #574089)
  * po:
    + translations dump from lucid. (LP: #570174)
  * debian/usb-creator-common.install:
    + install translations (for ppa's, archive will strip them)
  * debian/source:
    + using 3.0 (native) format
  * debian/copyright:
    + updated to DEP-5 format
  * debian/control:
    + removed transitional package (LTS is released)
    + improved extended description
    + added forgotten python-support dependency
    + updated descriptions (thanks Matthew Paul Thomas)
  * debian/rules:
    + using dh tiny rules
    + using python-support
    + vendor branded icons installed if available
    + debian-menu installed if there are branded xpm's
  * .bzr-builddeb:
    + defaults to native

  * Use XDG_CACHE_DIR for usb-creator.log
  * Use XDG IconTheme spec for window icons (LP: #535061)
  * Fix install button sensetivity (LP: #582531)

  [ Ignace Mouzannar ]
  * Initial Debian release (Closes: #582884, #576359)
  * debian/control:
    + Added Build dependency on kdesdk-scripts (Debian specific)
  * debian/usb-creator-gtk.menu and debian/usb-creator-kde.menu:
    + Added these files as per the Debian Menu Policy
  * debian/Debian/*.xpm:
    + Added the xpm icons needed by the menu files
  * debian/copyright:
    + Added myself in the debian/* copyright

  [ Jonathan Riddell ]
  * Fix kde/frontend.py for PyQt 4.7 which now expects a string not a
    QString for loadUi
 -- Evan Dandrea <email address hidden> Tue, 03 Aug 2010 10:49:34 -0400

Changed in usb-creator (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.