Non-square items dont properly darken

fixed with bzr 1592

Docky 2.0.6 was released recently and should be considered for a SRU!

docky (2.0.6-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release 2.0.6 "Just lovin' it",
    changes include:
    + fix check for existing instance
    + hitting ESC should cancel drags (LP: #460071)
    + make sure plugins enabled by default are added to the dock on first run
      and enable Trash docklet by default
    + update badge drawing so the text is consistently sized
    + fix leak of ThemedIcon/FileIcon in IconFromGIcon
    + fix non-square items arent properly darken (LP: #584094)
    + remove MenuList.Dispose which is not really needed, solves (LP: #609170)
    + shrink config dialog (LP: #591448)

    + RecentDocs: fix crash (LP: #580723)
    + Mounter: use a better MountItem.UniqueID and don't fill up gconf with
      useless keys (temporary fix for LP: #600311)
    + Weather: add weather icon for Smoke (LP: #612437)
    + CPUMonitor: fix CPU utilization percentage (LP: #604677)
    + GMail:
      - add debuging messages to gmail and log web response status when we
        have a web exception
      - fix crash and leak in Gmail

 -- Rico Tzschichholz <email address hidden> Wed, 01 Sep 2010 10:20:15 +0200

"bzr diff -r tag:2.0.5..tag:2.0.6 | filterdiff -x "*.po*" | diffstat":
 Docky.Items/Docky.Items.csproj | 4
 Docky.Items/Docky.Items/AbstractDockItem.cs | 99 +++++-----
 Docky.Items/Docky.Menus/MenuList.cs | 14 -
 Docky.Items/Docky.Menus/RelatedFileMenuItem.cs | 52 -----
 Docky.Items/Makefile.am | 1
 Docky.Services/Docky.Services/DrawingService.cs | 14 -
 Docky/Docky/DockController.cs | 1
 Docky/Docky/Docky.cs | 10 +
 Docky/Docky/Interface/DockDragTracker.cs | 29 ++
 Docky/Docky/Interface/DockPreferences.cs | 16 +
 Docky/Docky/Interface/DockWindow.cs | 2
 Docky/Docky/PluginManager.cs | 2
 Docky/docky.in | 6
 Docky/gtk-gui/Docky.ConfigurationWindow.cs | 4
 Docky/gtk-gui/gui.stetic | 2
 NEWS | 28 ++
 StandardPlugins/CPUMonitor/src/CPUMonitorDockItem.cs | 37 +--
 StandardPlugins/GMail/src/GMailAtom.cs | 31 ++-
 StandardPlugins/GMail/src/GMailItemProvider.cs | 2
 StandardPlugins/GMail/src/GMailLabel.cs | 22 +-
 StandardPlugins/Mounter/src/MountItem.cs | 2
 StandardPlugins/RecentDocuments/src/RecentDocumentsItem.cs | 16 -
 StandardPlugins/Trash/Resources/Trash.addin.xml.in | 2
 StandardPlugins/Weather/src/Sources/WeatherChannelWeatherSource.cs | 1
 configure.ac ...

Rico,

thanks for preparing this. Most changes look reasonable for an SRU, but I have a question about this part:

--- docky-2.0.5/StandardPlugins/Trash/Resources/Trash.addin.xml 2010-07-01 18:05:38.000000000 +0100
+++ docky-2.0.6/StandardPlugins/Trash/Resources/Trash.addin.xml 2010-09-01 07:11:01.000000000 +0100
@@ -3,7 +3,7 @@
        namespace="Docky"
        version="1.0"
        isroot="false"
- defaultEnabled="false"
+ defaultEnabled="true"
        name="Trash"
        description="Have a look at your trash!"
        author="Chris Szikszoy, Robert Dyer"

This looks like it'd change existing behaviour and possibly even UI?

@Martin: Yes, this enables the Trash docklet by default if docky is started the first time. This makes it easier for new users to understand the purpose of docky better which is to replace the bottom gnome-panel.

And the other way around, if an user has started docky before, does it write a per-user configuration where this isn't enabled?

No, this is only applied if docky is running the first time which is checked with a gconf-key. So if there are no settings available this default setting will take place.

Accepted docky into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

This bug was fixed in the package docky - 2.0.6-2

---------------
docky (2.0.6-2) unstable; urgency=low

  * Upload to unstable.

docky (2.0.6-1) experimental; urgency=low

  * New upstream release 2.0.6 "Just lovin' it",
    changes include:
    + fix check for existing instance
    + hitting ESC should cancel drags (LP: #460071)
    + make sure plugins enabled by default are added to the dock on first run
      and enable Trash docklet by default
    + update badge drawing so the text is consistently sized
    + fix leak of ThemedIcon/FileIcon in IconFromGIcon
    + fix non-square items arent properly darken (LP: #584094)
    + remove MenuList.Dispose which is not really needed, solves (LP: #609170)
    + shrink config dialog (LP: #591448)

    + RecentDocs: fix crash (LP: #580723)
    + Mounter: use a better MountItem.UniqueID and don't fill up gconf with
      useless keys (temporary fix for LP: #600311)
    + Weather: add weather icon for Smoke (LP: #612437)
    + CPUMonitor: fix CPU utilization percentage (LP: #604677)
    + GMail:
      - add debuging messages to gmail and log web response status when we
        have a web exception
      - fix crash and leak in Gmail
  * debian/patches:
    + drop 01_use_cli_for_wrapper.patch
  * patch build-system and bump dependency for new gio-sharp >= 2.22.2
    + update debian/patches/use-system-gio-sharp.patch
 -- Iain Lane <email address hidden> Tue, 07 Sep 2010 09:03:13 +0100

SRU verification for Lucid:
I have reproduced the problem with docky 2.0.5-0ubuntu1 in lucid-updates and have verified that the version of docky 2.0.6-0ubuntu1 in -proposed fixes the issue.

Marking as verification-done

This bug was fixed in the package docky - 2.0.6-0ubuntu1

---------------
docky (2.0.6-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release 2.0.6 "Just lovin' it",
    changes include:
    + fix check for existing instance
    + hitting ESC should cancel drags (LP: #460071)
    + make sure plugins enabled by default are added to the dock on first run
      and enable Trash docklet by default
    + update badge drawing so the text is consistently sized
    + fix leak of ThemedIcon/FileIcon in IconFromGIcon
    + fix non-square items arent properly darken (LP: #584094)
    + remove MenuList.Dispose which is not really needed, solves (LP: #609170)
    + shrink config dialog (LP: #591448)

    + RecentDocs: fix crash (LP: #580723)
    + Mounter: use a better MountItem.UniqueID and don't fill up gconf with
      useless keys (temporary fix for LP: #600311)
    + Weather: add weather icon for Smoke (LP: #612437)
    + CPUMonitor: fix CPU utilization percentage (LP: #604677)
    + GMail:
      - add debuging messages to gmail and log web response status when we
        have a web exception
      - fix crash and leak in Gmail
 -- Rico Tzschichholz <email address hidden> Wed, 01 Sep 2010 10:20:15 +0200