when changing the background colors of the theme Ambiance, the window buttons change side (into the right) automatically

Thank you BG for reporting this bug.
I have been trying to reproduce your bug, but I am missing some information.
Could you precisely list down the steps you did to reproduce the bug?
This is what I did to try to reproduce your bug:

1. In the Control Panel, click on System->Preferences->Apperance (it opens Apperance Preference window).
2. From the Theme tab, select Ambiance
3. At the bottom, click on Customize (it opens Customize Theme window)
4. From the Colours tab, click on the colour button of Windows and Background and set the color name to something very dark: #231D11.
5. Select OK to apply the new colour.
6. Open firefox.

Expected value: the windows minimize, maximize and close button should be on the left.

This is what I get so far. Please provide more details so that I can reproduce the bug.

Hi David,

Those steps were almost complete, but it is my fault for not providing
them the first place.
So after your step #5, this is what I do to reproduce the bug:
6. Save custom theme with name "SomeThemeName" (buttons are in the left
side);
7. Change back to Ambiance theme (buttons are in the left side);
8. Change to "SomeThemeName" theme (now the buttons change to the right
side);

The bug report automatically associated with firefox (maybe I did
something wrong), but I think it has nothing to do with it.

Hope it helps, and thank you for dedicating your time to correct these
bugs!!

Best,

Bruno Guerreiro

On 06/04/2010 07:49 AM, David Ly-Gagnon wrote:
> Thank you BG for reporting this bug.
> I have been trying to reproduce your bug, but I am missing some information.
> Could you precisely list down the steps you did to reproduce the bug?
> This is what I did to try to reproduce your bug:
>
> 1. In the Control Panel, click on System->Preferences->Apperance (it opens Apperance Preference window).
> 2. From the Theme tab, select Ambiance
> 3. At the bottom, click on Customize (it opens Customize Theme window)
> 4. From the Colours tab, click on the colour button of Windows and Background and set the color name to something very dark: #231D11.
> 5. Select OK to apply the new colour.
> 6. Open firefox.
>
> Expected value: the windows minimize, maximize and close button should
> be on the left.
>
> This is what I get so far. Please provide more details so that I can
> reproduce the bug.
>
>

Thanks for your quick reply BG.
I can now confirm the bug. I think the source of the bug is compiz since the bug appears in any window, not just from Firefox.
I am using compiz:1:0.8.4-0ubuntu15.

The following steps can be used to reproduce the bug:
1. In the Control Panel, click on System->Preferences->Apperance (it opens Apperance Preference window).
2. From the Theme tab, select Ambiance
3. At the bottom, click on Customize (it opens Customize Theme window)
4. From the Colours tab, click on the colour button of Windows and Background and set the color name to anything else, e.g.: #231D11.
5. Select OK to apply the new colour. This will create a new custom theme based on the Ambiance theme.
6. Click "Save As" button located at the bottom of the "Appearance Preferences" Window.
7. Give it a new name, e.g.: custom_theme. and click "Save".
At this point, the close, maximize, and minimize buttons appears on the top left side of the window.
8. Now, change back to the Ambiance theme.
9. Change back to the custom_theme.
10. Observe where the close, maximize and minimize buttons are located. I can see they are now on the right.

Actual output: The close, maximize and minimize buttons are located on the right side of the window.
Expected output: The close, maximize and minimze buttons should be located on the left side of the window.

I am setting the status to confirmed.

Thank you,

Actually this is gnome-appearance-properties automatically changing the settings for button position based on the theme name.

This bug still exists in Maverick.
I've compared index.theme from custom theme (~/.themes/<custom_theme>/index.theme) with original Radiance index.theme (/usr/share/themes/Radiance/index.theme). The original file has line "ButtonLayout=close,minimize,maximize:" while custom doesn't. I suppose gnome-appearance-properties should have copied that line to the custom theme file.
As a workaround you can add this line to your custom index.theme manually.

Thanks Dmitry for your work on this! As this fix is not Ubuntu specific, we should also send it upstream, so that other GNOME users can benefit from it as well, and we don't have to maintain the fix in Ubuntu forever. Can you please open a bug at

  https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-control-center

and attach the description and patch there?

Thank you!

Actually, I just tested this procedure in current natty, and the button order is already maintained in the custom theme, so perhaps this already got fixed upstream? Can you confirm?

Also, remember that the appearance settings has been removed entirely from gnome-control-center 3.0 now

I've just tested it with the latest natty image (via TestDrive) and the bug is still present. Martin, are you sure that you did everything like comment #4 says? Notice that you have to *select* the new theme after saving it. Steps 8-9 of the procedure say to change to Ambiance and then back to new theme, but actually clicking on the thumbnail of the new theme is enough.
BTW this bug is also present in maverick and lucid, but it is probably not important enough for SRU.

Actually the fix *is* Ubuntu specific because it only changes debian/patches/52_button_layout_from_theme.patch which is Ubuntu specific. AFAIK theme's preferred button layout (through X-GNOME-Metatheme/ButtonLayout index file key) was introduced in lucid and isn't supported upstream and in Debian.

Ah, sorry, it indeed happens here. When I switch to the new theme, the buttons keep being on the left initially, and then some ten seconds later then switch to the right. So it seems yesterday I just didn't wait long enough, sorry.

So the fix will be approved? Just want to make sure that no further actions are required from me.

Dmitry Andreychuk [2011-02-07 18:12 -0000]:
> So the fix will be approved? Just want to make sure that no further
> actions are required from me.

Yep, we'll review it in the next sponsoring rounds.

Thanks, Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

This bug was fixed in the package gnome-control-center - 1:2.32.1-0ubuntu4

---------------
gnome-control-center (1:2.32.1-0ubuntu4) natty; urgency=low

  [ Sebastien Bacher ]
  * Drop icons which were used in the desktop effect tab

  [ Dmitry Andreychuk ]
  * debian/patches/52_button_layout_from_theme.patch:
    - when saving custom theme to file also save current button
      layout (LP: #589377)
    - process button layout in theme_load_from_gconf()
    - fixed copying button layout to custom theme
 -- Ken VanDine <email address hidden> Thu, 10 Feb 2011 13:13:30 -0500

I reproduced this and verified the patch fixes it. Merged into the packaging branch lp:~ubuntu-desktop/gnome-control-center/ubuntu/ and sponsored.

Thanks for the patch!

Martin, Ken, thank you for the sponsorship!