openafs-modules-dkms leaves ~empty make.log on failing builds

Bug #593509 reported by Anders Kaseorg
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DKMS
Fix Released
Undecided
Unassigned
dkms (Debian)
Fix Released
Unknown
dkms (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

When openafs-modules-dkms fails to build a kernel module, the only trace it leaves behind in make.log is two lines:

DKMS make.log for openafs-1.4.12.1 for kernel 2.6.31-10-rt (x86_64)
Mon Jun 14 00:34:16 EDT 2010

In fact, the make processes during the build have fds 0,1,2 open to /dev/null, as can be seen from /proc/PID/fd.

This makes it difficult to diagnose apport-reported build failure bugs, like bug 539450.

Revision history for this message
Russ Allbery (rra-debian) wrote :

I'm fairly sure that the openafs package itself doesn't do anything here. The dkms.conf file is very simple. This sounds like a bug in dkms. I reassigned a similar bug on the Debian side to dkms, and IIRC there were several other similar bugs already reported.

Anders Kaseorg (andersk)
affects: openafs (Ubuntu) → dkms (Ubuntu)
Changed in dkms (Debian):
status: Unknown → New
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

The problem is not with dkms but with the make command in dkms.conf of the openafs module.

Here is a patch
--- dkms.conf.orig 2010-08-05 23:47:56.446432083 +0200
+++ dkms.conf.new 2010-08-05 23:47:40.626934117 +0200
@@ -8,7 +8,7 @@
 DEST_MODULE_LOCATION[0]="/updates/dkms/"
 AUTOINSTALL=yes

-MAKE[0]="./configure --with-linux-kernel-headers=${kernel_source_dir}
+MAKE[0]="( ./configure --with-linux-kernel-headers=${kernel_source_dir}
     && make
- && mv src/libafs/MODLOAD-*/openafs.ko . "
+ && mv src/libafs/MODLOAD-*/openafs.ko . )"
 CLEAN="rm -f openafs.ko && make -C src/libafs clean"

In the current version of dkms.conf we are logging the output of the command mv

Changed in dkms (Ubuntu):
importance: Undecided → Low
status: New → Triaged
affects: dkms (Ubuntu) → openafs (Ubuntu)
Revision history for this message
Russ Allbery (rra-debian) wrote :

Ah, interesting. So dkms isn't running the command in a subshell and therefore is failing to redirect output properly.

I think that's a bug in dkms, but I can work around that bug with the patch you indicate in openafs. It would be nice to have the bug fixed in dkms, though.

Revision history for this message
Anders Kaseorg (andersk) wrote :

I sent a dkms patch to the Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577972

Revision history for this message
Mario Limonciello (superm1) wrote :

I've added this patch to trunk (it had to be updated a little bit to apply however).

You can see it at 705d2bcb5ee44bcf0440e66ef66bed68a6b22f1d.

affects: openafs (Ubuntu) → dkms (Ubuntu)
Changed in dkms (Ubuntu):
status: Triaged → Fix Committed
Changed in dkms:
status: New → Fix Committed
Changed in dkms (Debian):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkms - 2.2.0.1-0ubuntu1

---------------
dkms (2.2.0.1-0ubuntu1) oneiric; urgency=low

  * New upstream version. Bugs fixed in Ubuntu:
  * Apport hook:
    - Only generate reports about supported kernel version (LP: #766150)
    - Include fglrx make file (LP: #792444)
    - Crashes in get_source() (LP: #532496)
    - Apport script fails (LP: #798498)
  * Openafs modules leaving empty make.log (LP: #593509)
  * '_' in module name causes mkdeb to fail (LP: #511619)
  * PRE_BUILD command invoked from wrong directory. (LP: #702638)
  * Speed up for large amounts of modules (LP: #786672)
  * Leaves temp files in /tmp (LP: #810134)
  * Generate .changes file for LP: upload (LP: #582668)
  * Don't change access rights of upstream source (LP: #582670)
  * common.postinst fails on failed build (LP: #595968)
  * Using a hyphen as part of PACKAGE_VERSION causes failures (LP: #599983)
  * dkms shouldn't source all the variables in dkms.conf (LP: #599985)
 -- Mario Limonciello <email address hidden> Thu, 14 Jul 2011 13:18:56 -0500

Changed in dkms (Ubuntu):
status: Fix Committed → Fix Released
Changed in dkms:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.