formatted copyright file errors

Bug #611364 reported by Kyle Nitzsche
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libgphoto
Unknown
Unknown
libgphoto2 (Debian)
Fix Released
Unknown
libgphoto2 (Ubuntu)
Triaged
Low
Unassigned

Bug Description

Hi,

The debian/copyright file is formatted (per draft Dep5) but has errors respecting the current version of the spec. (http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=135). It is marked invalid by my copyright parser and therefore licenses and copyrights cannot be reliably extracted.

I'll attach three items:
 * a report of the copyright generated by my copyright parser. I generated this after fixing the copyright's first line so that it is recognized as formatted. This shows that many of the errors are in using free form text in "License: " lines, which is not allowed. Spaces delimit license assertions. Every asserted license must be either defined in place, or have a free standing stanza to define it, or be a well-known short license name per the spec. Because "NONE" is asserted as a license, I added a "License: NONE" free-standing stanza whose text indicates that no license is asserted. I also added a GPL-improper stanza (reluctantly) to handle this case, which needs review. Also, every "Files: " stanza MUST have a "License: " line (a required field), even though that seems redundant, but this aids readability.
 * report of the copyright generated after I fixed it.
 * a bzr diff that contains the fixes.

Please review changes for accuracy and apply.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Also might want to remove the unnecessary period (".") from
License: TODO-Not_DFSG-free.

after applying the patch.

This will prevent unnecessarily duplicated license assertions differing only by this period. See the unnecessary duplicate in comment #2's attachment, at the bottom.

tags: added: patch
Revision history for this message
Victor Vargas (kamus) wrote :

I have sent this issue to upstream tracker for you, so you can track and follow status of this problem at: https://sourceforge.net/tracker/?func=detail&aid=3042766&group_id=8874&atid=108874 . I have checked branch included in Ubuntu Maverick and it's affected too (by the way, what application do you use for parsing copyright files?)

Changed in libgphoto2 (Ubuntu):
importance: Undecided → Low
status: New → Triaged
tags: added: patch-forwarded-upstream
removed: patch
Victor Vargas (kamus)
tags: added: patch-forwarded-debian
removed: patch-forwarded-upstream
Changed in libgphoto2 (Debian):
status: Unknown → New
Changed in libgphoto2 (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.