Tray 'Play/Pause' item doesn't reflect current state

I've tracked down cause of the problem:
There is a couple of bugs in tray.py update_menu()
1. There is a wrong if statement:
if self.player.is_stopped() or self.player.is_playing():
            stock_id = gtk.STOCK_MEDIA_PLAY
        elif self.player.is_paused():
            stock_id = gtk.STOCK_MEDIA_PAUSE
2. I'm not familiar with pygtk, but it seems that item's label should be updated another way:
Instead of:
  playpause_image = self.playpause_menuitem.get_image()
  playpause_image.set_from_stock(stock_id, gtk.ICON_SIZE_MENU)
should use:
  self.playpause_menuitem.set_label(stock_id)

Here is diff for tray.py:

149c149,152
< playpause_image = self.playpause_menuitem.get_image()
---
> if self.player.is_playing():
> stock_id = gtk.STOCK_MEDIA_PAUSE
> elif self.player.is_paused() or self.player.is_stopped():
> stock_id = gtk.STOCK_MEDIA_PLAY
151,156c154
< if self.player.is_stopped() or self.player.is_playing():
< stock_id = gtk.STOCK_MEDIA_PLAY
< elif self.player.is_paused():
< stock_id = gtk.STOCK_MEDIA_PAUSE
<
< playpause_image.set_from_stock(stock_id, gtk.ICON_SIZE_MENU)
---
> self.playpause_menuitem.set_label(stock_id)
211a210
>

I confirm that the change suggested by Ruhe fixes this issue.

Aren, if you could please review and apply the patch.

Fixed with r3450 inspired by the implementation in trunk.

This bug was fixed in the package exaile - 0.3.2.1-0buntu1

---------------
exaile (0.3.2.1-0buntu1) natty; urgency=low

  * New upstream release (LP: #714484, LP: #630221).
  * Drop debian/patches/jamendo_plugin_fix.diff,
    fixed upstream.
  * debian/patches/10_ubuntu_defaults.diff:
   - Don't enable shoutcast plugin.
  * debian/exaile.install: Don't install shoutcast plugin.
 -- Andrew Starr-Bochicchio <email address hidden> Sun, 13 Feb 2011 12:33:27 -0500