filter out fakey Free-Public-Wifi ad hoc networks

Sounds reasonable.

The only issue I see is that users shouldn't be blocked from actually setting up such a network if they really wanted to, so I think it should be treated as a special case for just this one -- filter it out from the scanning results, but still allow a user to connect to it with the "connect to a hidden network", if they were so inclined.

Right, of course. Agreed ;-)

Dustin,

I just wrote a quick patch for this, but it will still need some testing. So far, all I know is that it builds. This patch is in nm-applet rather than NM itself since we want to keep having NM report things as they are (see upstream bug) :)

I don't happen to have a Free Public WiFi network near me and probably won't until Thrusday. If you already know of a place where you can test this fix or have such a network near you, could you try to use the linked branch to create a package? I'll do the same on my end as soon as I can find one such location.

FWIW, bzr bd should be sufficient to build the binaries, or I can provide a pre-made package somewhere, at your convenience ;)

For testing purposes, it's probably best to not use a custom package like this until we know there is a "Free Public WiFi" in range, then quickly switch and restart the applet to see if the issue is fixed.

Hi Mathieu,

I have grabbed your branch locally.

Next time I see a "Free Public WiFi", I'll build it and try it. Note
that I'll be flying on Sunday, and in a hotel at UDS next week.
That's probably the best chance I'll have of seeing one.

Hmm, I tried building but 'bzr bd' fails on me. See attached log.

This bug was fixed in the package network-manager-applet - 0.8.4~git.20110228t141430.abba62f-0ubuntu1

---------------
network-manager-applet (0.8.4~git.20110228t141430.abba62f-0ubuntu1) natty; urgency=low

  * upstream snapshot 2011-02-28 14:14:30 (GMT)
    + abba62fe1c22422bb84f12875fd3612b90ead434
    - editor: fix usage of nm_connection_update_secrets() (LP: #721071)
    - release: bump version to 0.8.3.996 (0.8.4-beta2)
    - mobile: fix path to GtkBuilder file
    - applet: blacklist "Free Public Wifi" (LP: #659461)
    - applet: consolidate manufacturer default SSID lists
    - release: bump version to 0.8.3.995 (0.8.4-beta1)
    - release: update NEWS with changes since 0.8.2
    - editor: remove unused argument from CEPage 'initialized' signal
    - bluetooth: don't create empty plugin dirs when disabled (bgo #641300)
    - Updated Polish translation
  * debian/patches/nm-applet-use-indicator.patch: Further update indicator
    patch to fix memory leaks in get_best_icon_name_for_ap(). (LP: #724554)
  * debian/patches/nm-applet-use-indicator.patch: Set indicator icon for mobile
    according to the connection's current signal strength (LP: #726669)
  * debian/patches/indicator-accessible-desc.patch: provide accessible
    descriptions for the various icons and devices states for NetworkManager
    (LP: #719736)
 -- Mathieu Trudel-Lapierre <email address hidden> Fri, 04 Mar 2011 15:05:58 -0500

\o/