[dash] unity-2d-places DBus interface must be cleaned up
Bug #683026 reported by
Aurélien Gâteau
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-2d |
Fix Released
|
Medium
|
Ugo Riboni | ||
Bug Description
unity-2d-places exposes a DBus interface which does not follow common DBus conventions:
- The bus name "com.canonical.
- If there is an "active" property, there shouldn't be a "SetActive(bool)" method: setting the value of the "active" property should do what "SetActive()" does.
Using an adaptor instead of exposing the QML object is the base of that work.
Additionally it would be good to standardize on one term: it is confusing this part of the UI is referred to as the "dash" in some parts and "places" in other parts.
Related branches
lp:~uriboni/unity-2d/clean-up-dash-dbus
- Olivier Tilloy (community): Approve (code functional)
-
Diff: 249 lines (+78/-36)10 files modified.bzrignore (+1/-0)
launcher/UnityApplications/placeentry.cpp (+1/-1)
launcher/app/gesturehandler.cpp (+1/-1)
panel/applets/homebutton/homebuttonapplet.cpp (+1/-1)
places/app/CMakeLists.txt (+5/-0)
places/app/dash.xml (+47/-0)
places/app/dashdeclarativeview.cpp (+17/-1)
places/app/dashdeclarativeview.h (+2/-2)
places/app/places.cpp (+2/-29)
places/app/unity-2d-places.service.in (+1/-1)
| Changed in upicek: | |
| milestone: | none → m4 |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in upicek: | |
| milestone: | m4 → none |
| Changed in upicek: | |
| milestone: | none → m5 |
| Changed in upicek: | |
| assignee: | nobody → Aurélien Gâteau (agateau) |
| affects: | upicek → unity-2d |
| Changed in unity-2d: | |
| milestone: | 0.6 → none |
| milestone: | none → 3.4 |
| visibility: | private → public |
| description: | updated |
| summary: |
- [dash] unity-qt-places DBus interface must be cleaned up + [dash] unity-2d-places DBus interface must be cleaned up |
| Changed in unity-2d: | |
| milestone: | 3.4 → 3.6 |
| Changed in unity-2d: | |
| assignee: | Aurélien Gâteau (agateau) → nobody |
| Changed in unity-2d: | |
| milestone: | 3.6 → 3.8 |
| Changed in unity-2d: | |
| assignee: | nobody → Ugo Riboni (uriboni) |
| Changed in unity-2d: | |
| status: | Confirmed → In Progress |
| Changed in unity-2d: | |
| status: | In Progress → Fix Committed |
| Changed in unity-2d: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
