{find,clear,store}_credentials should send CredentialsError signal on errors
Bug #696676 reported by
Natalia Bidart
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Single Sign On Client |
Fix Released
|
High
|
Natalia Bidart | ||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
High
|
Natalia Bidart | ||
Bug Description
Since the code located at Credentials class is not failing when there is an error on {find,clear,
We need those methods to properly errback so the higher class can act accordingly.
Related branches
lp:~nataliabidart/ubuntu-sso-client/really-errback-on-error
- Alejandro J. Cura (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 244 lines (+84/-25)4 files modifiedubuntu_sso/credentials.py (+3/-4)
ubuntu_sso/main.py (+7/-3)
ubuntu_sso/tests/test_credentials.py (+6/-15)
ubuntu_sso/tests/test_main.py (+68/-3)
| Changed in ubuntu-sso-client: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| Changed in ubuntu-sso-client: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-sso-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-sso-client - 1.1.8-0ubuntu1
---------------
ubuntu-sso-client (1.1.8-0ubuntu1) natty; urgency=low
* New upstream release:
[ Natalia B. Bidart <email address hidden>]
- The service should shutdown when unused
(LP: #701606),
- On error, {find,clear,
signal (LP: #696676).
- No more gobject dependency on non-GUI classes!
(LP: #695798).
- After login, if the storing of credentials fails, send LoginError
(LP: #693531).
- Use ubuntuone-dev-tools to run the tests and the lint checker
(LP: #686606).
-- Natalia Bidart (nessita) <email address hidden> Wed, 12 Jan 2011 15:59:23 -0300