ginn

Ginn PPA config files are installed in the wrong place

Bug #699925 reported by Gustavo Luiz Duarte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ginn
Fix Released
Undecided
Stephen M. Webb

Bug Description

Ginn PPA package installs config files (wishes.xml) in /usr/share. It should be installed in /etc/ginn instead.

Related branches

lp:~bregma/ginn/add-more-wishes-paths
Mohamed IKBEL Boulabiar (community): Approve
Diff: 43 lines (+14/-0)
2 files modified
src/ginn.c (+4/-0)
src/ginn.pod (+10/-0)
lp:ginn/ubuntu
lp:~bregma/ginn/fix-699925
Gustavo Luiz Duarte (community): Approve
Mohamed IKBEL Boulabiar (community): Approve
Diff: 81 lines (+37/-7)
3 files modified
etc/Makefile.am (+6/-0)
src/Makefile.am (+1/-1)
src/ginn.c (+30/-6)
lp:ubuntu/natty/ginn
Revision history for this message
Stephen M. Webb (bregma) wrote :

The application must be modified to look for default configuration files in /etc/ginn and the packaging must be modified to handle the configuration files on package configuration and purge.

Changed in ginn:
assignee: nobody → Stephen M. Webb (bregma)
status: New → In Progress
Stephen M. Webb (bregma)
Changed in ginn:
status: In Progress → Fix Committed
Revision history for this message
Gustavo Luiz Duarte (gustavold) wrote :

I'm not sure if the patch in lp:~utouch-packaging/ginn/ubuntu is the best way to fix this bug as it fixes on packaging instead of the build system. Doing a "make install" still installs wishes.xml on ${prefix}/share/ginn only.
Should I open a different bug regarding the "make install" issue?

Revision history for this message
Stephen M. Webb (bregma) wrote :

This patch follows the Ubuntu policy manual, in particular section [10.7.3] <http://people.canonical.com/~cjwatson/ubuntu-policy/policy.html/ch-files.html#s10.7.3>.

The wishes.xml file found in the sources is a template file. The /etc/ginn/wishes file should not be overwritten by a package install (either via a deb package or a "make install" from the source tree) in case it has customizations in it. This is the safest course of action. If you are trying to overwrite the existing customizations to recover from an error, you can just manually copy the template file, either from /usr/share/ginn or from your local source tree.

One additional change that could be filed under a separate bug is to use a $HOME/.ginnrc file for user-local customizations.

Stephen M. Webb (bregma)
Changed in ginn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.