Ubuntu
kickseed package

kickstart not removing logical volume data

Bug #708548 reported by Jan
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kickseed (Ubuntu)
Fix Released
Medium
Colin Watson
Lucid
Fix Released
Medium
Colin Watson
Ubuntu ubuntu-10.04.4
Maverick
Won't Fix
Medium
Colin Watson
Ubuntu maverick-updates
Natty
Won't Fix
Medium
Colin Watson
Ubuntu natty-updates

Bug Description

Stable release update justification:

Impact: The 'clearpart --all --initlabel' Kickstart command fails to fulfil its contract of not asking interactively whether it's OK to discard previous partitions.
Development branch: Fixed upstream in kickseed 0.56 by adding a couple of extra preseeding translations.
Patch:
 http://bazaar.launchpad.net/~ubuntu-core-dev/kickseed/lucid-proposed/revision/282?compare_revid=279
 http://bazaar.launchpad.net/~ubuntu-core-dev/kickseed/maverick-proposed/revision/282?compare_revid=279
 http://bazaar.launchpad.net/~ubuntu-core-dev/kickseed/natty-proposed/revision/284?compare_revid=281
TEST CASE: Install a *scratch* system (very important; this test may well wipe out all other data on the system!) with LVM; then perform a Kickstart installation with 'clearpart --all --initlabel' in the Kickstart file. (You can omit other directives if you like, and you'll just be prompted for them.) You should not be asked the question from the original bug report.
Regression potential: No upgrade regressions possible. It would be good to confirm that existing functional Kickstart files still work.

Original bug report:

Binary package hint: debian-installer

From my understanding "clearpart --all --initlabel" should clear all partitions no matter if they are containing LVMs or not.
This is the case in Centos. Ubuntu somehow asks if it should do so:

\quote
[!!] Partition disks

The selected device already contains the following LVM logical volumes, volume groups and physical volumes which are about to be removed:

Logical volume(s) to be removed:
[...]
Note that this will also permanently erase any data currently on the logical volumes.
Remove existing logical volume data?
\quote end

I am experiencing this problem from version 8.10 to version 10.10 (I have not tried earlier versions)

Regards,
Jan

See original description
Jan (jan-welker)
tags: added: clearpart initlabel kickstart lvm
Revision history for this message
LiohMoeller (liohmoeller) wrote :

I have encountered the same problem on Maverick. Is there any solution for that, yet?

Kind Regards
Marcus

Revision history for this message
LiohMoeller (liohmoeller) wrote :

Here is a workaround, btw:

preseed partman-lvm/confirm_nooverwrite boolean true

Greets
Marcus

Revision history for this message
Colin Watson (cjwatson) wrote :

We should definitely preseed partman-lvm/confirm_nooverwrite in kickseed. However, that's not the question that's being displayed to the original reporter.

affects: debian-installer (Ubuntu) → kickseed (Ubuntu)
Revision history for this message
Colin Watson (cjwatson) wrote :

Fixed upstream.

Changed in kickseed (Ubuntu):
assignee: nobody → Colin Watson (cjwatson)
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Jan (jan-welker) wrote :

@Colin:

Which release will your fix affect? 11.04 or will it be fixed in the current version 10.10?

Regards,
Jan

Revision history for this message
Colin Watson (cjwatson) wrote : Re: [Bug 708548] Re: kickstart not removing logical volume data

Normally it would just be 11.04, but since Kickstart and LVM are
naturals for stable release deployments I think it would be good to get
this fixed in 10.04 and 10.10 as well. I'll look into this after the
forthcoming 10.04.2 point release.

Changed in kickseed (Ubuntu Lucid):
importance: Undecided → Medium
milestone: none → ubuntu-10.04.3
status: New → Triaged
Changed in kickseed (Ubuntu Maverick):
importance: Undecided → Medium
milestone: none → maverick-updates
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kickseed - 0.56ubuntu1

---------------
kickseed (0.56ubuntu1) oneiric; urgency=low

  * Resynchronise with Debian. Remaining changes:
    - Add basic RAID support. (LVM-on-RAID won't quite work yet.)
    - Add basic iSCSI support.

kickseed (0.56) unstable; urgency=low

  * Preseed partman-lvm/confirm_overwrite as well as partman-lvm/confirm.
  * Preseed partman-lvm/device_remove_lvm when confirming logvol results,
    since Kickstart doesn't have a separate control with a one-to-one
    correspondence to this (LP: #708548).
  * Don't perform an extra layer of backslash interpretation when reading
    lines from Kickstart files (LP: #715746). Note that this may break some
    existing Kickstart files that tried to work around the previous
    behaviour; this seems like the lesser of two evils.
  * Allow ksdevice=bootif, with netcfg 1.63.
 -- Colin Watson <email address hidden> Sat, 09 Jul 2011 10:00:30 +0100

Changed in kickseed (Ubuntu):
status: Fix Committed → Fix Released
Colin Watson (cjwatson)
Changed in kickseed (Ubuntu Natty):
status: New → Triaged
importance: Undecided → Medium
milestone: none → natty-updates
Changed in kickseed (Ubuntu Lucid):
assignee: nobody → Colin Watson (cjwatson)
Changed in kickseed (Ubuntu Maverick):
assignee: nobody → Colin Watson (cjwatson)
Changed in kickseed (Ubuntu Natty):
assignee: nobody → Colin Watson (cjwatson)
Changed in kickseed (Ubuntu Lucid):
milestone: ubuntu-10.04.3 → ubuntu-10.04.4
status: Triaged → In Progress
Colin Watson (cjwatson)
Changed in kickseed (Ubuntu Maverick):
status: Triaged → In Progress
Changed in kickseed (Ubuntu Natty):
status: Triaged → In Progress
Colin Watson (cjwatson)
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote :

SRU team ack. Please accept into lucid-proposed, maverick-proposed, and natty-proposed.

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Jan, or anyone else affected,

Accepted kickseed into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in kickseed (Ubuntu Lucid):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in kickseed (Ubuntu Maverick):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Hello Jan, or anyone else affected,

Accepted kickseed into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in kickseed (Ubuntu Natty):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Hello Jan, or anyone else affected,

Accepted kickseed into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Ubuntu Foundations Team Bug Bot (crichton)
tags: added: testcase
Revision history for this message
Martin Pitt (pitti) wrote :

Is there really much point in fixing this in maverick now? It has lived most of its live with this bug, and will go EOL in two months.

Revision history for this message
James Page (james-page) wrote :

Testing for lucid:

Installed LVM based lucid server install using preseeds

1) Confirmed existing bug report using attached kickstart file - prompted for confirmation to remove existing LV's during install.

2a) Retested using proposed mini.iso and archive components - still prompted for confirmation to remove existing LV's during install.

I did a bit of code diving and noticed that the LVM device removals only get preseeded if the 'logvol' kickstart commands are using - if simple partitioning is present ~(as in my test kickstart) then the install will still prompt.

2b) Retested using kickstart that sets up logical volumes - was not prompted for confirmation of device removal.

Jean-Baptiste Lallement (jibel)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kickseed - 0.54ubuntu1.10.04.2

---------------
kickseed (0.54ubuntu1.10.04.2) lucid-proposed; urgency=low

  * Fix iSCSI ks_preseed calls to include a type field (LP: #810068).

kickseed (0.54ubuntu1.10.04.1) lucid-proposed; urgency=low

  * Preseed partman-lvm/confirm_overwrite as well as partman-lvm/confirm.
  * Preseed partman-lvm/device_remove_lvm when confirming logvol results,
    since Kickstart doesn't have a separate control with a one-to-one
    correspondence to this (LP: #708548).
 -- Colin Watson <email address hidden> Fri, 20 Jan 2012 16:51:53 +0000

Changed in kickseed (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Resetting verification tags for natty.

Changed in kickseed (Ubuntu Maverick):
status: Fix Committed → Won't Fix
Martin Pitt (pitti)
tags: added: verification-needed
removed: verification-done
Revision history for this message
Rolf Leggewie (r0lf) wrote :

natty has seen the end of its life and is no longer receiving any updates. Marking the natty task for this ticket as "Won't Fix".

Changed in kickseed (Ubuntu Natty):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.